mirror of
https://github.com/pulsar-edit/pulsar.git
synced 2024-09-11 11:15:24 +03:00
meta: Don't exclude 'loophole' or 'pegjs' packages
We need these when typing a "tab" character in a document or file. (Without 'loophole' and 'pegjs' in the app bundle, 'snippets' tries and fails to require() those packages, and it errors out every time you type a tab character.) Explanation: Our PegJS files _aren't_ pre-compiled at the moment. We removed the old build scripts that used to transpile these files during the build, and without replacing that functionality yet. So... When a certain PegJS --> JS file isn't available in the 'snippets' package (because it hasn't been transpiled to plain JS yet yet), 'snippets' require()s some modules that let it live-transpile the needed code, or at least that's what I think it's doing in that scenario. If the modules it conditionally require()s in that scenario aren't in the Pulsar bundle, due to being explicitly excluded, then we get a require() error, since they legitimately aren't in the bundle.
This commit is contained in:
parent
20b3d51022
commit
26def85bb0
@ -94,9 +94,9 @@ let options = {
|
||||
"!**/deps/libgit2",
|
||||
"!**/node_modules/spellchecker/vendor/hunspell/.*",
|
||||
// These are only required in dev-mode, when pegjs grammars aren't precompiled
|
||||
"!node_modules/loophole",
|
||||
"!node_modules/pegjs",
|
||||
"!node_modules/.bin/pegjs",
|
||||
// "!node_modules/loophole", // Note: We do need these packages. Because our PegJS files _aren't_ all pre-compiled.
|
||||
// "!node_modules/pegjs", // Note: if these files are excluded, 'snippets' package breaks.
|
||||
// "!node_modules/.bin/pegjs",
|
||||
// node_modules of the fuzzy-native package are only required for building it
|
||||
"!node_modules/fuzzy-native/node_modules",
|
||||
// Ignore *.cc and *.h files from native modules
|
||||
|
Loading…
Reference in New Issue
Block a user