Don't make hidden input a child of Editor's scrollView

If the input element is a child of the scroll view, then focusing it can end up changing the scroll position of the view behind our backs. We *only* want to scroll the view via our interface on editor, because a bunch of of special code needs to run when we scroll. We can't just have the browser scrolling that view around willy-nilly.

spec/app/editor-spec.coffee

@@ -882,6 +882,12 @@ describe "Editor", ->
         editor.selectAll()
         expect(editor.scrollTop()).toBe 0
 
+        # regression: does not scroll the scroll view when the editor is refocused
+        editor.hiddenInput.blur()
+        editor.hiddenInput.focus()
+        expect(editor.scrollTop()).toBe 0
+        expect(editor.scrollView.scrollTop()).toBe 0
+
         # does auto-scroll when the selection is cleared
         editor.moveCursorDown()
         expect(editor.scrollTop()).toBeGreaterThan(0)

src/app/cursor-view.coffee

@@ -32,20 +32,18 @@ class CursorView extends View
     super
 
   updateAppearance: (options={}) ->
+    autoscroll = options.autoscroll ? true
     screenPosition = @getScreenPosition()
     pixelPosition = @getPixelPosition()
     @css(pixelPosition)
-
+    @autoscroll() if @cursor.isLastCursor() and autoscroll
-    if @cursor == @editor.getLastCursor()
-      @autoscroll() if options.autoscroll ? true
-      @editor.hiddenInput.css(pixelPosition)
-
     @setVisible(@cursor.isVisible() and not @editor.isFoldedAtScreenRow(screenPosition.row))
 
   getPixelPosition: ->
     @editor.pixelPositionForScreenPosition(@getScreenPosition())
 
   autoscroll: ->
+    pixelPosition =
     @editor.scrollTo(@getPixelPosition())
 
   setVisible: (visible) ->

src/app/cursor.coffee

@@ -49,6 +49,9 @@ class Cursor
 
   isVisible: -> @visible
 
+  isLastCursor: ->
+    this == @editor.getLastCursor()
+
   clearSelection: ->
     if @selection
       @selection.clear() unless @selection.retainSelection

src/app/editor.coffee

@@ -18,9 +18,9 @@ class Editor extends View
   @content: (params) ->
     @div class: @classes(params), tabindex: -1, =>
       @subview 'gutter', new Gutter
+      @input class: 'hidden-input', outlet: 'hiddenInput'
       @div class: 'scroll-view', outlet: 'scrollView', =>
         @div class: 'lines', outlet: 'renderedLines', =>
-          @input class: 'hidden-input', outlet: 'hiddenInput'
       @div class: 'vertical-scrollbar', outlet: 'verticalScrollbar', =>
         @div outlet: 'verticalScrollbarContent'