Merge pull request #14108 from atom/fb-mdt-remember-moved-item-positions

🐛 Fix observation of moved items

spec/workspace-spec.js

@@ -2326,6 +2326,23 @@ i = /test/; #FIXME\
       })
     })
   })
+
+  describe('when an item is moved', () => {
+    it('stores the new location', () => {
+      const ITEM_URI = 'atom://test'
+      const item = {
+        getURI: () => ITEM_URI,
+        getDefaultLocation: jasmine.createSpy().andReturn('left'),
+        getElement: () => document.createElement('div')
+      }
+      const centerPane = workspace.getActivePane()
+      centerPane.addItem(item)
+      const dockPane = atom.workspace.getRightDock().getActivePane()
+      spyOn(workspace.itemLocationStore, 'save')
+      centerPane.moveItemToPane(item, dockPane)
+      expect(workspace.itemLocationStore.save).toHaveBeenCalledWith(ITEM_URI, 'right')
+    })
+  })
 })
 
 const escapeStringRegex = str => str.replace(/[|\\{}()[\]^$+*?.]/g, '\\$&')

src/workspace.js

@@ -296,13 +296,15 @@ module.exports = class Workspace extends Model {
 
   subscribeToMovedItems () {
     for (const paneContainer of this.getPaneContainers()) {
-      paneContainer.onDidAddPaneItem(({item}) => {
+      paneContainer.observePanes(pane => {
-        if (typeof item.getURI === 'function') {
+        pane.onDidAddItem(({item}) => {
-          const uri = item.getURI()
+          if (typeof item.getURI === 'function') {
-          if (uri != null) {
+            const uri = item.getURI()
-            this.itemLocationStore.save(item.getURI(), paneContainer.getLocation())
+            if (uri != null) {
+              this.itemLocationStore.save(item.getURI(), paneContainer.getLocation())
+            }
           }
-        }
+        })
       })
     }
   }