pulsar-edit/pulsar
1
1
Fork 0
mirror of https://github.com/pulsar-edit/pulsar.git synced 2024-09-20 15:37:46 +03:00
Code Issues Packages Projects Releases Wiki Activity

Always allow to destroy free-form folds from the gutter

Browse Source
This commit is contained in:
Antonio Scandurra 2017-05-16 14:36:50 +02:00
parent ad6202cadb
commit 3b3505d969
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
spec/text-editor-component-spec.js
View File

@ -2798,7 +2798,7 @@ describe('TextEditorComponent', () => {
it('toggles folding when clicking on the right icon of a foldable line number', async () => {
const {component, element, editor} = buildComponent()
const target = element.querySelectorAll('.line-number')[1].querySelector('.icon-right')
let target = element.querySelectorAll('.line-number')[1].querySelector('.icon-right')
expect(editor.isFoldedAtScreenRow(1)).toBe(false)
component.didMouseDownOnLineNumberGutter({target, button: 0, clientY: clientTopForLine(component, 1)})
@ -2806,7 +2806,16 @@ describe('TextEditorComponent', () => {
await component.getNextUpdatePromise()
component.didMouseDownOnLineNumberGutter({target, button: 0, clientY: clientTopForLine(component, 1)})
await component.getNextUpdatePromise()
expect(editor.isFoldedAtScreenRow(1)).toBe(false)
editor.foldBufferRange([[5, 12], [5, 17]])
await component.getNextUpdatePromise()
expect(editor.isFoldedAtScreenRow(5)).toBe(true)
target = element.querySelectorAll('.line-number')[6].querySelector('.icon-right')
component.didMouseDownOnLineNumberGutter({target, button: 0, clientY: clientTopForLine(component, 5)})
expect(editor.isFoldedAtScreenRow(5)).toBe(false)
})
it('autoscrolls when dragging near the top or bottom of the gutter', async () => {

2
src/text-editor-component.js
View File

@ -1704,7 +1704,7 @@ class TextEditorComponent {
const clickedScreenRow = this.screenPositionForMouseEvent(event).row
const startBufferRow = model.bufferPositionForScreenPosition([clickedScreenRow, 0]).row
if (target && target.matches('.foldable .icon-right')) {
if (target && (target.matches('.foldable .icon-right') || target.matches('.folded .icon-right'))) {
model.toggleFoldAtBufferRow(startBufferRow)
return
}