pulsar-edit/pulsar
1
1
Fork 0
mirror of https://github.com/pulsar-edit/pulsar.git synced 2024-09-11 11:15:24 +03:00
Code Issues Packages Projects Releases Wiki Activity

Use config.onDidChange instead of config.observe to avoid immediate callback

Browse Source
This commit is contained in:
confused-Techie 2023-08-13 14:52:39 -07:00
parent f10ac4f727
commit 3d164261db
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/workspace.js
View File

@ -177,6 +177,7 @@ module.exports = class Workspace extends Model {
constructor(params) {
super(...arguments);
this.disposables = new CompositeDisposable();
this.updateWindowTitle = this.updateWindowTitle.bind(this);
this.updateDocumentEdited = this.updateDocumentEdited.bind(this);
this.didDestroyPaneItem = this.didDestroyPaneItem.bind(this);
@ -381,10 +382,11 @@ module.exports = class Workspace extends Model {
this.subscribeToMovedItems();
this.subscribeToDockToggling();
// We use `this.config` since `atom.config` isn't declared globally yet during test runs
this.config.observe('core.addCurrentTabToWindowTitle', () => {
this.updateWindowTitle();
});
this.disposables.add(
this.config.onDidChange('core.addCurrentTabToWindowTitle', () => {
this.updateWindowTitle();
})
);
}
consumeServices({ serviceHub }) {
@ -684,10 +686,7 @@ module.exports = class Workspace extends Model {
// open.
updateWindowTitle() {
let itemPath, itemTitle, projectPath, representedPath;
// We have to use optional chaining on `atom` here, as the observe callback in
// init, may call this function prior to the world being spun up during test runs
// Should not have any effect in production
const appName = atom?.getAppName() ?? "";
const appName = atom.getAppName();
const left = this.project.getPaths();
const projectPaths = left != null ? left : [];
const item = this.getActivePaneItem();