cleaning up

resources/mac/entitlements.plist

@@ -4,9 +4,5 @@
   <dict>
     <key>com.apple.security.cs.allow-unsigned-executable-memory</key>
     <true/>
-    <key>com.apple.security.cs.allow-jit</key>
-    <true/>
-    <key>com.apple.security.cs.disable-library-validation</key>
-    <true/>
   </dict>
 </plist>

script/lib/notarize-on-mac.js

@@ -13,6 +13,6 @@ module.exports = async function(packagedAppPath) {
       appleIdPassword: appleIdPassword
     });
   } catch (e) {
-    //  throw new Error(e);
+    throw new Error(e);
   }
 };

script/vsts/nightly-release.yml

@@ -15,46 +15,46 @@ jobs:
   - template: platforms/macos.yml
   - template: platforms/linux.yml
 
-#
+
-#  - job: Release
+  - job: Release
-#    pool:
+    pool:
-#      vmImage: vs2015-win2012r2 # needed for Python 2.7 and gyp
+      vmImage: vs2015-win2012r2 # needed for Python 2.7 and gyp
-#
+
-#    dependsOn:
+    dependsOn:
-#      - GetReleaseVersion
+      - GetReleaseVersion
-#      - Windows
+      - Windows
-#      - Linux
+      - Linux
-#      - macOS_tests
+      - macOS_tests
-#
+
-#    variables:
+    variables:
-#      ReleaseVersion: $[ dependencies.GetReleaseVersion.outputs['Version.ReleaseVersion'] ]
+      ReleaseVersion: $[ dependencies.GetReleaseVersion.outputs['Version.ReleaseVersion'] ]
-#
+
-#    steps:
+    steps:
-#      - task: NodeTool@0
+      - task: NodeTool@0
-#        inputs:
+        inputs:
-#          versionSpec: 10.2.1
+          versionSpec: 10.2.1
-#        displayName: Install Node.js 10.2.1
+        displayName: Install Node.js 10.2.1
-#
+
-#      # This has to be done separately because VSTS inexplicably
+       #This has to be done separately because VSTS inexplicably
-#      # exits the script block after `npm install` completes.
+       #exits the script block after `npm install` completes.
-#      - script: |
+      - script: |
-#          cd script\vsts
+          cd script\vsts
-#          npm install
+          npm install
-#        displayName: npm install
+        displayName: npm install
-#
+
-#      - task: DownloadBuildArtifacts@0
+      - task: DownloadBuildArtifacts@0
-#        inputs:
+        inputs:
-#          itemPattern: '**'
+          itemPattern: '**'
-#          downloadType: 'specific'
+          downloadType: 'specific'
-#        displayName: Download Release Artifacts
+        displayName: Download Release Artifacts
-#
+
-#      - script: |
+      - script: |
-#          node $(Build.SourcesDirectory)\script\vsts\upload-artifacts.js --create-github-release --assets-path "$(System.ArtifactsDirectory)" --linux-repo-name "atom"
+          node $(Build.SourcesDirectory)\script\vsts\upload-artifacts.js --create-github-release --assets-path "$(System.ArtifactsDirectory)" --linux-repo-name "atom"
-#        env:
+        env:
-#          GITHUB_TOKEN: $(GITHUB_TOKEN)
+          GITHUB_TOKEN: $(GITHUB_TOKEN)
-#          ATOM_RELEASE_VERSION: $(ReleaseVersion)
+          ATOM_RELEASE_VERSION: $(ReleaseVersion)
-#          ATOM_RELEASES_S3_KEY: $(ATOM_RELEASES_S3_KEY)
+          ATOM_RELEASES_S3_KEY: $(ATOM_RELEASES_S3_KEY)
-#          ATOM_RELEASES_S3_SECRET: $(ATOM_RELEASES_S3_SECRET)
+          ATOM_RELEASES_S3_SECRET: $(ATOM_RELEASES_S3_SECRET)
-#          ATOM_RELEASES_S3_BUCKET: $(ATOM_RELEASES_S3_BUCKET)
+          ATOM_RELEASES_S3_BUCKET: $(ATOM_RELEASES_S3_BUCKET)
-#          PACKAGE_CLOUD_API_KEY: $(PACKAGE_CLOUD_API_KEY)
+          PACKAGE_CLOUD_API_KEY: $(PACKAGE_CLOUD_API_KEY)
-#        displayName: Create Nightly Release
+        displayName: Create Nightly Release

script/vsts/platforms/macos.yml

@@ -9,18 +9,9 @@ jobs:
       IsReleaseBranch: $[ dependencies.GetReleaseVersion.outputs['Version.IsReleaseBranch'] ]
       IsSignedZipBranch: $[ dependencies.GetReleaseVersion.outputs['Version.IsSignedZipBranch'] ]
     pool:
-      vmImage: macos-10.14
+      vmImage: macos-10.13
 
     steps:
-      - script: sw_vers -productVersion
-        displayName: Check MacOs version
-
-      - script: gcc --version
-        displayName: Check XCode version
-      
-      - script: xcrun --sdk macosx --show-sdk-path
-        displayName: Check MacOS SDK version
-      
       - task: NodeTool@0
         inputs:
           versionSpec: 10.2.1
@@ -72,7 +63,7 @@ jobs:
           ATOM_MAC_CODE_SIGNING_KEYCHAIN_PASSWORD: $(ATOM_MAC_CODE_SIGNING_KEYCHAIN_PASSWORD)
           AC_USER: $(AC_USER)
           AC_PASSWORD: $(AC_PASSWORD)
-          
+
       - script: |
           cp $(Build.SourcesDirectory)/out/*.zip $(Build.ArtifactStagingDirectory)
         displayName: Stage Artifacts
@@ -106,7 +97,7 @@ jobs:
     dependsOn: macOS_build
     timeoutInMinutes: 180
     pool:
-      vmImage: macos-10.14
+      vmImage: macos-10.13
     strategy:
       maxParallel: 3
       matrix: