mirror of
https://github.com/pulsar-edit/pulsar.git
synced 2024-09-20 07:28:08 +03:00
add comment advising against adding window listeners in tooltip manager
This commit is contained in:
parent
dc1f6a02f3
commit
51b873345f
@ -152,6 +152,7 @@ class TooltipManager {
|
||||
tooltip.hide()
|
||||
}
|
||||
|
||||
// note: adding a listener here adds a new listener for every tooltip element that's registered. Adding unnecessary listeners is bad for performance. It would be better to add/remove listeners when tooltips are actually created in the dom.
|
||||
window.addEventListener('resize', hideTooltip)
|
||||
|
||||
const disposable = new Disposable(() => {
|
||||
|
Loading…
Reference in New Issue
Block a user