Add spec for onDidRemoveItem observers when moving items to other panes

This commit is contained in:
Nathan Sobo 2014-08-27 10:12:34 -06:00
parent 9bd2eec4bc
commit 548018e9b2
2 changed files with 8 additions and 1 deletions

View File

@ -366,6 +366,13 @@ describe "Pane", ->
expect(pane1.getItems()).toEqual [item1, item3]
expect(pane2.getItems()).toEqual [item4, item2, item5]
it "invokes ::onDidRemoveItem() observers", ->
events = []
pane1.onDidRemoveItem (event) -> events.push(event)
pane1.moveItemToPane(item2, pane2, 1)
expect(events).toEqual [{item: item2, index: 1, destroyed: false}]
describe "when the moved item the last item in the source pane", ->
beforeEach ->
item5.destroy()

View File

@ -211,7 +211,7 @@ class Pane extends Model
@addItem(item, index + i) for item, i in items
items
removeItem: (item, destroyed) ->
removeItem: (item, destroyed=false) ->
index = @items.indexOf(item)
return if index is -1
if item is @activeItem