mirror of
https://github.com/pulsar-edit/pulsar.git
synced 2024-09-11 11:15:24 +03:00
Debugging when a package service is incorrect
This PR is basically to add some debugging info for providers and consumers. Currently, when a package registers as a service provider or a service consumer, and doesn't actually implements the right interface (a function, basically) the package loader silently ignores it. This commit adds a warning to console so that we know a package did the wrong thing.
This commit is contained in:
parent
313793d78d
commit
8064ea6c6b
@ -428,6 +428,8 @@ module.exports = class Package {
|
|||||||
methodName = versions[version];
|
methodName = versions[version];
|
||||||
if (typeof this.mainModule[methodName] === 'function') {
|
if (typeof this.mainModule[methodName] === 'function') {
|
||||||
servicesByVersion[version] = this.mainModule[methodName]();
|
servicesByVersion[version] = this.mainModule[methodName]();
|
||||||
|
} else {
|
||||||
|
console.warn(`Package ${this.name} declares it provides ${name}@${version} but it doesn't expose a function in ${methodName}`)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
this.activationDisposables.add(
|
this.activationDisposables.add(
|
||||||
@ -447,6 +449,8 @@ module.exports = class Package {
|
|||||||
this.mainModule[methodName].bind(this.mainModule)
|
this.mainModule[methodName].bind(this.mainModule)
|
||||||
)
|
)
|
||||||
);
|
);
|
||||||
|
} else {
|
||||||
|
console.warn(`Package ${this.name} declares it consumes ${name}@${version} but it doesn't expose a function in ${methodName}`)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user