pulsar-edit/pulsar
1
1
Fork 0
mirror of https://github.com/pulsar-edit/pulsar.git synced 2024-11-10 10:17:11 +03:00
Code Issues Packages Projects Releases Wiki Activity

When observing a key path, compare its new & old values structurally

Browse Source
This commit is contained in:
Nathan Sobo 2012-12-17 19:00:47 -07:00
parent a7d1a29748
commit b82fe25b99
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
spec/app/config-spec.coffee
View File

@ -25,13 +25,17 @@ describe "Config", ->
config.get("foo.bar.baz").push("b") config.get("foo.bar.baz").push("b")
config.update() config.update()
expect(observeHandler).toHaveBeenCalledWith config.get("foo.bar.baz") expect(observeHandler).toHaveBeenCalledWith config.get("foo.bar.baz")
observeHandler.reset()
config.update()
expect(observeHandler).not.toHaveBeenCalled()
describe ".observe(keyPath)", -> describe ".observe(keyPath)", ->
observeHandler = null observeHandler = null
beforeEach -> beforeEach ->
observeHandler = jasmine.createSpy("observeHandler") observeHandler = jasmine.createSpy("observeHandler")
config.foo = { bar: { baz: "value 1" } } config.set("foo.bar.baz", "value 1")
config.observe "foo.bar.baz", observeHandler config.observe "foo.bar.baz", observeHandler
it "fires the given callback with the current value at the keypath", -> it "fires the given callback with the current value at the keypath", ->

2
src/app/config.coffee
View File

@ -83,7 +83,7 @@ class Config
previousValue = _.clone(value) previousValue = _.clone(value)
updateCallback = => updateCallback = =>
value = @get(keyPath) value = @get(keyPath)
unless value == previousValue unless _.isEqual(value, previousValue)
previousValue = _.clone(value) previousValue = _.clone(value)
callback(value) callback(value)