From 7ef8f06cd25a2d1e9d6c514ef798b8402129e904 Mon Sep 17 00:00:00 2001 From: Nathan Sobo Date: Thu, 18 Apr 2019 12:25:57 -0600 Subject: [PATCH] Only upload Windows crash reports if the S3 key environment var is null This seems like a more robust test than the isRelease variable I was testing previously. Our goal is to not leak secrets such as the S3 key, so this is a more direct test of that. --- script/vsts/platforms/windows.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/script/vsts/platforms/windows.yml b/script/vsts/platforms/windows.yml index 515daff90..d1fe8db3a 100644 --- a/script/vsts/platforms/windows.yml +++ b/script/vsts/platforms/windows.yml @@ -114,7 +114,7 @@ jobs: PathtoPublish: $(Build.ArtifactStagingDirectory)/crash-reports ArtifactName: crash-reports displayName: Publish crash reports on non-release branch - condition: and(failed(), eq(variables['IsReleaseBranch'], 'false')) + condition: and(failed(), eq(variables['ATOM_RELEASES_S3_KEY'], '')) - task: PublishBuildArtifacts@1 inputs: