🎨 Rename to ::onDidRequestAutoscroll

This commit is contained in:
Antonio Scandurra 2015-09-25 10:57:09 +02:00
parent b0d70a63c6
commit ce714b9852
4 changed files with 8 additions and 10 deletions

View File

@ -1220,9 +1220,9 @@ describe "DisplayBuffer", ->
expect(displayBuffer.getDecorations(class: 'one').length).toEqual 1
describe "::scrollToScreenPosition(position, [options])", ->
it "triggers ::onDidChangeScrollPosition with the logical coordinates along with the options", ->
scrollSpy = jasmine.createSpy("::onDidChangeScrollPosition")
displayBuffer.onDidChangeScrollPosition(scrollSpy)
it "triggers ::onDidRequestAutoscroll with the logical coordinates along with the options", ->
scrollSpy = jasmine.createSpy("::onDidRequestAutoscroll")
displayBuffer.onDidRequestAutoscroll(scrollSpy)
displayBuffer.scrollToScreenPosition([8, 20])
displayBuffer.scrollToScreenPosition([8, 20], center: true)

View File

@ -125,7 +125,7 @@ class DisplayBuffer extends Model
onDidChangeCharacterWidths: (callback) ->
@emitter.on 'did-change-character-widths', callback
onDidChangeScrollPosition: (callback) ->
onDidRequestAutoscroll: (callback) ->
@emitter.on 'did-change-scroll-position', callback
observeDecorations: (callback) ->

View File

@ -159,9 +159,7 @@ class TextEditorPresenter
@disposables.add @model.onDidAddDecoration(@didAddDecoration.bind(this))
@disposables.add @model.onDidAddCursor(@didAddCursor.bind(this))
@disposables.add @model.onDidChangeScrollPosition(@didChangeScrollPosition.bind(this))
# @disposables.add @model.onDidChangeScrollTop(@setScrollTop.bind(this))
# @disposables.add @model.onDidChangeScrollLeft(@setScrollLeft.bind(this))
@disposables.add @model.onDidRequestAutoscroll(@requestAutoscroll.bind(this))
@observeDecoration(decoration) for decoration in @model.getDecorations()
@observeCursor(cursor) for cursor in @model.getCursors()
@disposables.add @model.onDidAddGutter(@didAddGutter.bind(this))
@ -1474,7 +1472,7 @@ class TextEditorPresenter
@startBlinkingCursorsAfterDelay()
@emitDidUpdateState()
didChangeScrollPosition: (position) ->
requestAutoscroll: (position) ->
@pendingScrollLogicalPosition = position
@pendingScrollTop = null
@pendingScrollLeft = null

View File

@ -436,8 +436,8 @@ class TextEditor extends Model
atom.views.getView(this).onDidChangeScrollLeft(callback)
onDidChangeScrollPosition: (callback) ->
@displayBuffer.onDidChangeScrollPosition(callback)
onDidRequestAutoscroll: (callback) ->
@displayBuffer.onDidRequestAutoscroll(callback)
# TODO Remove once the tabs package no longer uses .on subscriptions
onDidChangeIcon: (callback) ->