From d6f43f185827c311b56c872a19dc5821759402b6 Mon Sep 17 00:00:00 2001 From: Matthieu Baerts Date: Sun, 12 Oct 2014 18:15:00 +0200 Subject: [PATCH] :penguin: .desktop file without capital letter The .desktop file of Atom was named Atom.desktop but it should be renamed to atom.desktop because a .desktop should not contain capital letters as any other .desktop files in /usr/share/applications. Note that without that, it can be not easy to link the window with the .desktop file and then a dock/panel could not link a launcher with its window. --- build/tasks/install-task.coffee | 6 +++--- build/tasks/mkdeb-task.coffee | 2 +- resources/linux/{Atom.desktop.in => atom.desktop.in} | 0 3 files changed, 4 insertions(+), 4 deletions(-) rename resources/linux/{Atom.desktop.in => atom.desktop.in} (100%) diff --git a/build/tasks/install-task.coffee b/build/tasks/install-task.coffee index 650ac2372..ef85204cd 100644 --- a/build/tasks/install-task.coffee +++ b/build/tasks/install-task.coffee @@ -40,11 +40,11 @@ module.exports = (grunt) -> mkdir path.dirname(shareDir) cp shellAppDir, shareDir - # Create Atom.desktop if installation not in temporary folder + # Create atom.desktop if installation not in temporary folder tmpDir = if process.env.TMPDIR? then process.env.TMPDIR else '/tmp' if installDir.indexOf(tmpDir) isnt 0 - desktopFile = path.join('resources', 'linux', 'Atom.desktop.in') - desktopInstallFile = path.join(installDir, 'share', 'applications', 'Atom.desktop') + desktopFile = path.join('resources', 'linux', 'atom.desktop.in') + desktopInstallFile = path.join(installDir, 'share', 'applications', 'atom.desktop') {description} = grunt.file.readJSON('package.json') iconName = path.join(shareDir, 'resources', 'app', 'resources', 'atom.png') diff --git a/build/tasks/mkdeb-task.coffee b/build/tasks/mkdeb-task.coffee index bf563582d..cfe04f429 100644 --- a/build/tasks/mkdeb-task.coffee +++ b/build/tasks/mkdeb-task.coffee @@ -39,7 +39,7 @@ module.exports = (grunt) -> getInstalledSize buildDir, (error, installedSize) -> data = {name, version, description, section, arch, maintainer, installDir, iconName, installedSize} controlFilePath = fillTemplate(path.join('resources', 'linux', 'debian', 'control'), data) - desktopFilePath = fillTemplate(path.join('resources', 'linux', 'Atom.desktop'), data) + desktopFilePath = fillTemplate(path.join('resources', 'linux', 'atom.desktop'), data) icon = path.join('resources', 'atom.png') cmd = path.join('script', 'mkdeb') diff --git a/resources/linux/Atom.desktop.in b/resources/linux/atom.desktop.in similarity index 100% rename from resources/linux/Atom.desktop.in rename to resources/linux/atom.desktop.in