Hack in a workaround to cycle windows with meta-`

There's something wrong with CEF 3 right now where meta-` events aren't being forwarded to cocoa correctly. I just added some code to intercept meta-` and manually cycle the windows. I ignore any windows for which `excludeFromWindowsMenu` is true. That means we don't ever cycle to the hidden menu.

native/atom_cef_client.cpp

@@ -107,6 +107,8 @@ bool AtomCefClient::OnKeyEvent(CefRefPtr<CefBrowser> browser,
   }
   else if (event.modifiers == (KEY_META | KEY_ALT) && event.unmodified_character == 'i') {
     ToggleDevTools(browser);
+  } else if (event.modifiers == KEY_META && event.unmodified_character == '`') {
+    FocusNextWindow();
   }
   else {
     return false;

native/atom_cef_client.h

@@ -98,6 +98,7 @@ class AtomCefClient : public CefClient,
  protected:
   CefRefPtr<CefBrowser> m_Browser;
 
+  void FocusNextWindow();
   void Open(std::string path);
   void Open();
   void NewWindow();

native/atom_cef_client_mac.mm

@@ -5,6 +5,25 @@
 #import "atom_application.h"
 #import "atom_window_controller.h"
 
+
+void AtomCefClient::FocusNextWindow() {
+  NSArray *windows = [NSApp windows];
+  int count = [windows count];
+  int start = [windows indexOfObject:[NSApp mainWindow]];
+  int i = start;
+  while (true) {
+    i = (i + 1) % count;
+
+    if (i == start) break;
+
+    NSWindow *window = [windows objectAtIndex:i];
+    if (![window isExcludedFromWindowsMenu]) {
+      [window makeKeyAndOrderFront:nil];
+      break;
+    }
+  }
+}
+
 void AtomCefClient::Open(std::string path) {
   NSString *pathString = [NSString stringWithCString:path.c_str() encoding:NSUTF8StringEncoding];
   [(AtomApplication *)[AtomApplication sharedApplication] open:pathString];

native/atom_window_controller.mm

@@ -44,6 +44,7 @@
 - (id)initInBackground {
   [self initWithBootstrapScript:@"window-bootstrap" background:YES];
   [self.window setFrame:NSMakeRect(0, 0, 0, 0) display:NO];
+  [self.window setExcludedFromWindowsMenu:YES];
   return self;
 }