Merge pull request #15003 from atom/dg-create-windows-installer-after-tests

Create Windows installer after tests

appveyor.yml

@@ -31,19 +31,20 @@ install:
   - npm install -g npm@5.3.0
 
 build_script:
-  - IF NOT EXIST C:\sqtemp MKDIR C:\sqtemp
-  - SET SQUIRREL_TEMP=C:\sqtemp
   - CD %APPVEYOR_BUILD_FOLDER%
-  - IF [%APPVEYOR_REPO_BRANCH:~-9%]==[-releases] (
-      script\build.cmd --code-sign --create-windows-installer --compress-artifacts
-    ) ELSE (
-      script\build.cmd --code-sign --compress-artifacts
-    )
+  - script\build.cmd --code-sign --compress-artifacts
 
 test_script:
   - script\lint.cmd
   - script\test.cmd
 
+after_test:
+  - IF [%APPVEYOR_REPO_BRANCH:~-9%]==[-releases] (
+      IF NOT EXIST C:\sqtemp MKDIR C:\sqtemp
+      SET SQUIRREL_TEMP=C:\sqtemp
+      script\build.cmd --existing-binaries --code-sign --create-windows-installer
+    )
+
 deploy: off
 artifacts:
   - path: out\AtomSetup.exe

script/build

@@ -14,6 +14,7 @@ const yargs = require('yargs')
 const argv = yargs
   .usage('Usage: $0 [options]')
   .help('help')
+  .describe('existing-binaries', 'Use existing Atom binaries (skip clean/transpile/cache)')
   .describe('code-sign', 'Code-sign executables (macOS and Windows only)')
   .describe('create-windows-installer', 'Create installer (Windows only)')
   .describe('create-debian-package', 'Create .deb package (Linux only)')
@@ -52,19 +53,25 @@ process.on('unhandledRejection', function (e) {
   process.exit(1)
 })
 
-checkChromedriverVersion()
-cleanOutputDirectory()
-copyAssets()
-transpilePackagesWithCustomTranspilerPaths()
-transpileBabelPaths()
-transpileCoffeeScriptPaths()
-transpileCsonPaths()
-transpilePegJsPaths()
-generateModuleCache()
-prebuildLessCache()
-generateMetadata()
-generateAPIDocs()
-dumpSymbols()
+let binariesPromise = Promise.resolve()
+
+if (!argv.existingBinaries) {
+  checkChromedriverVersion()
+  cleanOutputDirectory()
+  copyAssets()
+  transpilePackagesWithCustomTranspilerPaths()
+  transpileBabelPaths()
+  transpileCoffeeScriptPaths()
+  transpileCsonPaths()
+  transpilePegJsPaths()
+  generateModuleCache()
+  prebuildLessCache()
+  generateMetadata()
+  generateAPIDocs()
+  binariesPromise = dumpSymbols()
+}
+
+binariesPromise
   .then(packageApplication)
   .then(packagedAppPath => generateStartupSnapshot(packagedAppPath).then(() => packagedAppPath))
   .then(packagedAppPath => {