Merge pull request #10838 from atom/output-for-core-specs

Log output for core specs

build/tasks/spec-task.coffee

@@ -86,7 +86,7 @@ module.exports = (grunt) ->
     packageSpecQueue.concurrency = Math.max(1, concurrency - 1)
     packageSpecQueue.drain = -> callback(null, failedPackages)
 
-  runCoreSpecs = (callback) ->
+  runCoreSpecs = (callback, logOutput = false) ->
     appPath = getAppPath()
     resourcePath = process.cwd()
     coreSpecsPath = path.resolve('spec')
@@ -109,6 +109,9 @@ module.exports = (grunt) ->
             ATOM_INTEGRATION_TESTS_ENABLED: true
           )
 
+    if logOutput
+      options.opts.stdio = 'inherit'
+
     grunt.log.ok "Launching core specs."
     spawn options, (error, results, code) ->
       if process.platform is 'win32'
@@ -130,11 +133,17 @@ module.exports = (grunt) ->
       else
         async.parallel
 
+    # If we're just running the core specs then we won't have any output to
+    # indicate the tests actually *are* running. This upsets Travis:
+    # https://github.com/atom/atom/issues/10837. So pass the test output
+    # through.
+    runCoreSpecsWithLogging = (callback) -> runCoreSpecs(callback, true)
+
     specs =
       if process.env.ATOM_SPECS_TASK is 'packages'
         [runPackageSpecs]
       else if process.env.ATOM_SPECS_TASK is 'core'
-        [runCoreSpecs]
+        [runCoreSpecsWithLogging]
       else
         [runCoreSpecs, runPackageSpecs]
 

build/tasks/task-helpers.coffee

@@ -52,8 +52,10 @@ module.exports = (grunt) ->
     stderr = []
     error = null
     proc = childProcess.spawn(options.cmd, options.args, options.opts)
-    proc.stdout.on 'data', (data) -> stdout.push(data.toString())
-    proc.stderr.on 'data', (data) -> stderr.push(data.toString())
+    if proc.stdout?
+      proc.stdout.on 'data', (data) -> stdout.push(data.toString())
+    if proc.stderr?
+      proc.stderr.on 'data', (data) -> stderr.push(data.toString())
     proc.on 'error', (processError) -> error ?= processError
     proc.on 'close', (exitCode, signal) ->
       error ?= new Error(signal) if exitCode isnt 0