From f720b14f229843f7dc56c33391066535015d105b Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Tue, 23 Oct 2012 16:09:29 -0700 Subject: [PATCH] Don't show when empty --- spec/extensions/outline-view-spec.coffee | 6 ++++++ src/extensions/outline-view/outline-view.coffee | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/spec/extensions/outline-view-spec.coffee b/spec/extensions/outline-view-spec.coffee index c68258780..22061b7cd 100644 --- a/spec/extensions/outline-view-spec.coffee +++ b/spec/extensions/outline-view-spec.coffee @@ -27,3 +27,9 @@ describe "OutlineView", -> expect(rootView.find('.outline-view')).not.toExist() rootView.trigger 'outline-view:toggle' expect(rootView.find('.outline-view')).not.toExist() + + it "doesn't display when no functions exist", -> + rootView.open(require.resolve('fixtures/sample-with-tabs.coffee')) + expect(rootView.find('.outline-view')).not.toExist() + rootView.trigger 'outline-view:toggle' + expect(rootView.find('.outline-view')).not.toExist() diff --git a/src/extensions/outline-view/outline-view.coffee b/src/extensions/outline-view/outline-view.coffee index a20e135a8..d241f5b39 100644 --- a/src/extensions/outline-view/outline-view.coffee +++ b/src/extensions/outline-view/outline-view.coffee @@ -52,7 +52,7 @@ class OutlineView extends SelectList column: matches[1].length name: matches[2] @setArray(functions) - true + return functions.length > 0 confirmed : ({row, column, name}) -> @cancel()