Commit Graph

44 Commits

Author SHA1 Message Date
Jason Rudolph
110bd6a16e
Add test for Workspace::getVisiblePanes() 2017-06-05 17:29:46 -04:00
Jason Rudolph
3020a61e34
Test activating next/previous pane at the workspace level 2017-05-19 10:49:51 -04:00
Nathan Sobo
048a548462 Fix specs 2017-05-10 14:18:15 -06:00
Max Brunsfeld
52195e79ff Merge branch 'master' into fb-mdt-no-cmd-w-on-permanent-dock-items 2017-04-17 13:39:16 -07:00
Max Brunsfeld
0015e026a2 Add Workspace.paneContainerForItem method 2017-04-17 11:34:45 -07:00
Matthew Dapena-Tretter
a9d0618e88 Don't close permanent dock items 2017-04-15 13:09:08 -07:00
Max Brunsfeld
82a7a6c78a Always search a pane container w/ the given URI in workspace.open 2017-04-12 10:23:49 -07:00
Nathan Sobo
2e066120bd Fix workspace specs 2017-04-08 13:29:50 -06:00
Max Brunsfeld
48336fb95e Don't use workspace's itemLocationStore in tests 2017-04-07 15:30:44 -07:00
Max Brunsfeld
63d27c5f0a Rename Dock.isOpen to .isVisible and Dock.open to .show 2017-04-06 17:23:53 -07:00
Max Brunsfeld
233c29d998 Fix usages of Workspace.paneContainer 2017-04-06 16:37:37 -07:00
Matthew Dapena-Tretter
d133b03d7d Remove saveFocusedPaneItem(As) methods
Now that dock pane items will be capable of being the workspace's
active item, there's no need to have these methods.
2017-04-06 17:26:35 -06:00
Nathan Sobo
9c28cc0fa8 Construct WorkspaceCenter's PaneContainer instance in the constructor 2017-04-06 16:57:41 -06:00
Nathan Sobo
1711d10af2 Aggregate onDidStopChangingActivePaneItem events across all containers 2017-04-06 16:35:25 -06:00
Nathan Sobo
646047f563 Maintain an active pane container on the workspace
This will be used by many commands that previously only interacted with
the center of the workspace.
2017-04-06 15:30:01 -06:00
Nathan Sobo
ec576b12bc Remove PaneContainer.monitorActivePaneItem
Call didChangeActiveItemOnPane directly from panes and when the active
pane changes instead.
2017-04-06 13:18:18 -06:00
Nathan Sobo
5cb550b09d Remove Pane's subclassing of Model 2017-04-06 12:06:46 -06:00
Max Brunsfeld
e40ef03008 Fix Workspace.open test for activating existing items in docks 2017-04-05 16:03:33 -07:00
Max Brunsfeld
6f0b1947ee Use Workspace.getElement in tests 2017-04-05 15:32:00 -07:00
Max Brunsfeld
6d55371930 Add Workspace.getElement method, remove WorkspaceElement view provider 2017-04-05 15:32:00 -07:00
Nathan Sobo
6ac29939e5 Merge pull request #14125 from atom/mb-ns-open-with-item
Allow workspace item objects to be passed to Workspace.open
2017-04-05 12:59:03 -06:00
Matthew Dapena-Tretter
fed2372c30 Don't store default locations
This will probably be less confusing for developers experimenting with
changing the default location. Also, we avoid storing extra info we
don't really need.
2017-04-04 14:49:34 -07:00
Max Brunsfeld
32ff2f37d9 Merge pull request #14108 from atom/fb-mdt-remember-moved-item-positions
🐛 Fix observation of moved items
2017-04-04 10:20:24 -07:00
Nathan Sobo
56cefbbc63 Support passing items to Workspace.toggle and .hide
Also, ensure that passing an item that is not yet present in the
workspace does not interfere with resolving the location where we want
to place the item.
2017-04-04 11:18:12 -06:00
Max Brunsfeld
1552854f3b Allow workspace item objects to be passed to Workspace.open 2017-04-04 11:18:12 -06:00
Matthew Dapena-Tretter
4ed53578ce 🐛 Fix observation of moved items
`PaneContainer::onDidAddPaneItem` isn't triggered on moves.
2017-03-31 16:48:49 -07:00
Matthew Dapena-Tretter
9663101671 Always add opened items to the workspace
This commit changes the behavior of `open()` so that the item will be
added to the workspace—even if the `activateItem` option is false.

This provides a way to open (and add) an item without activating it,
but removes the ability to open without adding. For that, we've made
the `createItemForURI()` method public 😊
2017-03-31 14:17:09 -07:00
Nathan Sobo
5557219fbc Merge pull request #14027 from atom/fb-mdt-save-focused-pane-item
Add `saveFocusedPaneItem()` and call it in "core:save" command
2017-03-31 13:57:50 -06:00
Matthew Dapena-Tretter
dec52a7384 Add atom.workspace.hide()
This adds an method for hiding items by URI and re-implements
`toggle()` in terms of it. (tbh it's really just extracting most of
`toggle()` into a new function.)
2017-03-30 17:37:55 -07:00
Matthew Dapena-Tretter
0d12396bf3 Add saveFocusedPaneItem() and call it in "core:save" command
Also, do the same for "core:save-as" and `saveFocusedPaneItemAs()`.
This behavior change means that pane items in docks (#13977) will be
savable too.
2017-03-28 14:05:29 -07:00
Max Brunsfeld
4082b67fb0 Refactor Workspace.open
Signed-off-by: Nathan Sobo <nathan@github.com>
2017-03-24 15:35:52 -07:00
Matthew Dapena-Tretter
52606171bf Add "location" param to open() 2017-03-23 18:50:40 -07:00
Matthew Dapena-Tretter
d9e1fcc70b Merge branch 'master' into HEAD
* master: (43 commits)
  If one arch fails, kill the other for perf on appveyor
  ⬆️ dalek@0.2.1
  Revert "⬆️ all packages that use atom-select-list"
  ⬆️ atom-keymap
  ⬆️ status-bar
  ⬆️ all packages that use atom-select-list
  ⬆️ language-ruby@0.71.0
  ⬆️ autocomplete-css@0.16.1
  Ensure `packagesCache` exists before accessing it
  🎨
  ⬆️ less-cache
  Use `core/` instead of `<embedded>` for keymaps loaded during snapshot
  Set also defaultSettings.core.projectHome when initializing Config
  Fix tests
  ⬆️ atom-keymap
  Replace CommandRegistry.addBundled with a boolean param in .add
  Delete unused build scripts
  🔥 Remove parserlib
  Resolve style sheets paths during `script/build` for bundled packages
  Don't use cached less sources and imported files in dev mode
  ...
2017-03-23 18:47:46 -07:00
Matthew Dapena-Tretter
3fcec8b8cd previousLocations -> itemLocationStore 2017-03-23 10:39:02 -07:00
Matthew Dapena-Tretter
6f9893d77d Rename "getActivePane" in tests to clarify intent 2017-03-20 19:50:35 -07:00
Matthew Dapena-Tretter
417e9c6979 Add tests for open() and docks 2017-03-18 15:32:01 -07:00
Matthew Dapena-Tretter
47cdc74b6a Only count panes in center in workspace test 2017-03-18 15:32:01 -07:00
Antonio Scandurra
81af989f0d Merge branch 'master' into as-snapshot-atom-environment 2017-03-16 21:08:41 +01:00
Antonio Scandurra
b1704ee7e6 Fix Workspace specs 2017-03-11 19:20:16 +01:00
Dirk Thomas
348553049a update specs 2017-03-10 10:41:20 -08:00
Antonio Scandurra
5f9b62c603 💚 2017-03-10 09:31:59 +01:00
Matthew Dapena-Tretter
53ec839ae5 Convert workspace to JavaScript: cleanup 2017-03-02 18:11:22 -08:00
Matthew Dapena-Tretter
7a0d7f8b4c Convert workspace to JavaScript: lint 2017-03-02 18:01:40 -08:00
Matthew Dapena-Tretter
cb71ce64ae Convert workspace to JavaScript: decaffeinate 2017-03-02 18:01:40 -08:00