Max Brunsfeld
9bdf4b01d0
Merge pull request #15643 from atom/mb-async-onWillDestroyPaneItem
...
Wait for async PaneContainer.onWillDestroyPaneItem listeners
2017-09-19 11:21:54 -07:00
Max Brunsfeld
666adb2f0e
Convert pane-container-spec to JS
2017-09-18 17:02:48 -07:00
Jason Rudolph
0054e3f796
💀 ☕ Decaffeinate spec/notification-manager-spec.coffee
2017-09-16 21:03:04 -04:00
Jason Rudolph
45c3770293
💀 ☕ Decaffeinate spec/notification-spec.coffee
2017-09-16 21:03:01 -04:00
Max Brunsfeld
19e56b5b3b
Wait for async onWillDestroyPaneItem listeners
2017-09-13 13:31:33 -07:00
Max Brunsfeld
2374077a6e
Wait for async onWillDestroyItem handlers before destroying item
2017-09-12 15:04:37 -07:00
Ash Wilson
8632e73d07
Merge pull request #15440 from atom/ku-reload-config-when-created
...
Replace pathwatcher w/ bundled watcher to catch created & rename events
2017-09-12 15:23:19 -04:00
Ash Wilson
fb4d7ee5e5
Clean the pending operations too
2017-09-12 14:39:17 -04:00
Ash Wilson
7737aec3ae
🔥 fdescribe
2017-09-12 11:25:29 -04:00
Ash Wilson
e275a5ff76
Ensure that .get calls before .requestLoad return .set properties
2017-09-12 11:21:20 -04:00
Ash Wilson
18a0a5a857
.set operations should be immediately visible through .get
2017-09-12 10:33:46 -04:00
Ash Wilson
e9588c8fae
Bring the new spec up to date
2017-09-12 10:18:09 -04:00
Ash Wilson
adb032adf1
Some cosmetic coffeescript changes
2017-09-12 10:16:50 -04:00
Ash Wilson
bf121eab72
Remove some diagnostics
2017-09-12 10:16:25 -04:00
Ash Wilson
fa0bd1e049
Use a real clock and artificial file mtimes to work with nsfw
2017-09-12 10:15:55 -04:00
Ash Wilson
21e220cd5f
Stub the correct fs method
2017-09-12 10:13:05 -04:00
Ash Wilson
046ff87f01
Trick the specs into seeing the settings as loaded
2017-09-12 10:12:38 -04:00
wpowell-oss
0b55d4e144
maxScreenLineLength rebased to github
2017-09-12 14:38:29 +12:00
wpowell-oss
f2bb941a51
Rebase to github/master
2017-09-12 13:58:26 +12:00
Warren Powell
a73f68c0dd
Spec test for setMaxScreenLineLength
2017-09-12 13:58:26 +12:00
Wliu
1a4e6c4c85
Merge pull request #15603 from jsoref/spelling
...
Spelling
2017-09-10 18:29:38 +02:00
Josh Soref
feb27a6676
spelling: visible
2017-09-10 15:46:41 +00:00
Josh Soref
dee7be7dd6
spelling: syntactic
2017-09-10 15:46:41 +00:00
Josh Soref
3bf9be2a47
spelling: separated
2017-09-10 15:46:41 +00:00
Josh Soref
9ca5662bcb
spelling: recycle
2017-09-10 15:46:40 +00:00
Josh Soref
1b93fcf35f
spelling: recover
2017-09-10 15:46:40 +00:00
Josh Soref
00130a7589
spelling: programmatically
2017-09-10 15:46:40 +00:00
Josh Soref
161a7f1788
spelling: perseveres
2017-09-10 15:46:40 +00:00
Josh Soref
27e021e22b
spelling: precedes
2017-09-10 15:46:40 +00:00
Josh Soref
6fc5ff8513
spelling: previous
2017-09-10 15:46:40 +00:00
Josh Soref
d425272725
spelling: indentation
2017-09-10 15:46:39 +00:00
Josh Soref
ee87ac1604
spelling: falsy
2017-09-10 15:46:39 +00:00
Josh Soref
6ce5f48203
spelling: doesn't
2017-09-10 15:46:39 +00:00
Josh Soref
fa249d5764
spelling: cursor
2017-09-10 15:46:39 +00:00
Josh Soref
2dc531b23c
spelling: contiguous
2017-09-10 15:46:39 +00:00
Josh Soref
1b7f3cad92
spelling: beginning
2017-09-10 15:46:38 +00:00
Josh Soref
5cbe7c8897
spelling: appearance
2017-09-10 15:46:38 +00:00
Damien Guard
199bab8993
Fix a few more tests
2017-09-08 19:00:27 -07:00
Damien Guard
79fbef8e24
👕
2017-09-08 19:00:26 -07:00
Damien Guard
468f4a47a9
Fix another two tests
2017-09-08 19:00:26 -07:00
Damien Guard
af66c5efaa
Fix two more tests
2017-09-08 19:00:26 -07:00
Damien Guard
0a2ff530ff
Get more tests working after async
2017-09-08 19:00:26 -07:00
Damien Guard
69e631d509
Allow Promises to be returned by a package deactivate method
2017-09-08 19:00:25 -07:00
Antonio Scandurra
c1981ffb44
Correctly remove block decorations whose markers have been destroyed
...
In https://github.com/atom/atom/pull/15503 we mistakenly assumed
`marker.isValid` accounted only for the validity of the marker. However,
that method returns `false` also for markers that are valid but have
been destroyed. As a result, the editor component was mistakenly not
removing block decorations associated with such markers.
With this commit we will rely on the local `wasValid` variable instead.
If its value is `true`, it means that the block decoration has been
accounted for in the `lineTopIndex` and must, as a result, be cleaned up
in case the marker or the decoration gets destroyed.
2017-09-07 17:52:04 +02:00
Antonio Scandurra
806b652da4
Flush scroll position to dummy scrollbar components on re-attach
...
This prevents the dummy scrollbars from resetting their position to `0`
when the editor element is moved elsewhere in the DOM (e.g. when
splitting a pane item).
2017-09-07 15:05:42 +02:00
Antonio Scandurra
7bd2c670e1
Merge pull request #15546 from atom/as-never-autoscroll-when-clicking-on-content
...
Don't autoscroll when using the mouse to add, delete or move selections
2017-09-06 02:12:15 -07:00
Antonio Scandurra
9bbd71219d
Merge pull request #15550 from atom/as-fix-rendering-out-of-range-decorations
...
Don't render block decorations located outside the visible range
2017-09-06 02:11:16 -07:00
Damien Guard
38d9c07284
Add test coverage for package-manager initialize paths
2017-09-05 09:12:26 -07:00
Antonio Scandurra
20ea98ad41
Don't render block decorations located outside the visible range
...
Previously, when trying to use block decorations on non-empty markers,
Atom could sometimes throw an error if such markers ended or started at
a position that was not currently rendered.
In fact, even if we already restricted the decoration query to markers
that intersected the visible row range, markers that were only partially
visible would still be considered for rendering. If, depending on the
`reversed` property, we decided to render the tail or head of the marker
in question and this was outside the viewport, Atom would throw the
aforementioned exception.
This commit addresses the above issue by explicitly ignoring block
decorations that are located on rows that are not yet rendered.
2017-09-05 18:05:35 +02:00
Antonio Scandurra
91bb1e12c7
Don't autoscroll when using the mouse to add, delete or move selections
2017-09-05 15:26:54 +02:00
