Commit Graph

77 Commits

Author SHA1 Message Date
Nathan Sobo
cd9e3b774a Always move the hidden input element to the cursor's screen location
This avoids spuriously auto-scrolling to the left when opening an autocomplete in an editor that's scrolled to the right.
2012-11-07 13:04:54 -07:00
Nathan Sobo
045cdda41d Fix cursor line highlight style 2012-11-02 12:16:03 -06:00
Nathan Sobo
4539977800 I'm worried overflow:hidden on lines is screwing rendering up
It's hard to reproduce, so I'm going to disable it and see if I see any more artifacts.
2012-11-02 12:12:02 -06:00
Nathan Sobo
c6075b0fa6 Optimize highlighting of the current line in the gutter 2012-11-01 17:37:50 -06:00
Nathan Sobo
42d0c53a60 Use min-width on rendered lines to replace js logic w/ CSS 2012-11-01 11:49:50 -06:00
Corey Johnson & Nathan Sobo
33b1b66ee4 Merge branch 'invisibles' 2012-10-18 14:44:48 -07:00
Corey Johnson
d3c52ae96d Make invisible coloring less obnoxious 2012-10-18 11:33:19 -07:00
Corey Johnson & Nathan Sobo
d6418b8b94 Set dummy vertical scrollbar width to be as wide as the scrollbar 2012-10-17 17:55:31 -07:00
Corey Johnson
905ab5e736 Only highlight line and gutter row if editor is active 2012-10-01 15:44:58 -07:00
Kevin Sawicki
a4ad5829a5 Disable gutter background highlight on multiline selections 2012-10-01 15:44:57 -07:00
Corey Johnson & Kevin Sawicki
6b835920bf Add padding to gutter numbers instead of entire gutter 2012-10-01 15:44:57 -07:00
Kevin Sawicki
be8120e8c6 Add initial support for line highlighting 2012-10-01 15:44:56 -07:00
Nathan Sobo
dc4d981e2a Fix selector that prohibits weird characters from making lines extra-tall
Now that selectors can nest, this needed to be more permissive
2012-09-28 16:43:41 -06:00
Kevin Sawicki
02fa815459 Highlight the line number of the current cursor row 2012-09-28 09:52:34 -07:00
Nathan Sobo
5f253d78e9 Optimization: Use absolute positioning instead of flexbox in editor
Flexbox was causing layouts and repaints to cover the entire scroll view instead of just the edited line. This cuts down on DOM manipulation cost significantly.
2012-09-25 14:58:31 -06:00
Nathan Sobo
d3df0a305b Use <pre> tag for lines instead of using white-space: pre css property
One less CSS rule, since the whitespace behavior of a `pre` tag is already baked into the browser's default styles.
2012-09-25 13:09:12 -06:00
Corey Johnson & Nathan Sobo
44db540528 All specs pass 2012-08-30 17:12:52 -06:00
Corey Johnson & Nathan Sobo
f84f9c5dd2 Add bundles and themes 2012-08-27 13:20:22 -07:00
Nathan Sobo
c2c8724ad0 Initial commit 2012-08-10 13:32:19 -06:00
Nathan Sobo
1996ba5558 Merge branch 'master' of github.com:github/atom 2012-08-27 11:02:39 -05:00
Corey Johnson
08ae611ff8 add fold selected state 2012-08-22 17:48:00 -07:00
Nathan Sobo
85b6cc3cf5 Make cursor a bit transparent when editor is not focused 2012-08-15 14:54:20 -07:00
Corey Johnson & Nathan Sobo
16b453e2e5 Remove z-index on .lines and .line-number
This was causing AutoComplete to be shown UNDER the lines
2012-08-09 17:22:44 -07:00
Corey Johnson
956cffe225 Add temp styling for folds 2012-08-09 15:18:37 -07:00
Nathan Sobo
34cac4336b Order selection regions behind editor's text
The key here is to force editor's overall z-index to be 0 in order to establish a *local stacking context*. Then we can put the lines at z-index 1 and the selection at z-index -1  within that context without them overlapping elements outside of the editor.
2012-08-08 22:35:57 -06:00
Nathan Sobo
3da19cd93b WIP: Style in a manner compatible w/ TextMate themes 2012-08-08 22:17:00 -06:00
Nathan Sobo
8c5e77d325 Move theme activation to RootView 2012-08-08 17:04:54 -06:00
Corey Johnson & Nathan Sobo
430fc0eff1 Put a bit more space between editor lines 2012-08-01 17:16:15 -06:00
Nathan Sobo
6de055aa1c Lines aren't taller when they contain an Inconsolata em dash (–) character 2012-08-01 17:04:33 -06:00
Nathan Sobo
454557b502 Merge branch 'master' into global-find
Conflicts:
	spec/extensions/command-panel-spec.coffee
	src/app/buffer.coffee
	src/extensions/command-panel/command-panel.coffee
	src/extensions/command-panel/keymap.coffee
2012-07-24 17:59:49 -06:00
Corey Johnson
e089b74867 Editor.renderedLines' css width is set to 100% when editor.maxScreenLineLength() is less than Editor.scrollView's width 2012-07-16 09:14:33 -07:00
Corey Johnson & Nathan Sobo
d44c648d4b Editor.renderedLines' width is set to the maximum of either Editor.scrollView's width or the maximum rendered line width 2012-07-13 09:05:38 -07:00
Nathan Sobo
3ee7c0dc0f "Scroll" gutter by relatively positioning its line numbers
This matches how we scroll lines, and eliminates opportunities for the gutter to get out of sync with the lines. If that happened, it would probably be a bug, but this at least eliminates one source of confusion when debugging.
2012-07-03 11:09:34 -06:00
Nathan Sobo
4aed73d947 Selections don't absorb click events
Clicking on a selection was causing the click event not to reach the editor, which was causing the editor to lose focus. Using CSS to disallow pointer events on selection region elements fixes this.
2012-06-29 13:34:01 -06:00
Corey Johnson
3c826ec898 Use 'pt' instead of 'px' for font sizes 2012-06-01 11:06:13 -07:00
Corey Johnson & Nathan Sobo
c11ee74405 Remove unused css 2012-05-24 14:08:32 -07:00
Nathan Sobo
96d92be230 Rename Editor.scrollbar to verticalScrollbar for clarity 2012-05-11 13:45:57 -06:00
Nathan Sobo
b64e9ae10f Rename Editor.scroller to Editor.scrollView to distinguish it from the vertical scrollbar.
Also, base edit session scroll top on the scrollbar instead of the scrollView.
2012-05-11 13:42:57 -06:00
Corey Johnson & Nathan Sobo
c93c63d721 Editor.scroller WheelEvents are forwarded to Editor.scrollbar 2012-05-11 11:04:04 -07:00
Corey Johnson & Nathan Sobo
9427c82084 WIP: Getting specs passing with new stand-in vertical scrollbar 2012-05-11 11:52:03 -06:00
Corey Johnson & Nathan Sobo
1a6ef9d7e2 Revert "Temporarily disable gutter. Add transition affect to margin-top."
This reverts commit 811e5264cf.
2012-05-10 18:00:58 -06:00
Corey Johnson & Nathan Sobo
811e5264cf Temporarily disable gutter. Add transition affect to margin-top. 2012-05-10 17:52:41 -06:00
Corey Johnson & Nathan Sobo
502b463a72 WIP: Adding an artificial scrollbar so we can render content before we scroll. It's blue. 2012-05-10 16:59:46 -06:00
Corey Johnson & Nathan Sobo
d3127a2686 slowed cursor blink down 2012-05-09 12:24:27 -07:00
Nathan Sobo
8b1ac28b89 Editor font sizes can be adjusted with RootView.proto.setFontSize 2012-05-09 08:34:08 -06:00
Nathan Sobo
f41ca1843b Make editor scroller overflow be auto, not scroll 2012-05-07 12:35:25 -06:00
Nathan Sobo
37438c6da8 Status bar path and cursor position updates 2012-05-04 13:58:11 -06:00
Corey Johnson & Nathan Sobo
038b491247 Add 'mini' option to editor, which styles it with auto-height, no gutter, and overflow hidden on scroller 2012-04-19 16:45:57 -06:00
Nathan Sobo
144fb29d83 Make lines have 100% height so the area below last line is clickable 2012-04-11 14:28:26 -06:00
Nathan Sobo
8a4f6510c9 Lighten selections because they're hard to see against darker bg 2012-04-04 11:09:45 -06:00