Kevin Sawicki
20b2be51d9
Add initial compile cache spec
2015-02-12 14:22:46 -08:00
Max Brunsfeld
aa59c38264
Merge pull request #5491 from bolinfest/repository-provider
...
Set up the atom.repository-provider service and implement GitRepositoryP...
2015-02-12 11:00:05 -08:00
Nathan Sobo
205d1df7b4
Precompute ::startRow and ::endRow in presenter
2015-02-12 11:34:45 -07:00
Michael Bolin
653bd32a3f
Introduce local promise variable to simplify assertion.
2015-02-12 09:52:48 -08:00
Michael Bolin
248e958628
Move most test logic into waitsForPromise in git-repository-provider-spec.coffee
2015-02-12 09:49:40 -08:00
Michael Bolin
603a672629
Moved the bulk of the test into waitsForPromise to eliminate some extra variables.
2015-02-12 09:47:11 -08:00
Michael Bolin
efd9e505eb
split up one of the tests in git-repository-provider-spec.coffee
2015-02-12 09:43:17 -08:00
Michael Bolin
673dae9f5b
Remove snake-case variable names in tests.
2015-02-12 09:38:29 -08:00
Michael Bolin
5cbfc2473d
Remove snake-case variable names in tests.
2015-02-12 09:33:25 -08:00
Michael Bolin
ca31c08e22
Remove reference to private atom.project.repositoryForDirectory property in unit test.
2015-02-12 09:31:44 -08:00
Michael Bolin
a3286f1f1d
Fix up assertion messages. Make some .then() calls one-liners.
2015-02-12 09:28:26 -08:00
Michael Bolin
7a89366146
excise outdated comment
2015-02-12 09:22:27 -08:00
Michael Bolin
ddd0ef5eb1
change describe() to it() so runs() is nested in an it()
2015-02-12 09:20:17 -08:00
Nathan Sobo
cc80378b29
Precompute ::scrollTop in presenter
2015-02-12 09:36:44 -07:00
Michael Bolin
bdae2f99a8
Add a unit test for GitRepositoryProvider.
2015-02-11 23:27:59 -08:00
Michael Bolin
485a4deb83
Fix an assertion that was failing but was being reported as part of the wrong test.
2015-02-11 23:01:19 -08:00
Michael Bolin
5b03cfe878
Added unit test for Project::repositoryForDirectory and fixed the bug
...
that my unit test caught.
2015-02-11 22:38:02 -08:00
Nathan Sobo
54fcaa6132
Precompute ::scrollHeight and cache ::scrollPastEnd config value
2015-02-11 23:01:08 -07:00
Nathan Sobo
05554d03e4
Precompute ::scrollWidth
2015-02-11 22:53:38 -07:00
Nathan Sobo
fc603aaa0d
Precompute ::clientHeight and ::clientWidth
2015-02-11 22:42:32 -07:00
Nathan Sobo
be691b6a54
Precompute contentHeight and height
2015-02-11 22:04:05 -07:00
Nathan Sobo
e4168d70b7
Use computed clientWidth instead of contentFrameWidth as max scrollWidth
2015-02-11 11:47:18 -07:00
Nathan Sobo
7f0110f49e
Update cursors as soon as all required measurements are assigned
2015-02-10 15:16:58 -07:00
Nathan Sobo
f5294454e6
Keep a minimum of 3 lines on screen when scrolling past end
2015-02-10 14:38:20 -07:00
Nathan Sobo
3e9b48ef71
Expand computed scrollHeight when editor.scrollPastEnd is enabled
2015-02-10 14:19:06 -07:00
Nathan Sobo
a4fd589616
Don’t render line numbers if scrolled past end
2015-02-10 10:11:20 -07:00
Nathan Sobo
711f0a227c
Honor the editor.scrollPastEnd option in TextEditorPresenter
2015-02-10 09:47:24 -07:00
Nathan Sobo
89d5dd339e
Merge pull request #5293 from atom/ns-editor-presenters
...
Move all text editor view state into a presenter object
2015-02-09 15:43:14 -07:00
Nathan Sobo
4f0e1997cf
💄 CharWidth -> CharacterWidth in presenter
2015-02-09 15:28:17 -07:00
Max Brunsfeld
3e28eff755
Remove logic for different promise types in waitsForPromise
...
I added that logic when using the selenium-webdriver library, but
then switched to using webdriverio, which has the same Promise
interface as Q.
2015-02-09 14:22:13 -08:00
Max Brunsfeld
ef9ae8e7d7
Merge pull request #5404 from atom/mb-integration-test
...
Add integration test to cover browser-side code
2015-02-09 13:11:53 -08:00
Nathan Sobo
0d1ba90561
Update presenter’s gutter background state when background color changes
2015-02-09 13:54:25 -07:00
Nathan Sobo
62c8244bf2
Merge branch 'master' into ns-editor-presenters
2015-02-09 13:37:27 -07:00
Max Brunsfeld
26b5c2712a
Put socket in new temp dir on every test run
2015-02-08 11:55:45 -08:00
Max Brunsfeld
6bfe3bf3b4
Specify ATOM_HOME when starting Atom in integration test
...
Otherwise, tests may fail because the Welcome pane may appear,
depending on the content of `~/.atom/config.cson`
2015-02-08 11:55:45 -08:00
Max Brunsfeld
56a4e6b7bf
Use webdriverio, not selenium-webdriver
2015-02-06 20:38:26 -08:00
Nathan Sobo
c8c13b8b40
Use cached .foldable values on TokenizedBuffer instead of recomputing
2015-02-06 18:54:34 -07:00
Nathan Sobo
f326c818fd
Update .foldable on tokenized lines based on indentation
2015-02-06 18:54:13 -07:00
Nathan Sobo
0081fa283e
Cache .foldable on tokenized lines based on block comments
...
Still need to handle indentation
2015-02-06 14:53:07 -07:00
Max Brunsfeld
6430bbb460
Wait for chromedriver's startup message on stdout
2015-02-05 22:40:17 -08:00
Kevin Sawicki
30419027a8
Show notification on config save failures
2015-02-05 15:34:17 -08:00
Kevin Sawicki
5de95759cd
Spy on editor.save
2015-02-05 15:24:00 -08:00
Kevin Sawicki
e51c8f3407
Add specs for save/saveAs error handling
2015-02-05 15:07:42 -08:00
Max Brunsfeld
56677e71e4
Enable integration tests with environment var
...
I think this makes more sense then running them via a separate command,
since that command would only make sense for atom-core, unlike the
current 'run-package-specs' command, which works for any atom package.
This way, they won't run by default, but you can opt in to running them
on the command line by setting an env var, or in the spec runner by
temporarily editing the code, like we do for focused tests anyway.
2015-02-05 13:02:08 -08:00
Kevin Sawicki
fd1d872840
Prompt split editors to save on close
...
Previously an editor that was split into multiple panes would not
prompt to save correctly when the window was unloading.
This adds a new `windowCloseRequested` option passed through from the
beforeunload handler to the editor so that it can specially handle this
case.
Closes #5257
2015-02-04 17:14:46 -08:00
Kevin Sawicki
6e3d41f433
Suppress deprecations in BufferedNodeProcess
...
This keeps it consistent with the render process which also suppresses
deprecations
Closes #5383
2015-02-04 15:27:17 -08:00
Max Brunsfeld
28f280183e
Use which(1), not bash's type function
2015-02-04 15:22:51 -08:00
Max Brunsfeld
f1df254a66
Use varargs in integration-test helper fn
2015-02-04 15:20:44 -08:00
Max Brunsfeld
af28083a6f
Add integration test coverage for reusing windows w/ the same dir
2015-02-04 15:07:08 -08:00
Nathan Sobo
77599c799c
Rename TextEditorPresenter::height to ::explicitHeight
...
This clarifies that the height is being assigned externally rather than
derived from the content.
2015-02-04 15:10:58 -07:00
