Commit Graph

9024 Commits

Author SHA1 Message Date
Antonio Scandurra
6a88fa4185 Don't symlink compile-cache folder in AtomWindow tests
In these tests, we create a temporary `ATOM_HOME` to avoid cluttering 
the user's real `~/.atom` folder.

Adding a symlink to the real `compile-cache` was introduced to speed up 
main process tests, so that the transpilation cache could be reused. 

Unfortunately, when the real `~/.atom` folder did not exist (such as on 
a pristine environment on CI), it would confuse Atom, which would think 
that it didn't need to re-create a `compile-cache` folder again, but 
wouldn't be able to write to it because the symlink pointed to a 
non-existant directory.

Main process tests were overhauled and made faster recently, so we can 
safely remove this performance optimization.
2019-06-06 17:11:01 +02:00
Rafael Oleza
dd40782166 add delay to watch-path tests to make them less flaky 2019-06-06 16:48:15 +02:00
Rafael Oleza
33f2bd37ee
Merge pull request #19444 from atom/improvements-to-ripgrep-scanner
Improvements to ripgrep scanner
2019-06-06 16:35:36 +02:00
Rafael Oleza
ac9be2d082 Remove test that checks that we can search of a subfolder of an ignored folder
This seems to not be working on Windows or with ripgrep, so it's not
expected behaviour.
2019-06-06 14:02:29 +02:00
Rafael Oleza
8c80d13dd1 Remove logic to prepend wildcard on globs
That logic was only needed to make `ripgrep` match correctly globs like
`src` when we pass it the folder to search on.

If we don't pass the folder, `ripgrep` assumes it's the cwd and their
glob matching logic improves by allowing globs like `src`.
2019-06-05 15:07:24 +02:00
Rafael Oleza
95adde37c0 Take into account the includeHidden option in ripgrep scanner 2019-06-05 10:21:06 +02:00
Rafael Oleza
8758c399db Take into account the follow option in ripgrep scanner 2019-06-04 12:21:50 +02:00
Rafael Oleza
3845862f5d Convert beforeEach() function to async 2019-06-04 12:21:50 +02:00
Rafael Oleza
7652d659e5 Take into account the excludeVcsIgnores option in ripgrep scanner 2019-06-04 12:21:50 +02:00
Nathan Sobo
2d3e332b88
Merge pull request #16100 from atom/wl-deserialize-and-activate
Activate package when deserializing
2019-06-03 13:44:58 -07:00
Antonio Scandurra
6b9b4f96f8
Merge pull request #19423 from atom/as/multi-stroke-accelerators
Display multi-keystroke key bindings in menu item's label
2019-06-03 10:57:26 +02:00
Winston Liu
6e90fbe064
Back to manual debugging it is 2019-06-02 22:00:06 -04:00
Rafael Oleza
e213a69a1f Re-apply prettier JS formatter 2019-06-01 00:29:10 +02:00
Rafael Oleza
79f6836349 Merge commit '1d9a4cafcf6cc288d675512db8fd984e13aab869' into dw-windows-separate-channels 2019-06-01 00:28:37 +02:00
Rafael Oleza
975f203dc7 Merge commit '677bbb7f0b8754787ff9e7bfab4602ba82e13b0b' into dw-windows-separate-channels 2019-06-01 00:27:52 +02:00
Rafael Oleza
ed6d06b16e Re-apply prettier JS formatter 2019-06-01 00:19:59 +02:00
Rafael Oleza
49cb6f4a7b Merge commit '1d9a4cafcf6cc288d675512db8fd984e13aab869' into wl-deserialize-and-activate 2019-06-01 00:19:27 +02:00
Rafael Oleza
040d96ca1b Merge commit '677bbb7f0b8754787ff9e7bfab4602ba82e13b0b' into wl-deserialize-and-activate 2019-06-01 00:18:46 +02:00
Rafael Oleza
66f7f1746a Reformat all JS files using prettier 2019-05-31 20:26:19 +02:00
Rafael Oleza
41840abdc2 Merge commit '1d9a4cafcf6cc288d675512db8fd984e13aab869' into pr18738 2019-05-31 20:25:41 +02:00
Rafael Oleza
0580aa11d1 Merge commit '677bbb7f0b8754787ff9e7bfab4602ba82e13b0b' into pr18738 2019-05-31 20:19:05 +02:00
Rafael Oleza
6263d85250 Re-apply prettier JS formatter 2019-05-31 18:55:45 +02:00
Rafael Oleza
948480665f Merge commit '1d9a4cafcf6cc288d675512db8fd984e13aab869' into wl-upgrade-webdriverio 2019-05-31 18:52:18 +02:00
Rafael Oleza
77dcd96a66 Merge commit '677bbb7f0b8754787ff9e7bfab4602ba82e13b0b' into wl-upgrade-webdriverio 2019-05-31 18:51:49 +02:00
Rafael Oleza
eb495f3ccf Merge commit '1d9a4cafcf6cc288d675512db8fd984e13aab869' into as/multi-stroke-accelerators 2019-05-31 18:45:39 +02:00
Rafael Oleza
ba7b9e39ec Merge commit '677bbb7f0b8754787ff9e7bfab4602ba82e13b0b' into as/multi-stroke-accelerators 2019-05-31 18:42:40 +02:00
Rafael Oleza
7f3f040628 Reformat all JS files using prettier 2019-05-31 18:33:56 +02:00
Rafael Oleza
677bbb7f0b
Merge pull request #19408 from atom/enable-no-useless-escape-eslint-rule
Enable eslint rules that got disabled
2019-05-31 18:29:31 +02:00
Antonio Scandurra
b04695ee69 Verify context menu item label's text for multi-keystroke key bindings 2019-05-31 16:26:18 +02:00
Antonio Scandurra
091325bd02 Merge branch 'master' into electron-3.1 2019-05-29 18:35:01 +02:00
Rafael Oleza
a14b3a5ddd Enable symbol-description eslint rule 2019-05-27 11:17:29 +02:00
Rafael Oleza
9abdb2f93a Enable no-unused-expressions eslint rule 2019-05-27 11:15:37 +02:00
Rafael Oleza
2139b4b936 Enable prefer-promise-reject-errors eslint rule 2019-05-27 11:11:49 +02:00
Rafael Oleza
dc2df49b60 Enable no-useless-escape eslint rule 2019-05-27 10:59:39 +02:00
Winston Liu
5265528675
🤦‍♀️ 2019-05-25 21:55:15 -04:00
Winston Liu
fe5082df51
Check for focus methods again 2019-05-25 20:53:47 -04:00
Winston Liu
7870675ef4
Re-enable tests 2019-05-25 20:50:53 -04:00
Winston Liu
e9ba8fdc05
Yay, it's green! Clean things up a bit. 2019-05-25 20:50:27 -04:00
Winston Liu
50e8c97db4
Delete the session when we're done, just to be safe 2019-05-25 16:50:45 -04:00
Winston Liu
45b772b111
Whoopsies 2019-05-25 16:50:37 -04:00
Winston Liu
7bbbca95bc
atom.workspace should always exist 2019-05-25 15:44:49 -04:00
Winston Liu
7e2a23b797
Ah heck, more async 2019-05-25 15:42:27 -04:00
Winston Liu
8fcd97ae15
...as I was saying, async. 2019-05-25 15:30:36 -04:00
Winston Liu
397c8d74e8
Pass in filePath as an argument 2019-05-25 14:24:10 -04:00
Winston Liu
e47253febf
I think we need to pass in a folder 2019-05-25 13:31:40 -04:00
Winston Liu
81fe767077
Everything's a Promise, apparently 2019-05-25 12:49:36 -04:00
Winston Liu
4961b31cf7
Perhaps it's something with await? 2019-05-25 00:18:16 -04:00
Winston Liu
8728e9f1e1
Thanks documentation for not giving any hint whatsoever that it's async 2019-05-24 21:00:55 -04:00
Winston Liu
8870380a29
Looks like there are windows being returned... 2019-05-24 20:26:33 -04:00
Winston Liu
bb74186003
Scoping 2019-05-24 18:08:48 -04:00
Winston Liu
a2af8ec9ca
Lint 2019-05-24 17:00:37 -04:00
Winston Liu
b9817ace02
Progress! 2019-05-24 16:42:21 -04:00
Winston Liu
1db4324d66
Not sure if addCommand returns anything... 2019-05-24 15:02:54 -04:00
Rafael Oleza
ab90d08292 Fix unrelated test 2019-05-24 20:30:57 +02:00
Winston Liu
cdfd37d4c5
??? 2019-05-24 13:45:17 -04:00
Rafael Oleza
17aa985f4e Fix handling of binary files when using ripgrep scanner 2019-05-24 18:55:18 +02:00
Winston Liu
05233b9857
Whole lot of debug code 2019-05-24 11:37:45 -04:00
Winston Liu
027b433953
Log it all 2019-05-24 10:16:01 -04:00
Winston Liu
2d4eb542e9
Focus it 2019-05-24 09:51:25 -04:00
Winston Liu
76e122274d
🙈 2019-05-24 09:50:53 -04:00
Winston Liu
bc0e0a0ffe
Lint 2019-05-23 23:15:42 -04:00
Winston Liu
21ed70687c
WIP: Upgrade webdriverio 2019-05-23 18:36:12 -04:00
Rafael Oleza
854471ffd8 Add missing fixture 2019-05-23 00:16:49 +02:00
Rafael Oleza
78c0a2881b Merge branch 'master' into ns-ro/ripgrep-scan 2019-05-22 23:37:19 +02:00
Rafael Oleza
6748b84060 Process unicode results from ripgrep correctly 2019-05-22 22:00:09 +02:00
Rafael Oleza
c3845dd902 Add proper multiline support to ripgrep scanner 2019-05-22 16:15:57 +02:00
Antonio Scandurra
8e2e2620d3 Revert "Revert "Merge pull request #18916 from atom/electron-3.1""
This reverts commit 3da827b8b0.
2019-05-21 17:26:00 +02:00
Rafael Oleza
73e2b6033a Fix ripgrep scan implementation to pass all the tests 2019-05-21 11:55:53 +02:00
Rafael Oleza
d9c27cc99a Update workspace-spec tests to be run against both ripgrep and standard implementation 2019-05-21 11:46:56 +02:00
Nathan Sobo
3da827b8b0 Revert "Merge pull request #18916 from atom/electron-3.1"
This reverts commit dc39210cc2, reversing
changes made to e18559f01c.
2019-05-20 16:32:09 -06:00
Rafael Oleza
9d1406cb05 Merge branch 'master' into ns-ro/ripgrep-scan 2019-05-20 15:45:13 +02:00
Antonio Scandurra
dc39210cc2
Merge pull request #18916 from atom/electron-3.1
⬆️ Electron 3 (Take Two)
2019-05-20 15:20:12 +02:00
Antonio Scandurra
c8b96ea899 Use the new getActivatePromise method in TextEditorRegistry tests 2019-05-18 17:01:08 +02:00
Nathan Sobo
770b8fdcf8 Revert "Merge pull request #19244 from atom/ns/notify"
This reverts commit b2ecabd527, reversing
changes made to c3bf95194a.
2019-05-17 04:10:17 -06:00
Rafael Oleza
0647a0044f Add context support to ripgrep-directory-searcher 2019-05-17 11:40:46 +02:00
Nathan Sobo
fd82a58f1d WIP
Co-Authored-By: Rafael Oleza <rafeca@users.noreply.github.com>
2019-05-16 17:45:34 +02:00
Rafael Oleza
5c7deea8e1 Asyncify spec 2019-05-16 13:05:01 +02:00
Nathan Sobo
61c52e3185 Decaffeinate default-directory-searcher.coffee and its spec
Co-Authored-By: Rafael Oleza <rafeca@users.noreply.github.com>
2019-05-16 12:54:21 +02:00
Rafael Oleza
46997eae83 Merge branch 'master' into electron-3.1 2019-05-16 11:22:02 +02:00
Winston Liu
c8d3c7e4c0
Merge branch 'master' into wl-deserialize-and-activate 2019-05-15 16:21:15 -04:00
Nathan Sobo
4e5e2e5293
Merge pull request #19336 from atom/ns/allow-quote-selectors
Allow escaped quote literals in the SyntaxScopeMap
2019-05-15 08:47:03 -06:00
Rafael Oleza
e01fe4ca90 Replace new Buffer() with Buffer.from()
This removes deprecation warnings on Node >=10

Co-Authored-By: Antonio Scandurra <as-cii@github.com>
2019-05-15 12:43:49 +02:00
Nathan Sobo
765d5122c3 Allow escaped " literals in the SyntaxScopeMap
In order to pass a quote literal to the postcss-selector-parser, it 
needs to be escaped. However, this escaping is not removed by the parser 
in the yielded value token, so in this commit I replace any escaped 
quote literals with unescaped quotes after we trim the outer quotes off 
of the string.
2019-05-14 17:17:49 -06:00
Winston Liu
2b15c1ed48
Merge branch 'master' into electron-3.1 2019-05-14 11:28:03 -04:00
Rafael Oleza
2df2f87c83 Add import statement at the beginning of file 2019-05-13 17:48:11 +02:00
David Wilson
9921e18e5a Use correct fontWeight value in ThemeManager spec
In Chrome 66+ it seems that getComputedStyle().fontWeight returns the computed
numeric value of the style instead of the original descriptive name.  We now
look for value '700' which corresponds to the value of 'bold'.
2019-05-13 13:53:53 +02:00
Nathan Sobo
1d2878f92e Merge remote-tracking branch 'origin/master' into ns/notify 2019-05-10 15:38:36 -06:00
Nathan Sobo
be7d129675 Normalize to realpath in waitForEvents helper 2019-05-10 14:31:14 -06:00
Nathan Sobo
b1b1b15d49 Normalize %TEMP% to a long path on Windows CI
This avoids problems with assertions that involve paths inside the temp 
folder.
2019-05-10 13:46:57 -06:00
Jason Rudolph
ecbdb3de75
Merge pull request #19279 from atom/mb-newlines-between-injection-points
Improve handling of comment characters in ERB and EJS
2019-05-08 15:53:16 -04:00
Jason Rudolph
f18ad1eea1
Enhance spec to better demonstrate the functionality being tested
/xref https://github.com/atom/atom/pull/19279#discussion_r282137915
2019-05-08 13:07:12 -04:00
Jason Rudolph
e247815879
Rename test for additional clarity (hopefully) 2019-05-08 10:33:25 -04:00
Jason Rudolph
e00ea44310
Fix test 2019-05-08 10:29:23 -04:00
Nathan Sobo
db40641a84 Merge remote-tracking branch 'origin/master' into ns/notify 2019-05-07 16:38:34 -06:00
Jason Rudolph
c163564a9e
Explore potential test for ef94657438
This test doesn't pass yet. Stay tuned. 📺😇
2019-05-07 17:44:34 -04:00
Rafael Oleza
691c90e4b5 Fix atom.open() 2019-05-07 19:14:32 +02:00
Jason Rudolph
f1952c2fc1
Merge pull request #19272 from atom/improve-positioning-when-opening-file-at-line
Improve positioning when opening file at line
2019-05-07 10:53:52 -04:00
Jason Rudolph
4ac6107f95
🎨 Use await to make the world a better place
/xref https://github.com/atom/atom/pull/19272#discussion_r281562954
2019-05-07 09:20:00 -04:00
Rafael Oleza
1efa4f36ea Decaffeinate src/initialize-application-window.js 2019-05-07 12:47:10 +02:00
Rafael Oleza
833cdd0c29
Merge pull request #19274 from atom/prepare-for-electron-v3
Prepare Atom for the electron v3 upgrade
2019-05-07 10:30:46 +02:00
Max Brunsfeld
fa100866cb
Merge pull request #19172 from atom/mb-tree-sitter-upgrade-test-travis
Try upgrading Tree-sitter for a third time
2019-05-06 22:33:20 -07:00
Max Brunsfeld
59319d639a Update test to expect new rendering of missing tree-sitter nodes 2019-05-06 14:50:38 -07:00
David Wilson
78f354ad3a Update StyleManager specs to address deprecated ::shadow selectors
As of Chromium 63, ::shadow CSS selectors have been fully removed:

https://developers.google.com/web/updates/2017/10/remove-shadow-piercing

As a result, any usage of ::shadow in a stylesheet seems to get removed as soon
as the stylesheet is applied to an HTMLStyleElement.  Since we have a couple of tests
that expect ::shadow selectors to be present, we must remove those expectations
since those selectors do not appear any longer.
2019-05-06 20:27:27 +02:00
David Wilson
614d3e150a Use fs.renameSync in Workspace spec to fix test failure 2019-05-06 20:25:52 +02:00
David Wilson
3bd2279d3c Make invalid JS file fail Babel spec again
This change uses a different JavaScript syntax to cause the "when a .js file
does not start with 'use babel'" spec to fail again after upgrading to Electron
3 / Node 10.3.0.  The previous generator syntax seems to be supported in the
version of V8 used by Node 10 so we now need to use the 'export default' syntax
to trigger an error.

I've verified that changing the first line of this file to 'use babel' causes
the file to load successfully, so it seems this new syntax is effective to
verify the desired behavior.
2019-05-06 20:24:29 +02:00
Jason Rudolph
9921d1cef3
Unfold (if needed) when opening file at specific line 2019-05-06 11:24:26 -04:00
Rafael Oleza
0d80191516
Merge pull request #19257 from atom/increase-timeout-file-recovery-test
Increase the timeout for the FileRecoveryService tests
2019-05-06 11:39:16 +02:00
Winston Liu
d8559d37a2
Add 'it' in front of spec descriptions 2019-05-04 12:29:52 -04:00
Nathan Sobo
5bfbdd2bce Stop all watchers before attempting to replace directory with file
I think that the notify subprocess might be holding a lock on the 
watched directory on Windows.
2019-05-03 14:11:59 -06:00
Nathan Sobo
1ec8e7730b Work around 8.3 path issue on Azure Windows 2019-05-03 10:46:33 -06:00
Rafael Oleza
fb79283d15 Increase the timeout for the FileRecoveryService tests 2019-05-03 17:27:48 +02:00
Nathan Sobo
f8d7c9cbce Use async/await in test to see if it fixes Windows failures on CI 2019-05-02 13:35:04 -06:00
Nathan Sobo
508b56da28 Remove logic supporting dynamic switching of path watcher backends
The logic is pretty complex and I don't want to take the time to 
integrate @atom/notify with it. I left a bunch of stuff commented out in 
this commit just in case these changes break the build. I'll do another 
pass to delete commented code once we go green.
2019-05-02 07:40:38 -06:00
Nathan Sobo
89a7aa851b Default to @atom/notify for file system notifications
There's still some work to do to make this work on Linux and support 
switching between notification back-ends.
2019-05-02 07:40:37 -06:00
Jason Rudolph
2cf285bc36
Merge #19175 from UziTech/patch-7: await uriHandler 2019-05-01 16:23:34 -04:00
Ash Wilson
3ee3641525
Merge pull request #19247 from atom/aw/drag-and-drop
Always use target window for drag-and-drop
2019-05-01 12:44:43 -04:00
Ash Wilson
e2d5143b53
Use the "here" option to open for drag-and-drop 2019-05-01 09:05:46 -04:00
Ash Wilson
61377b843c
Support a "here" option in the "open" IPC message handler 2019-05-01 09:02:02 -04:00
Rafael Oleza
3fcdcde74d Use async randomBytes API to speedup Windows startup 2019-04-30 19:14:54 +02:00
Rafael Oleza
2a7ddf0d22
Merge pull request #19234 from atom/improve-flaky-test
Disable external events from workspaceElement test
2019-04-30 11:01:55 +02:00
Rafael Oleza
7e4dfa9417
Merge pull request #13760 from atom/wl-open-empty-editor-as-pending
Open empty editor as a pending pane item
2019-04-29 15:54:25 +02:00
Rafael Oleza
4e2e820a6c Disable external events from workspaceElement test 2019-04-29 15:09:23 +02:00
Ash Wilson
e368d78d27
Main process test for dev mode and benchmark windows 2019-04-28 17:21:37 -04:00
Winston Liu
dbb6c7b1b6
Merge branch 'master' into wl-open-empty-editor-as-pending 2019-04-27 00:25:00 -04:00
Rafael Oleza
165a297d31 Merge branch 'master' into autoFocus-element 2019-04-26 20:23:09 +02:00
Ash Wilson
c8beb6ffab
Open loaded window options *first* 2019-04-24 15:22:32 -04:00
Ash Wilson
a53addbf78
Update AtomWindow::projectRoots synchronously on openLocations() 2019-04-24 15:04:59 -04:00
Ash Wilson
f1e0843473
Don't report missing project folder errors twice 2019-04-24 11:34:36 -04:00
Ash Wilson
f4be123137
Test a new application.json schema and our handling of the old one 2019-04-24 10:17:20 -04:00
Ash Wilson
a0e9bb785f
Merge pull request #19203 from atom/aw/reopen-projects
"Reopen projects" in a new window
2019-04-23 17:35:13 -04:00
Ash Wilson
213f3b28b3
Rework and test IPC events that create windows 2019-04-23 11:18:53 -04:00
Tony Brix
7170ab8ebd lint 2019-04-23 09:24:30 -05:00
Ash Wilson
758fd9d75c
Merge pull request #19169 from atom/aw/launch-it
Improve launch behavior
2019-04-22 20:39:28 -04:00
Jason Rudolph
5055be06ca
Update spec/main-process/atom-application.test.js
Co-Authored-By: smashwilson <smashwilson@github.com>
2019-04-22 16:00:28 -04:00
Ash Wilson
ab490a064a
Test for restoring windows over directories and files 2019-04-19 18:07:18 -04:00
Ash Wilson
c719dc8aa2
Test empty command-line cases 2019-04-19 17:37:23 -04:00
Ash Wilson
96e6403573
Remove unused forceAddToWindow 2019-04-19 17:36:33 -04:00
Nathan Sobo
bca3e5bcfd
Merge pull request #18499 from Aerijo/content-regex
Support contentRegex for TextMate grammar
2019-04-19 14:58:58 -06:00
Ash Wilson
8126a136cd
Read hasOpenFiles to determine whether or not the initial editor should open 2019-04-19 15:50:24 -04:00
Ash Wilson
cc1ddf1011
Use hasOpenFiles to flag a window that will receive openLocations() 2019-04-19 15:50:03 -04:00
Ash Wilson
190875873e
📝 Document the LaunchScenario stuff 2019-04-19 15:07:33 -04:00
Ash Wilson
53188eb19d
Distinct test names 2019-04-19 14:33:00 -04:00
Nathan Sobo
5a6f93d1c3 Fix lint errors 2019-04-19 12:03:40 -06:00
Ash Wilson
1a123c06ef
Line separators are hard okay 2019-04-19 13:59:30 -04:00
Ash Wilson
97c4038906
Fix problems with _dimensions being modified in-place 2019-04-19 13:10:17 -04:00
Nathan Sobo
51d97a16d8 Add test for content regexes in first-mate grammars 2019-04-19 10:55:34 -06:00
Ash Wilson
e8cc4aa421
Call removeWindow() explicitly to simulate a window close 2019-04-19 12:55:03 -04:00
Ash Wilson
b9268c703c
URL pathnames use /, not path.sep 2019-04-19 12:53:30 -04:00
Ash Wilson
c4f3b519d3
Replace the AtomApplication test suite 2019-04-19 12:07:21 -04:00
Ash Wilson
3645cef518
More marking stuff covered 2019-04-19 12:06:09 -04:00