Kevin Sawicki
7d7b2375e1
Focus right after showing
2015-06-10 09:27:20 -07:00
Max Brunsfeld
b903302fd2
Merge pull request #7200 from atom/mb-guard-get-load-settings
...
Guard for atom windows w/ no webContents
2015-06-09 17:21:44 -07:00
Max Brunsfeld
cd42d8acbb
⬆️ text-buffer
2015-06-09 16:54:34 -07:00
Max Brunsfeld
6bccfcd0a3
Guard for atom windows w/ no webContents
2015-06-09 16:45:27 -07:00
Nathan Sobo
04c9567181
Massage message a bit
2015-06-10 01:30:12 +02:00
Max Brunsfeld
f2851ac11d
Merge pull request #7192 from atom/as-fix-empty-partially-off-screen-markers
...
Delete partially off-screen markers which are empty
2015-06-09 15:04:52 -07:00
Max Brunsfeld
7db0ab8d36
⬆️ text-buffer
2015-06-09 14:16:20 -07:00
Kevin Sawicki
bb53c07539
⬆️ tabs@0.78
2015-06-09 12:53:45 -07:00
Kevin Sawicki
091b25c8b3
Prepare 0.209
2015-06-09 12:49:50 -07:00
Antonio Scandurra
f73435e053
🐛 Delete partially off-screen markers which are empty
...
* 🔥 Delete old code which was used to support some non-batched
methods in a previous version;
* ✅ Cover “partially off-screen markers which are
empty” scenario, since that code path was not hit by previous specs
Fixes #7183
2015-06-09 21:35:01 +02:00
Max Brunsfeld
cecd23397e
Merge pull request #7190 from atom/revert-7022-bf-directory-searcher
...
Revert "Introduce atom.directory-searcher service v0.1.0."
2015-06-09 11:51:39 -07:00
Max Brunsfeld
262d41c306
Revert "Introduce atom.directory-searcher service v0.1.0."
2015-06-09 11:51:30 -07:00
Kevin Sawicki
a3f6a9e64c
⬆️ welcome@0.29
2015-06-09 11:38:27 -07:00
Kevin Sawicki
51f0a6bc9a
⬆️ tabs@0.77
2015-06-09 11:09:17 -07:00
Max Brunsfeld
f830623512
Merge pull request #7022 from atom/bf-directory-searcher
...
Introduce atom.directory-searcher service v0.1.0.
2015-06-09 09:40:06 -07:00
Kevin Sawicki
fb48b38aa7
Guard against no resizing with no siblings
...
Closes #7091
2015-06-09 09:36:58 -07:00
Kevin Sawicki
538e30eeec
Merge pull request #7175 from nn2242/fix/maximized-misspelling
...
Correct isMaximixed misspelling to isMaximized
2015-06-09 08:55:50 -07:00
Michael Bolin
535c0e2f34
Fix documentation bug.
2015-06-09 15:34:10 +01:00
Michael Bolin
1a6c542b45
Update comment.
2015-06-09 15:34:10 +01:00
Michael Bolin
6b1b57c89c
Rename a variable to reflect a change in the previous commit.
2015-06-09 15:34:10 +01:00
Michael Bolin
0630bce95c
Two things:
...
* Removed the `Directory` argument to `didSearchPaths`.
Now each searcher gets its own instance of `didSearchPaths` that is parameterized by provider.
* Simplified `DefaultDirectorySearcher.search()` so it creates one `DirectorySearch`
rather than one per `Directory` passed to `search()`.
2015-06-09 15:34:10 +01:00
Michael Bolin
18ac7d0cbc
Comment excised, as recommended by @maxbrunsfeld.
2015-06-09 15:34:09 +01:00
Michael Bolin
028ac79836
Changed the behavior so that if a searcher rejects,
...
then the thenable returned by `atom.workspace.scan()` rejects.
2015-06-09 15:34:09 +01:00
Michael Bolin
7dc3d07f8a
Changed the contract of DefaultDirectorySearcher in two significant ways:
...
* `search()` takes an array of `Directory` objects rather than an individual object.
* `options.didSearchPaths` now takes the `Directory` in addition to the `count` as an argument.
2015-06-09 15:34:09 +01:00
Michael Bolin
36123faf5d
Changed DefaultDirectorySearcher to take multiple directories.
...
Still need to update `workspace.coffee` to make better use of this.
2015-06-09 15:34:09 +01:00
Michael Bolin
318498464a
Responded to all of @maxbrunsfeld's comments except for:
...
* The effect of a failed search.
* Letting `DirectorySearcher::search` take multiple directories.
I'm working on those now.
2015-06-09 15:34:09 +01:00
Michael Bolin
5fc9d9e01a
Document and test the cancel() method on the object returned by atom.workspace.scan().
2015-06-09 15:34:09 +01:00
Michael Bolin
10d9111f68
Clean up test to verify that an individual failed search fails the overall search.
2015-06-09 15:34:09 +01:00
Michael Bolin
898f7b87e8
remove require for Disposable that is no longer needed
2015-06-09 15:34:09 +01:00
Michael Bolin
f7e822d41f
Make delegate method names more delegate-like.
2015-06-09 15:34:09 +01:00
Michael Bolin
4eb30f3925
Switch to the delegate pattern,
...
eliminating a nasty race condition and deleting a lot of code.
2015-06-09 15:34:09 +01:00
Michael Bolin
fa3fd9c50c
Remove empty param lists as per the linter.
2015-06-09 15:34:08 +01:00
Michael Bolin
735bdcca08
Two things:
...
1. Update documentation for `default-directory-search.coffee`.
2. Ensure that multiple `DirectorySearch` searches are run in series rather than in parallel to conserve resources.
2015-06-09 15:34:08 +01:00
Michael Bolin
fd670a4dd4
Remove myResolve local variable that I was using for debugging.
2015-06-09 15:34:08 +01:00
Michael Bolin
4330c3a181
Fix some nits I found during my self-review.
2015-06-09 15:34:08 +01:00
Michael Bolin
7294e0cda4
Change DirectorySearcher to return a DirectorySearch.
2015-06-09 15:34:08 +01:00
Michael Bolin
986640f670
Respond to comments from @maxbrunsfeld and @kevinsawicki.
2015-06-09 15:34:08 +01:00
Michael Bolin
7781e34ba2
Introduce atom.directory-searcher service v0.1.0.
...
The contract for a provider for the `atom.directory-searcher` service
is defined by the spec of the `DefaultDirectorySearcher`.
This modifies `Workspace::scan()` to use the appropriate `DirectorySearcher`
for each member of `atom.project.getDirectories()` when scanning the workspace
for files that match the specified regex.
2015-06-09 15:34:08 +01:00
Machisté N. Quintana
7fe359ab4c
Merge pull request #7179 from rmartin/7178-resize-pane-cursor
...
Fix inconsistency with pane resize cursors.
2015-06-09 07:20:14 -04:00
Antonio Scandurra
119f297280
Merge branch 'master' into as-tiled-gutter
...
Conflicts:
src/lines-component.coffee
src/text-editor-presenter.coffee
2015-06-09 11:22:25 +02:00
Roy Martin
384b88eecf
Fix inconsistency with pane resize cursors.
2015-06-09 01:06:45 -07:00
Machiste Quintana
f9c612d1c8
Use an empty object if metadata is ~null
2015-06-08 21:33:07 -04:00
Machiste Quintana
07da68c95e
Don't reassign metadata.name
2015-06-08 21:18:21 -04:00
Machiste Quintana
d78bc3f234
🎨
2015-06-08 21:14:11 -04:00
Machiste Quintana
659ddb67ad
Add Package.loadMetadata() specs
2015-06-08 20:57:35 -04:00
Machiste Quintana
0f876a73cc
Only use package directory name as fallback
...
Fixes https://github.com/atom/atom/issues/7174
2015-06-08 20:45:41 -04:00
Nikhil Narula
50f4fe5b6c
Correct isMaximixed misspelling to isMaximized
2015-06-08 20:43:13 -04:00
Jesse Grosjean
6cdc555a93
Clone options parameter before modifying it.
2015-06-08 20:40:15 -04:00
Kevin Sawicki
c06d62e607
⬆️ snippets@0.94
2015-06-08 17:26:59 -07:00
Kevin Sawicki
6a007a7061
⬆️ language-coffee-script@0.41
2015-06-08 16:52:51 -07:00
