Nathan Sobo
eed9af4c45
Merge branch 'master' of github.com:github/atom into edit-session-refactor
2012-06-07 18:25:10 -06:00
Nathan Sobo
5a37a39b9b
Tie creation of SelectionViews to adding Selection models to the EditSession
2012-06-07 18:20:00 -06:00
Nathan Sobo
7cdd4d684f
Rename Selection to SelectionView in preparation for adding a Selection model
2012-06-07 17:05:14 -06:00
Nathan Sobo
608c4f48bf
Remove more logic from cursor view
2012-06-07 16:58:45 -06:00
Nathan Sobo
f406786a3a
Editor subscribes to EditSession for screen line changes. Remove more movement logic from cursor view.
2012-06-07 16:31:40 -06:00
Kevin Sawicki
d2e79b13c2
💄
2012-06-07 14:47:58 -07:00
Nathan Sobo
58c8117e4e
💄
2012-06-07 15:42:21 -06:00
Nathan Sobo
624cf3cbd3
EditSession informs cursor models of buffer changes (instead of Editor informing cursor views)
2012-06-07 15:41:35 -06:00
Nathan Sobo
d5d5caf764
Merge branch 'master' of github.com:github/atom into edit-session-refactor
2012-06-07 15:33:16 -06:00
Nathan Sobo
d872d12e04
Transfer word movement methods into cursor model
2012-06-07 15:33:01 -06:00
Corey Johnson
01d819abc8
💄
2012-06-07 10:54:42 -07:00
Corey Johnson
5d67b63253
always copy static folder to app bundle
2012-06-07 10:51:37 -07:00
Nathan Sobo
d50c8f2d0e
Merge branch 'master' of github.com:github/atom into edit-session-refactor
2012-06-07 11:40:01 -06:00
Nathan Sobo
21ae28657c
Move moveTo(Beginning/FirstCharacter/End)OfLine methods to cursor model
...
Also, implement move to end of line by adding a clip option to setBufferPosition and passing [row, Infinity]
2012-06-07 11:28:40 -06:00
Corey Johnson
481ec16485
meta-w closes edit sessions until there are none left, then it closes the editor
2012-06-07 10:21:16 -07:00
Nathan Sobo
fccc88acaf
Move moveLeft/Right/ToTop/ToBottom methods into cursor model
2012-06-07 10:57:21 -06:00
Nathan Sobo
ddf29e89ec
Slave CursorView's screen position to its cursor model. Move moveUp and moveDown methods into cursor model.
2012-06-07 10:47:30 -06:00
Nathan Sobo
7387c553c3
Start introducing Cursor model in EditSession
...
The old cursor view still does most of the work, but to add a new cursor view we now must add a cursor model to the edit session at the correct position. The editor watches the 'add-cursor' event on edit session and add a corresponding CursorView to the CompositeCursor whenever a model is added. Next step: have the cursor view observe the cursor model and shadow its changes in position.
2012-06-06 21:52:19 -06:00
Nathan Sobo
e167afd794
Rename Cursor to CursorView in preparation for a Cursor model in EditSession
2012-06-06 18:01:08 -06:00
Nathan Sobo
c6fa2313ca
💄
2012-06-06 17:47:29 -06:00
Nathan Sobo
00b9c6db81
Active edit session 💄
2012-06-06 17:46:00 -06:00
Nathan Sobo
d07f3008c6
Merge branch 'edit-session-refactor'
2012-06-06 17:01:28 -06:00
Nathan Sobo
ff52993c9e
Fix bugs when switching between EditSessions
2012-06-06 17:00:02 -06:00
Corey Johnson
196aab1690
$native is now created once and registered as a CEF Extension.
2012-06-06 15:20:54 -07:00
Nathan Sobo
1344d42061
Add spec to ensure we unsubscribe from every buffer when we remove editor
2012-06-06 12:48:45 -06:00
Nathan Sobo
024618b69a
Build Renderer in EditSession and assign it when switching to that EditSession
2012-06-06 12:42:53 -06:00
Nathan Sobo
4885af4fa8
Merge branch 'master' of github.com:github/atom
2012-06-06 12:11:00 -06:00
Nathan Sobo
5a28656259
Introduce EditSession class, which replaces edit session hashes
2012-06-06 12:10:49 -06:00
Corey Johnson
3792d24c9f
Mini editor's don't toggle active-editor-path-change event
2012-06-05 13:43:03 -07:00
Corey Johnson
4b68fa3cae
Remove detach recursion from autocomplete cancel.
...
miniEditor.focusOut was causing cancel to be called multiple times.
2012-06-05 13:43:03 -07:00
Corey Johnson
33053b08b4
💄
2012-06-05 13:43:02 -07:00
Nathan Sobo
e6af7a9515
Adjust the width of rendered lines to account for the longest line
2012-06-05 14:26:06 -06:00
Nathan Sobo
e433d106b8
Remove unnecessary construction of new editor
2012-06-05 14:25:32 -06:00
Nathan Sobo
3a776347ff
Avoid leaking window resize subscriptions in editor spec
2012-06-05 14:25:08 -06:00
Nathan Sobo
e7ffaa1757
Merge branch 'master' of github.com:github/atom
2012-06-05 12:48:16 -06:00
Nathan Sobo
700c6d757a
Fix call to renamed method
2012-06-05 12:47:53 -06:00
Nathan Sobo
911a417cb8
Rename maxLineLength to softWrapColumn
2012-06-05 12:47:39 -06:00
Corey Johnson
4f364e8cd8
Add newline-below event
2012-06-05 11:30:29 -07:00
Corey Johnson
afab19938e
Use wasReversed instead of isReversed to show the local variable stores some temporal state.
2012-06-05 11:30:29 -07:00
Nathan Sobo
4dc41dcc21
💄
2012-06-05 11:09:40 -06:00
Nathan Sobo
e8705b7807
Merge branch 'master' of github.com:github/atom
2012-06-05 10:59:41 -06:00
Nathan Sobo
c24b8a90b2
If lines are removed after a renderer change, update padding appropriately
2012-06-05 10:59:11 -06:00
Corey Johnson
ce25b33c25
Inserting a newline before a top-level c-style statement (starting with a '{') no longer auto-indents it.
2012-06-05 09:09:20 -07:00
Nathan Sobo
9cfbce826d
WIP: Don't allow impossibly high scroll top values.
...
It fixes the move to bottom issues, but breaks some other tests. Not sure why yet...
2012-06-04 21:57:10 -06:00
Nathan Sobo
3c2facc7be
Add a disabled failing spec for text rendering when moving to the end of the file
2012-06-04 21:11:32 -06:00
Nathan Sobo
4eb4c95a86
Constrain the end of the old screen range to the lastRenderedScreenRow, not maxScreenRow
...
Constraining the end of the new range max screen row instead of the last rendered row is what allows the buffer to get longer when the last rendered screen row is smaller than the last visible screen row. But constraining the end of the old range to this was causing artifacts. The old range should always be constrained to what is rendered on screen now, not what "could be". What "could be" is the domain of the new range.
2012-06-04 20:48:29 -06:00
Nathan Sobo
de1086639d
Add failing spec for folding more than a screen of text to less than a screen
2012-06-04 20:45:28 -06:00
Nathan Sobo
8f9d066d99
Restore reverted rename. clearLines -> clearRenderedLines
2012-06-04 20:32:50 -06:00
Nathan Sobo
c3a157a544
Revert "Use renderTo and renderFrom (instead of firstVisible/lastVisible) to adjust visible lines."
...
This reverts commit 419d7b1dec
.
Conflicts:
spec/app/editor-spec.coffee
2012-06-04 20:29:40 -06:00
Corey Johnson
0cfb2e9ef4
Rename Editor.visibleLines to Editor.renderedLines
2012-06-04 17:53:58 -07:00