Nathan Sobo
63e8099088
Allow successive accented characters to be inserted in React editor
...
Refs #2732
Because we're only checking the length of the input element's selection
in the React editor on textinput events and not also its content, we
were mistaking some IME compositions as accented character menu
insertions. Clearing the content of the input on 'compositionend'
prevents this issue.
2014-06-25 18:19:53 -06:00
Ben Ogle
b7d8e581ee
Merge pull request #2727 from atom/bo-subscribe-to-marker-changes
...
Subscribe to marker changes
2014-06-24 11:15:47 -07:00
Ben Ogle
396b21bc04
Fix specs failures caused by making lines 100% width
2014-06-24 10:32:48 -06:00
Kevin Sawicki
1c2e997415
Merge pull request #2700 from atom/bo-grammar-preload
...
Preload grammars on deserialization
2014-06-24 08:26:57 -07:00
Kevin Sawicki
148b691734
Test grammars included across multiple packages
2014-06-24 08:14:11 -07:00
Ben Ogle
ccada33d57
Remove nextTick in spec
2014-06-23 22:27:40 -06:00
Ben Ogle
1d9514ca81
Don't call nextTick within requestAnimationFrame
...
This seems to be causing stutter when scrolling on the GPU. When I don't
use nextTick when requesting animation frames, the problem seems to go
away. Maybe there's some issue with the integration between the Node
and Chromium event loops plus sending things to the compositor.
/cc @benogle
2014-06-23 22:21:28 -06:00
Kevin Sawicki
2e424baf2a
Use correct expected call count
2014-06-23 17:41:33 -07:00
Kevin Sawicki
0547d5a78b
Assert grammars are sync loaded on deserialize
2014-06-23 17:36:14 -07:00
Kevin Sawicki
0a54233ef0
Merge branch 'master' into bo-grammar-preload
2014-06-23 17:05:48 -07:00
Kevin Sawicki
e11785ce98
Serialize packages names in Workspace
2014-06-23 16:56:46 -07:00
Kevin Sawicki
b1d7de8d43
Add spec for serializing active grammars
2014-06-23 16:41:46 -07:00
Ben Ogle
f381abcbad
Re-render when a marker changes
...
fixes #2705
2014-06-23 16:00:36 -07:00
Ben Ogle
7139fd9f98
Conditionally render the gutter for the showLineNumbers option
...
Fixes #2707
2014-06-23 15:22:16 -07:00
Nathan Sobo
b9a3eca091
Correcly handle folds that end where other folds begin
...
Fixes #2247
2014-06-23 11:29:14 -06:00
probablycorey
9a5da3c27e
Add next tick call
2014-06-23 09:13:39 -07:00
probablycorey
43cb9af4a4
Add editor-event spec
2014-06-23 08:51:17 -07:00
Nathan Sobo
7c356d2592
Revert "Render highlights on their own layer to avoid GPU artifacts"
2014-06-21 01:58:11 -06:00
Nathan Sobo
e49414d2ec
Merge pull request #2699 from atom/ns-react-fix-artifacts
...
Render highlights on their own layer to avoid GPU artifacts
2014-06-20 17:03:26 -06:00
Nathan Sobo
e084bebb54
Autoscroll to selections in model layer when added
...
Fixes #2698
2014-06-20 16:53:46 -06:00
Nathan Sobo
d839ea9aa5
Don't render an opaque background behind line numbers
...
It doesn't help subpixel anti-aliasing like I thought, so screw it.
2014-06-20 16:07:19 -06:00
Nathan Sobo
68d0a99c6e
Default EditorComponent to updating synchronously in specs
...
This commit adds a static property, EditorComponent.performSyncUpdates,
which can be used to control the update behavior of all editor
components. In addition, an instance property called performSyncUpdates
be assigned to control the update behavior of a specific instance.
2014-06-20 15:06:16 -06:00
Nathan Sobo
64f3938f5c
Batch all editor updates together automatically via process.nextTick
2014-06-20 15:06:10 -06:00
Kevin Sawicki
4136ff566b
📝 Correct spec description
2014-06-20 13:09:51 -07:00
Kevin Sawicki
2fe523a664
Add spec for Editor::selectPageUp/Down
2014-06-20 13:09:51 -07:00
Ben Ogle
72b1821828
Render line decorations.
2014-06-19 17:20:05 -07:00
Ben Ogle
85abed2406
Merge pull request #2676 from atom/bo-cursor-gutter
...
Don’t render decorations on the last empty line when selection not empty
2014-06-19 15:10:18 -07:00
Ben Ogle
520ece4b13
💄 Wording
2014-06-19 15:09:49 -07:00
Ben Ogle
184068dc55
Add handlers for IME composition
2014-06-19 15:03:34 -07:00
Ben Ogle
908a2978ae
Don’t render decorations on the last empty line when selection not empty
2014-06-19 14:20:32 -07:00
Ben Ogle
bee4c9df8a
Revert "Select to the end of the last row rather than beginning of row + 1"
...
This reverts commit c5815d2af9
.
2014-06-19 12:06:09 -07:00
Ben Ogle
c5815d2af9
Select to the end of the last row rather than beginning of row + 1
2014-06-19 12:05:17 -07:00
Ben Ogle & Nathan Sobo
8295019891
Throw error when no animation frame was requested
2014-06-19 12:05:17 -07:00
Ben Ogle & Nathan Sobo
2edcc517b1
Handle dragging in the gutter
...
Including shift-click dragging better than the old editor!!!!!!
2014-06-19 12:05:17 -07:00
Ben Ogle & Nathan Sobo
9083103bb3
Add click and shift-click in gutter
2014-06-19 12:04:36 -07:00
Ben Ogle & Nathan Sobo
bc391094df
💄 Move helper
2014-06-19 12:03:18 -07:00
Kevin Sawicki
1e1f4cf173
Merge pull request #2662 from atom/ks-align-hard-tabs
...
Align hard tabs
2014-06-19 09:41:15 -07:00
Nathan Sobo
388763e7cd
Wait to measure characters if editor is hidden
...
Also, when characters *are* measured, request a display update
2014-06-19 04:19:51 -06:00
Nathan Sobo
f22e4225c3
Break into separate specs for lineHeight, fontSize, and fontFamily
2014-06-19 03:35:35 -06:00
Nathan Sobo
17f9cc49f2
Honor the center: true
option in scrollTo* methods
...
Fixes #2648
2014-06-18 21:48:14 -06:00
Kevin Sawicki
fe2cb046c3
Verify token screen and buffer delta
2014-06-18 17:26:38 -07:00
Kevin Sawicki
355f54ba00
Test odd-numbered tab length alignment
2014-06-18 17:10:10 -07:00
Kevin Sawicki
b56d4c6181
Update more expected tab lengths
2014-06-18 16:54:56 -07:00
Kevin Sawicki
ad9e2ab869
Update specs where tab is now only 1 space
2014-06-18 16:48:00 -07:00
Kevin Sawicki
c4c5d72bf1
Test multiple tab stops per line
2014-06-18 16:37:23 -07:00
Kevin Sawicki
0504244066
Test multiple tab lengths
2014-06-18 16:25:31 -07:00
Kevin Sawicki
8560526158
Add initial spec of hard tabs aligning
2014-06-18 16:24:35 -07:00
Ben Ogle
02757fc2de
💄
2014-06-18 14:22:05 -07:00
Ben Ogle
d5ea766541
Make click of fold marker unfold the row
2014-06-18 14:07:55 -07:00
Ben Ogle
7a9710b8c3
Add fold markers to folded lines
...
Fixes #2634
2014-06-18 13:47:38 -07:00