Commit Graph

13 Commits

Author SHA1 Message Date
Wliu
27c66300e4 Merge branch 'master' into wl-build-on-node-7 2017-03-21 23:25:31 -04:00
Antonio Scandurra
ea440148d8 Fix remaining tests 2017-03-12 11:57:16 +01:00
Wliu
e4f2c80eb5 Try 50? 2017-01-25 12:57:55 -05:00
Damien Guard
eac4f044a8
Fix MenuManager spec that forget to set darin to test macOS behavior 2016-11-29 16:55:14 -08:00
Nathan Sobo
a6094d2ed0 Don't allow menu shortcuts that could conflict with AltGraph characters
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2016-09-15 14:08:35 -06:00
Nathan Sobo
dc7a4a8168 Increase wait time in spec
This kinda sucks, but it’s not the end of the world.
2015-10-07 15:25:06 -05:00
Nathan Sobo
35c2ccd508 Build MenuManager in Atom environment constructor 2015-10-07 15:24:52 -05:00
Thomas Johansen
a2071a7093 🔥 Remove deprecations from global atom module 2015-09-22 10:37:05 -06:00
Nathan Sobo
447dfd8bec If a keystroke is bound to ‘unset!’, omit it in the application menu
Fixes atom/atom-keymap#79

This is more general than I would like. If the keystroke is unset in
any context, we err on the side of caution and don’t add it to the
application menu for any command. Since our application menu isn’t
context aware, this should be good enough for now and solve the 80%
case. Someday we should make the application menu update / gray out
options when the focused element changes.
2015-05-28 22:59:10 +02:00
Nathan Sobo
f6f891fa14 Construct test instance of MenuManager in spec 2014-09-29 11:45:01 -06:00
Nathan Sobo
2f93032a37 Don’t add duplicate items to the same menu 2014-09-29 11:11:36 -06:00
Nathan Sobo
c058b44a1b 💄 spec description 2014-09-29 11:11:10 -06:00
Nathan Sobo
bbeb0b5919 Return disposables from MenuManager which can be used to remove menus 2014-09-29 10:34:50 -06:00