Rafael Oleza
7f3f040628
Reformat all JS files using prettier
2019-05-31 18:33:56 +02:00
Rafael Oleza
a93808d1a8
Always use global it, beforeEach and afterEach methods
2019-02-28 20:39:21 +01:00
Rafael Oleza
cd302135f0
Fix undefined variables from specs
2019-02-28 19:30:03 +01:00
Rafael Oleza
d7d6d0838f
Remove unused vars from specs
2019-02-28 19:30:03 +01:00
Rafael Oleza
c35ec012b4
Run prettier on spec/ folder
2019-02-28 19:30:03 +01:00
Max Brunsfeld
0148ee7d9b
Always leave room for scrollbars
2018-06-07 14:42:06 -07:00
Jason Rudolph
5cce2b55bc
✅ Add test for setting tabIndex on atom-text-editor element
2018-01-04 17:55:05 -05:00
Katrina Uychaco
b3cee41f28
Merge remote-tracking branch 'origin/master' into ku-add-readonly-editor-attribute
2017-12-05 14:02:39 -08:00
Damien Guard
abc0d3c534
Remove stray console log
2017-12-04 13:13:03 -08:00
Katrina Uychaco
909caa2a59
Add 'readonly' attribute to <atom-text-editor> element
2017-11-28 20:01:31 -08:00
Max Brunsfeld
218eb57f3a
Avoid duplicate attachToDOM call
2017-11-21 12:00:54 -08:00
Max Brunsfeld
cbd55cd921
Fix incorrectly written async test
2017-11-21 11:57:57 -08:00
Nathan Sobo
5eae5ed5eb
Merge pull request #15392 from atom/fb-wb-standard-env
...
Use standard (eslint's) 'env' field over globals
2017-08-21 09:38:34 -06:00
Will Binns-Smith
882a1924f0
Remove one-off eslint global pragmas in favor of envs
2017-08-20 19:55:00 -07:00
Nathan Sobo
433c514673
Always render hidden input
...
This avoids mysterious timing issues in which the editor gets a 'focus'
event in a state where `isVisible` returns false. If we always render
the hidden input, we can always focus it.
Signed-off-by: Antonio Scandurra <as-cii@github.com>
2017-08-14 11:53:02 -06:00
Nathan Sobo
1d42590a5b
Force legacy scrollbars in text-editor-element-spec
2017-07-13 18:13:48 +02:00
Antonio Scandurra
c3f7edc104
Swap underlying editor correctly when calling setModel on editor element
...
Previously, when `setModel` was called, we forgot to update the pointer
to the component in the newly supplied editor. This was causing the
element to not update in response to model updates but only as a result
of focus or visibility changes. We suspect this regressed during the
rewrite of the editor rendering layer.
With this commit we will now correctly swap the element's underlying
editor by updating the component pointer on the newly supplied editor.
Also, if the element was already attached to another editor, we will
null out the component reference on it, because one instance of
`TextEditorElement` can only represent one instance of `TextEditor`.
2017-07-13 18:13:48 +02:00
Antonio Scandurra
96533998e2
Fix editor element tests on Windows
2017-05-12 16:51:05 +02:00
Nathan Sobo
c00ad62a0e
Pass mini attribute when creating new TextEditor from TextEditorElement
...
This avoids content being shifted over due to rendering and measuring
the gutter on element creation and then subsequently hiding it.
2017-05-05 09:30:08 +02:00
Antonio Scandurra
638bb78ecb
Fix build failures
2017-05-05 09:29:30 +02:00
Nathan Sobo
305fd14cd9
Add TextEditorElement.pixelRectRangeForScreenRange for compatibility
2017-05-05 09:29:30 +02:00
Nathan Sobo
a5a80448cb
Add intersectsVisibleRowRange on TextEditorElement
2017-05-05 09:29:30 +02:00
Antonio Scandurra
2a688db26b
Add better test coverage for the mini and placeholder-text attributes
2017-05-05 09:29:29 +02:00
Antonio Scandurra
552fbf7915
Honor the gutter-hidden attribute correctly
2017-05-05 09:29:29 +02:00
Nathan Sobo
4c8fd0cb75
Add tests for TextEditorElement.setScrollTop/Left
2017-05-05 09:29:29 +02:00
Nathan Sobo
996e0462b7
Don't update synchronously in text-editor-element-spec
2017-05-05 09:29:29 +02:00
Nathan Sobo
129749f2ff
Set updatedSynchronously to false in text-editor-element-spec
2017-05-05 09:29:29 +02:00
Antonio Scandurra
55950f9594
Assign placeholder text on the model only when the attribute is present
...
Signed-off-by: Nathan Sobo <nathan@github.com>
2017-05-05 09:29:29 +02:00
Nathan Sobo
a9d0f82afb
Use async/await in text-editor-element-spec
2017-05-05 09:29:29 +02:00
Nathan Sobo
5000f9eccb
Convert text-editor-element-spec to JS
2017-05-05 09:29:29 +02:00
