Antonio Scandurra
83f3c296f3
Add test for clicking an SVG element
2016-11-24 10:12:39 +01:00
Max Brunsfeld
bf056b0547
Prevent generated files from being excluded in Workspace::scan test
2016-11-21 11:05:50 -08:00
Joe Fitzgerald
f73aa46cef
Fix lint errors
2016-11-14 17:09:01 -07:00
Joe Fitzgerald
3123a92687
🎨 Fix spec, cleanup
2016-11-14 16:29:13 -07:00
Joe Fitzgerald
d0a011e93a
Fix specs, rename cp > child_process
2016-11-14 16:23:10 -07:00
Max Brunsfeld
5509475173
Ensure presenter forces DisplayLayer computations when rendering
...
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-11-11 12:55:57 -08:00
Antonio Scandurra
e34bc188d0
Make updateProcessEnv asynchronous
...
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-11-11 18:39:18 +01:00
Nathan Sobo
4ce0f5c509
Merge pull request #13095 from atom/fb-vj-follow-through
...
Introduce follow through behavior for tooltips
2016-11-02 08:31:19 -06:00
Nathan Sobo
f293b80e60
Merge pull request #13124 from atom/ns-preseve-shadow-specificity
...
Preserve specificity when transforming atom-text-editor::shadow
2016-11-02 08:30:21 -06:00
Nathan Sobo
9743c20949
Delete spawner spec because it's flaky and not adding value
...
@damieng... do you have any insight into why this wrapper exists? Could
we use BufferedProcess or something?
2016-11-02 08:29:56 -06:00
Nathan Sobo
44917fd568
Relocate/rephrase tooltip follow-through test
...
Also make sure it doesn't leave tooltips on the DOM, which causes
subsequent tests to fail
2016-11-01 14:13:44 -06:00
Christopher Chedeau
6f5e0ec48a
Introduce follow through behavior for tooltips
...
Inside of Nuclide, we have multiple places where we have multiple icons close together that have a tooltip: the left toolbar, the bottom status bar, the debugger icons...
The current behavior is very frustrating as you've got to wait for the delay on every single one of them. But, we have a clear signal that the user wants a tooltip when s/he waits the time to see it and it's likely that moving the mouse over the next item quickly means that s/he wants to see it as well.
This pull request introduces the concept of follow through: if you have seen a tooltip, you're going to instantly see tooltip on the next element you mouse over within a short timer (300ms right now).
Test Plan:
Video before:
![](http://g.recordit.co/7PCg0hjohP.gif )
Video after:
![](http://g.recordit.co/9OnZCvy9oI.gif )
Released under CC0
2016-11-01 11:35:06 -07:00
Michelle Tilley
94f603e50a
Pass package info to transpilers
2016-11-01 10:54:26 -07:00
Nathan Sobo
4ccd700871
Preserve specificity when transforming atom-text-editor::shadow
...
Simply replace ::shadow with .editor to preserve the specificity of the
transformed rule. This isn't beautiful, but it's the only way to
guarantee that the styling transition is smooth enough to justify not
bumping the major.
2016-11-01 11:23:29 -06:00
Michelle Tilley
de9ca2d4d5
Merge pull request #13101 from atom/mkt-package-specific-transpilation
...
Per-package transpilation
2016-11-01 09:58:02 -07:00
Michelle Tilley
64a8213bc1
const-ify some lets
2016-11-01 08:12:33 -07:00
Michelle Tilley
2d3afb431c
Include package name as part of cache key
2016-10-31 23:21:13 -07:00
Michelle Tilley
5743b2a283
Finish up a few missing expectations
2016-10-31 17:11:19 -07:00
Michelle Tilley
227ef5e2de
Add test for non-standard extension transpilation
2016-10-31 16:58:13 -07:00
Michelle Tilley
5c885e6947
We don't want no node_modules
2016-10-31 16:53:24 -07:00
Michelle Tilley
1bc1b49f84
Expect transpilation result on .code
2016-10-31 16:42:33 -07:00
Michelle Tilley
00a020d175
Move call to fs.realpathSync to CompileCache
2016-10-30 10:41:33 -07:00
Michelle Tilley
934ab30a0d
Add PackageTranspilationRegistry spec
2016-10-30 10:21:22 -07:00
bene
0411509b43
Fix toggleLineCommentsInSelection for empty lines
2016-10-29 14:04:30 +02:00
Ian Olsen
9d072c10fc
is to ===
2016-10-27 10:57:48 -07:00
Ian Olsen
f726dcc81b
Merge pull request #12922 from stereobooster/10474-prompt-to-save-unsaved-buffer
...
Fix for #10474
2016-10-26 16:35:43 -07:00
Damien Guard
8229924b96
History API, reopen project menu, command and list view
2016-10-21 15:13:59 -07:00
Antonio Scandurra
883bb15276
Don't trigger a blur event when focusing the same editor twice
2016-10-17 16:18:54 +02:00
Antonio Scandurra
4df74beba7
Merge branch 'master' into as-deprecate-shadow-dom
2016-10-17 12:06:00 +02:00
Max Brunsfeld
5db4c8dffb
Merge branch 'master' into mb-defer-work-when-opening-files
2016-10-14 12:20:41 -07:00
Max Brunsfeld
c870d1bbe9
Merge branch 'master' into mb-defer-work-when-opening-files
2016-10-12 11:56:27 -07:00
Max Brunsfeld
c2363010f8
Map out-of-range pixel positions to valid columns
2016-10-12 11:50:53 -07:00
Antonio Scandurra
503f31ea6c
Delete unnecessary dependencies in TokenizedBuffer
specs
2016-10-12 13:11:34 +02:00
Antonio Scandurra
d393cba75d
Simplify on-demand placeholder line creation and add test coverage
2016-10-12 13:04:03 +02:00
Antonio Scandurra
e317d7d325
Clean up tests
2016-10-12 12:10:34 +02:00
Antonio Scandurra
d3882c165f
🎨
2016-10-12 12:09:28 +02:00
Antonio Scandurra
00f4c7b282
Use TokenizedBuffer.prototype.tokenizedLineForRow
conservatively
...
Since this method will now construct a placeholder line, we want to use
it only where necessary to keep memory footprint to a minimum.
2016-10-12 09:04:41 +02:00
Antonio Scandurra
66510ae545
Handle null grammars consistently, building placeholder lines on-demand
...
Previously we were treating the local `NullGrammar` differently from
`atom.grammars.nullGrammar`. These two grammars are conceptually the
same, as the former was created to support editors creation without a
grammar registry.
To keep backwards-compatibility, we also build placeholder lines
on-demand when calling `TokenizedBuffer.prototype.tokenizedLineForRow`.
This ensure that packages relying on the internals of `TokenizedBuffer`
to retrieve syntactic boundaries won't break when the null grammar is
used or large file mode is on.
2016-10-12 09:04:41 +02:00
Max Brunsfeld
d20372a35f
Start on removing placeholder lines in TokenizedBuffer
2016-10-12 09:04:41 +02:00
stereobooster
63b9c8eb4b
Add test coverage for save before close
2016-10-11 01:19:55 +03:00
Nathan Sobo
72c5fcad82
Eliminate selector option in tooltip manager API
...
No packages use it currently, and it's really complex to support so
we should kill it while we have the chance. When it comes time to
rewrite the tooltip code or add features, not worrying about selectors
will make it easier.
2016-10-10 14:08:51 -06:00
Nathan Sobo
e71e1f4ed1
Test custom class option
2016-10-10 14:08:51 -06:00
Nathan Sobo
718cc017e6
Hide click-triggered tooltips when clicking anywhere outside of tooltip
...
Signed-off-by: Antonio Scandurra <as-cii@github.com>
2016-10-10 14:08:51 -06:00
Nathan Sobo
253917f007
Make tooltip accept an item option instead of tooltipElement
...
...and use view registry to resolve it to a view when showing the tooltip.
Signed-off-by: Antonio Scandurra <as-cii@github.com>
2016-10-10 14:08:51 -06:00
Antonio Scandurra
cccbde02fe
Merge branch 'master' into as-export-text-editor-ctor
2016-10-10 10:39:38 +02:00
Antonio Scandurra
5078d27773
Merge pull request #12925 from atom/as-fix-ci-failure
...
Return a `Disposable` when stubbing `observePreferredScrollbarStyle`
2016-10-10 10:39:09 +02:00
Antonio Scandurra
3e3f3bb608
Return a Disposable
when stubbing observePreferredScrollbarStyle
2016-10-10 10:13:49 +02:00
Antonio Scandurra
3d2e18747f
Prefer using new TextEditor
to Workspace.prototype.buildTextEditor
2016-10-10 09:28:36 +02:00
Antonio Scandurra
18ddcf902b
Statically assign a clipboard instance to the TextEditor
class
2016-10-07 18:21:09 +02:00
Antonio Scandurra
d48c1e96d0
Tweak wording in TextEditorElement spec
2016-10-07 15:42:21 +02:00