Commit Graph

8618 Commits

Author SHA1 Message Date
Max Brunsfeld
6d54578daa Use setTimeout instead of setImmediate in MenuManager
This should fix the flaky test failures that have been occurring on windows VSTS builds
2018-08-10 12:33:00 -07:00
Max Brunsfeld
87784989ad
Merge pull request #17750 from atom/mb-reduce-test-noise
Fix errors causing tests to fail when run from the UI
2018-08-10 12:22:54 -07:00
Max Brunsfeld
6f41353e9f Support two different content-matching regexes for tree-sitter grammars
* firstLineRegex is only tested against the first line of the file, and
  if it matches, it allows the grammar to be used for the file.
* contentRegex is only tested if the grammar matched the file name
  or the grammar's firstLineRegex matched. It is used to break ties
  between grammars like C and C++, Flow and JS
2018-08-09 17:19:32 -07:00
David Wilson
298db7314c Merge remote-tracking branch 'origin/master' into dw-repo-local-core-packages 2018-08-08 11:07:05 -07:00
Max Brunsfeld
826844c7e0 Emit onDidTokenize event from TreeSitterLanguageMode 2018-08-07 21:03:03 -07:00
David Wilson
6753b929cb Don't depend on ATOM_DEV_RESOURCE_PATH for local core package path 2018-08-07 16:09:34 -07:00
Max Brunsfeld
058e2b82dc Allow comma-separated selectors as keys in Tree-sitter scope mappings 2018-08-04 17:17:43 -07:00
Ash Wilson
b3518acd12
Merge branch 'master' into aw/custom-line-number-gutter 2018-07-31 07:54:57 -04:00
Ash Wilson
1b3f99c3d7
Merge pull request #17432 from atom/aw/watcher-up
atom/watcher upgrade
2018-07-30 15:36:06 -04:00
Ashi Krishnan
639164034f
Merge branch 'master' into regex-matchers-for-style-map 2018-07-30 12:46:08 -04:00
Ash Wilson
9beec5f175
Merge branch 'master' into aw/watcher-up 2018-07-30 09:26:08 -04:00
Ash Wilson
a61f006a62
Merge branch 'master' into aw/custom-line-number-gutter 2018-07-30 09:07:20 -04:00
Jason Rudolph
c74971e40c
Fix repository tests that fail when run in fork of atom/atom
Prior to this change, these tests assumed that the local repository is a
clone of atom/atom, and the tests (unintentionally) failed if the local
repository was a fork of atom/atom:

https://circleci.com/gh/marcomorain/atom-1/29

Instead of depending on the local clone of the atom repository for these
tests, this commit updates the tests to use one of the fixture
repositories. 😅
2018-07-27 09:40:38 -04:00
Max Brunsfeld
c8c4e4fa3d Delete redundant test for on atom.onUpdateAvailable
This test emitted an event in the main process, which caused exceptions 
in all *other* Atom windows 🙀.
2018-07-26 10:23:51 -07:00
Max Brunsfeld
1e2e461e5e Avoid excessive numbers of IPC event listeners in ApplicationDelegate 2018-07-26 10:20:01 -07:00
Jason Rudolph
c52dc23242
Merge pull request #17744 from atom/fix-17535
Teach Pane to always look for a pane item's onDidTerminatePendingState function
2018-07-26 08:44:49 -04:00
Jason Rudolph
84a241cb4e
Add failing test to demonstrate the bug identified in #17535 2018-07-24 16:45:37 -04:00
Ashi Krishnan
f91a4bb295
Merge pull request #17721 from atom/get-range-for-syntax-node-with-selector
Add TreeSitterLanguageMode::getSyntaxNodeContainingRange and TreeSitterLanguageMode::getSyntaxNodeAtPosition
2018-07-24 16:00:54 -04:00
Ashi Krishnan
b61ade47fc Merge master. 2018-07-24 14:09:42 -04:00
Ashi Krishnan
f2e54a70f0 Lint. 2018-07-24 13:34:41 -04:00
Ash Wilson
795c3b27aa
Use type instead of kind 2018-07-24 09:53:14 -04:00
Ash Wilson
dbace171df
Add a kind property to Gutters 2018-07-24 09:37:23 -04:00
Ashi Krishnan
45ab5488ae Remove debugger, test focus, and lint fixes. 2018-07-23 15:59:22 -04:00
Ashi Krishnan
926cf73e63 Tests for new query functions. 2018-07-20 21:22:12 -04:00
Jason Rudolph
457cde4525
Merge pull request #17720 from atom/jr-observe-repositories
Introduce `observeRepositories` and `onDidAddRepository`
2018-07-20 17:06:39 -04:00
Jason Rudolph
2a5f7e20c3
Fix overly-specific assertion
Fixes failing assertions [1] that unnecessarily assumed that the 
repository was cloned using `https://github.com/atom/atom.git` as the 
URL, as opposed to `git@github.com:atom/atom.git` as the URL.

[1] https://circleci.com/gh/atom/atom/7981
2018-07-20 15:15:59 -04:00
Max Brunsfeld
67402229f4
Merge pull request #17717 from atom/mb-tree-sitter-fixes
Fix bugs found when adding ruby tree-sitter grammar
2018-07-20 11:59:50 -07:00
Jason Rudolph
55da0d8f5d
Introduce atom.project.observeRepositories(callback) 2018-07-20 14:05:56 -04:00
Jason Rudolph
806d9311bf
Introduce atom.project.onDidAddRepository(callback) 2018-07-20 14:04:22 -04:00
Max Brunsfeld
ac3bc51c2a Improve criteria for when to fold partial vs entire buffer rows 2018-07-20 10:43:32 -07:00
Max Brunsfeld
137acb2f90 Fix highlighting when parent nodes extend beyond their first and last children 2018-07-20 10:16:19 -07:00
Max Brunsfeld
a283ca365f Fix a ruby folding issue 2018-07-19 17:15:04 -07:00
Max Brunsfeld
e500f933e0
Merge pull request #17702 from atom/fb-rh-text-editor-component-updateClassList
Modify TextEditorComponent updateClassList to always add managed classes to element
2018-07-19 16:27:21 -07:00
Ryan Holinshead
a280019847 Add spec to test that updateClassList does not blow away the managed class names (editor, is-focused, mini) when the element class names are changed.
Released under CC0
2018-07-16 14:58:39 -07:00
Max Brunsfeld
8fa9a45a54 Incorporated injected languages in scope descriptors 2018-07-16 14:17:39 -07:00
Max Brunsfeld
ebd546f572 Fix handling of folds inside highlighted tokens 2018-07-16 14:17:39 -07:00
Max Brunsfeld
a2f831f533 Merge branch 'master' into tree-sitter-injections 2018-07-13 16:10:19 -07:00
Max Brunsfeld
be5020f05f Rework handling of edited ranges 2018-07-13 13:03:56 -07:00
David Wilson
972b11c5d0
Merge pull request #17538 from atom/dw-nightly-releases
Implement RFC 002: Atom Nightly Releases
2018-07-11 10:28:26 -07:00
Lee Dohm
5a6b3c6e99
Merge pull request #17651 from cacheflow/tooltip-should-fade-on-keybaord-event-17431
Tooltip should fade on keybaord event 17431
2018-07-10 13:11:52 -07:00
Ashi Krishnan
ca854cc267 Spec for injected language folding.
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@github.com>
2018-07-09 17:17:58 -04:00
Ashi Krishnan
d6669f4337 Folding works, though folding to a particular level doesn't respect nested grammars.
Co-Authored-By: Max <maxbrunsfeld@github.com>
2018-07-09 16:33:24 -04:00
Max Brunsfeld
9484729969 Make select-larger-syntax-node command respect injected languages
Co-Authored-By: Ashi Krishnan <queerviolet@github.com>
2018-07-09 11:06:53 -07:00
Lexis Alexander
4d48ea8da2 Fixed failing tests and moved hiding of tooltips on keydown events to tooltip manager. 2018-07-09 00:58:03 -07:00
David Wilson
4527a44315 Merge branch 'master' into dw-nightly-releases 2018-07-06 16:06:24 -07:00
David Wilson
9858800ec0 Mock fs.createWriteStream to fix FileRecoveryService test 2018-07-06 16:04:29 -07:00
Max Brunsfeld
4de1a5c23d
Merge branch 'master' into tree-sitter-injections 2018-07-06 14:03:56 -07:00
Max Brunsfeld
670371c376 Fix propogation of included ranges for injections within injections
Co-Authored-By: Ashi Krishnan <queerviolet@github.com>
2018-07-06 13:53:13 -07:00
Matthew Dapena-Tretter
f60f1692fd Reset goal column on all cursor changes
Previously, pressing the home key (move-to-first-character-of-line)
while on an empty line wouldn't clear the goal column. This is because
it was only cleared on cursor *change* and that didn't result in a
change. With this commit, it's *always* cleared. Operations that want
to preserve the goal column can reset it afterwards.
2018-07-05 20:13:59 -07:00
Lexis Alexander
8af3079e0f Hides a tooltip when a user types in the editor.
-This addes a new keydown event that hides a tooltip when keyboard events occur.
-This closes #17431.
2018-07-05 20:00:10 -07:00
Max Brunsfeld
4be923fe32 Merge branch 'master' into tree-sitter-injections 2018-07-05 09:55:31 -07:00
Wliu
06ea494f46 Update Jasmine stacktrace formatting 2018-07-01 17:18:16 -04:00
David Wilson
ec2abbbc92 Possible fix for FileRecoveryService test on Linux 2018-06-30 11:25:14 -07:00
David Wilson
0d6b5d9e73 Fix CommandInstaller tests 2018-06-29 15:32:29 -07:00
Max Brunsfeld
e16e68094f Update highlighting when an injectable tree-sitter grammar is loaded 2018-06-29 14:47:38 -07:00
Max Brunsfeld
60c59c795c Fix highlighting problem when seeking past the end of a syntax tree 2018-06-29 12:53:43 -07:00
Max Brunsfeld
41c124cc13 Define highlight iter's position in terms of tree cursor position
Co-Authored-By: Ashi Krishnan <queerviolet@github.com>
2018-06-28 19:50:57 -07:00
Max Brunsfeld
cdb9529b68 Emit highlight change events when removing injections
Co-Authored-By: Ashi Krishnan <queerviolet@github.com>
2018-06-27 15:40:06 -07:00
Max Brunsfeld
6c85ff84a5 Start parsing right away when constructing a TreeSitterLanguageMode
Co-Authored-By: Ashi Krishnan <queerviolet@github.com>
2018-06-27 14:31:48 -07:00
Max Brunsfeld
613d4d65e9 Add text getter to SyntaxNode
Co-Authored-By: Ashi Krishnan <queerviolet@github.com>
2018-06-27 13:13:08 -07:00
Max Brunsfeld
4d3916f74e Add tests and docs for addInjectionPoint
Also, replace `addInjectionPattern` API with a single `injectionRegExp` 
field on the grammar.

Co-Authored-By: Ashi Krishnan <queerviolet@github.com>
2018-06-27 12:39:29 -07:00
Max Brunsfeld
c05dcb0bb8 Fix syntax highlighting problems with injected languages
Co-Authored-By: Ashi Krishnan <queerviolet@github.com>
2018-06-26 15:30:03 -07:00
Max Brunsfeld
e60f0f9b60 Get first test for grammar injections passing
Co-Authored-By: Ashi Krishnan <queerviolet@github.com>
2018-06-26 13:46:33 -07:00
David Wilson
d82c3979ac
Merge pull request #17521 from Aerijo/patch-1
Support activation hooks by grammar scope
2018-06-26 12:13:46 -07:00
Max Brunsfeld
37a3ae1491 Start work on Tree-sitter grammar injections
Co-Authored-By: Ashi Krishnan <queerviolet@github.com>
2018-06-22 16:21:32 -07:00
Max Brunsfeld
ed48feda82 Fix Tree-sitter folding bug affecting HTML 2018-06-18 14:41:34 -07:00
Benjamin Gray
e0041c3c24 Add tests for root-scope-used activation hook 2018-06-16 22:50:14 +10:00
Max Brunsfeld
6346f5ec9e Grammar scoring, weigh grammar type higher than content regex match
This fixes another regression introduces in #17468
2018-06-07 16:17:23 -07:00
Max Brunsfeld
0148ee7d9b Always leave room for scrollbars 2018-06-07 14:42:06 -07:00
Max Brunsfeld
70cf900ac0 Make TextEditorComponent tests reliably pass on retina screens 2018-06-07 14:09:31 -07:00
Max Brunsfeld
31f511aae7 Don't boost tree-sitter grammars' score unless they match in some way 2018-06-05 16:00:03 -07:00
Max Brunsfeld
4dbfadd0d5 Make Tree-sitter grammars' contentRegExp work as intended 2018-06-04 17:17:37 -07:00
Lee Dohm
57572d5221
Merge pull request #17008 from saadq/flow-double-slash
allow the use of double slash flow comments
2018-05-29 14:24:59 -07:00
Max Brunsfeld
f6d2d57299 Reparse again if there were changes since the last parse started 2018-05-23 08:11:54 -07:00
Max Brunsfeld
aced30da1f Start work on async parsing 2018-05-23 08:11:54 -07:00
hansonw
1f685768d5 Ensure grammar activation hooks are called after emitting new editors 2018-05-15 11:32:31 -07:00
Max Brunsfeld
7c6312b277 Update assertions about lack of memory-leak in GrammarRegistry specs 2018-04-25 13:17:33 -07:00
David Wilson
5b485dcb4b
Merge pull request #15165 from segevfiner/sf-windows-update-process-env
Recognize Windows cmd or powershell environment in updateProcessEnv
2018-04-25 10:44:29 -04:00
David Wilson
31e9ddad1e
Merge pull request #16864 from atom/fb-mdt-etch-docks
Convert Dock class to Etch
2018-03-30 11:59:08 -07:00
Ash Wilson
1342316e73
Maintain a global Map of ConfigFile instances 2018-03-27 08:54:37 -04:00
Ash Wilson
60033b7db1
🎨 remove extra space 2018-03-27 08:54:16 -04:00
Ash Wilson
7c9463acea
Specs for concurrent opening 2018-03-23 09:14:48 -04:00
saadq
fc45af02ae allow the use of double slash flow comments 2018-03-21 18:07:16 -04:00
Ash Wilson
8fee5f8fb2
Merge remote-tracking branch 'origin/master' into aw/no-really-read-only 2018-03-21 11:55:52 -04:00
Ash Wilson
cf576a0a7e
Verify Buffer-modifying methods on Selection 2018-03-21 11:52:47 -04:00
Ash Wilson
56a3f1bc41
Fill in missing ensureWritable() calls caught by the specs 2018-03-21 09:29:36 -04:00
t9md
38f080ef07 🔥 unnecessary async 2018-03-21 14:28:38 +09:00
t9md
f303d5906e undo/redo restore selection of change-initiated-editor 2018-03-21 14:26:05 +09:00
Ash Wilson
0f30f8d569
Specs for calling buffer modification methods on read-only editors 2018-03-20 16:31:06 -04:00
Antonio Scandurra
26837d65b4 Clip cursor width when soft-wrap is on and cursor is at the end of line
This prevents the parent tile from disabling sub-pixel anti-aliasing.
For some reason, adding `overflow: hidden` to the cursor container
element doesn't solve the issue, so we're adding this workaround
instead.
2018-03-13 12:04:35 +01:00
BoykoAlex
c61b27ba5c Support atom protocol links when links are handled 2018-03-12 22:23:00 -04:00
Philip Weiss
d7eff0ec55
Merge branch 'master' into fb-pw-simple-project-config 2018-03-09 14:06:14 -08:00
Antonio Scandurra
e2c89b29c8
Merge pull request #16428 from ernesto28/resize-pane
Resize pane
2018-03-09 08:38:44 +01:00
Matthew Dapena-Tretter
113453a219 Convert Dock to an etch component 2018-03-06 15:45:29 -08:00
Philip Weiss
685292bb8d fix linting issues 2018-03-06 11:09:58 -08:00
Philip Weiss
062dfdea80 address PR comments 2018-03-06 11:06:22 -08:00
Linus Eriksson
a790f1e3ec Randomize fontSize and lineHeight in the random test
This causes the failure fixed by https://github.com/atom/atom/pull/15831
to be caught by the randomized test more easily
2018-03-05 17:24:19 +01:00
Philip Weiss
232f821c35 remove getProjectSettings 2018-03-01 19:45:40 -08:00
Philip Weiss
3c02ab3621 add more spec 2018-03-01 19:12:53 -08:00
Philip Weiss
d5aaf9117a update with max's suggestions 2018-03-01 19:09:22 -08:00