pulsar-edit/pulsar
1
1
Fork 0
mirror of https://github.com/pulsar-edit/pulsar.git synced 2024-09-21 07:58:04 +03:00
Code Issues Packages Projects Releases Wiki Activity
18,744 Commits 92 Branches 796 Tags 452 MiB
899929a1ce
Commit Graph

4568 Commits

Author SHA1 Message Date
Ben Ogle
899929a1ce addScopedDefaults -> addScopedSettings 2014-10-03 10:46:57 -07:00
Ben Ogle
e5d67bb2ff Can remove the clearing of scoped properties 
Config is being created on each spec run!
 2014-10-03 10:46:57 -07:00
Ben Ogle
d47dbede29 Fix specs 2014-10-03 10:46:57 -07:00
Ben Ogle
a8fad6a0fb Use disposables for removing properties 2014-10-03 10:46:13 -07:00
Ben Ogle
e2ac19c17f Use config rather than syntax for scoped properties 2014-10-03 10:46:13 -07:00
Ben Ogle
d72b179b3b Use config in spec helper 2014-10-03 10:46:13 -07:00
Ben Ogle
356f4bec7c Basic scoped settings in Config works 2014-10-03 10:46:13 -07:00
Nathan Sobo
4c124b8174 Merge pull request #3633 from atom/ns-workspace-custom-elements 
Use custom elements for workspace views
 2014-10-02 16:00:31 -06:00
Nathan Sobo
6ce5356505 Fix handling of submenus in conversion of legacy context menu format 2014-10-02 10:47:03 -06:00
Nathan Sobo
b24e1fa405 Merge branch 'master' into ns-workspace-custom-elements 2014-10-01 17:15:09 -06:00
Ben Ogle
28ee1f3598 Fix spec 2014-10-01 14:53:31 -07:00
Nathan Sobo
f004f8c45d Merge branch 'master' into ns-workspace-custom-elements 
Conflicts:
	spec/pane-view-spec.coffee
	spec/workspace-view-spec.coffee
	src/workspace-view.coffee
	src/workspace.coffee
 2014-10-01 11:49:23 -06:00
Nathan Sobo
33c1ce863e Pluralize Project API 
This changes all APIs concerning paths and repositories on the project
to be plural, preparing us to switch to multi-folder projects. It
doesn’t make any changes to actually support multiple folders. Instead
we just wrap the previous return values in singleton arrays.

* constructor ‘path’ params -> ‘paths’
* getRootDirectory -> getDirectories
* getPath -> getPaths
* setPath -> setPaths
* getRepo -> getRepositories
 2014-10-01 10:48:39 -06:00
Ben Ogle
57603b3a00 Fix config resetting all values when one changes. 
Closes atom/settings-view#257
 2014-10-01 09:37:25 -07:00
Nathan Sobo
70a804bdb4 Rename Workspace::registerOpener to ::addOpener for consistency 2014-09-30 17:09:35 -06:00
Nathan Sobo
72538891dd Merge remote-tracking branch 'origin/master' into ns-context-menu-cleanup 
Conflicts:
	src/menu-manager.coffee
 2014-09-30 14:53:10 -06:00
Nathan Sobo
211a1c75e2 Return a disposable from ThemeManager::requireStylesheet 2014-09-30 14:02:04 -06:00
Nathan Sobo
fd3cb1a232 💄 theme-manager-spec 2014-09-30 14:01:41 -06:00
Ben Ogle
54af7eced1 Handle empty config files + reset settings before applying user config 
Closes #3664
 2014-09-30 12:39:07 -07:00
Nathan Sobo
10f7a671c8 Merge pull request #3667 from atom/ns-deserializer-manager-disposables 
Return disposables from DeserializerManager::add
 2014-09-30 13:10:35 -06:00
Nathan Sobo
33a5ca30dc Use DeserializerManager::add disposable instead of ::remove in specs 2014-09-30 12:58:10 -06:00
Nathan Sobo
8cb8f09803 Return a Disposable instance from DeserializerManager::add 2014-09-30 12:58:10 -06:00
Nathan Sobo
4a0c5aaa70 Prevent adjacent menu separators 2014-09-30 12:06:27 -06:00
Nathan Sobo
eb929cb7a2 Honor item specificity while still preserving addition order 
Rather than using order to specify item precedence, we now construct
a set of menu items for each element traversing upward from the target.
When merging items for a given element, we pass the specificity to the
merge function, which uses it to decide whether or not to clobber
existing items. When assembling the overall menu, we don’t ever clobber
to ensure that items added for elements closer to the target always win
over items matching further up the tree.
 2014-09-30 12:06:27 -06:00
Nathan Sobo
36d5359ef4 Restore original context menu ordering 
Previously I used CSS specificity to order the most specific / recently
added menu items for a given element *first* when building up the
context menu. When a duplicate label was found for a given menu I would
refrain from inserting it. Now instead I order things the opposite way.
The most specific / recently added items come later and items with the
same label are clobbered by later items.
 2014-09-30 12:06:26 -06:00
Nathan Sobo
915cfe15f5 Clear context menus between specs 2014-09-30 12:06:26 -06:00
Nathan Sobo
f082f93ead Update specs for new ContextMenuManager API/behavior 
When selectors have the same specificity, menu items added *later*
appear higher in the list.
 2014-09-30 12:06:26 -06:00
Nathan Sobo
782f9c609e Add shouldDisplay hook for context menu items 
If present, if a falsy value is returned from this function for a given
context menu invocation, the item will not be displayed.
 2014-09-30 12:06:09 -06:00
Nathan Sobo
3a567b3c5b Call context menu item ::created hooks with the click event 2014-09-30 12:06:08 -06:00
Nathan Sobo
c5b395579b Add devMode flag to individual items 2014-09-30 12:06:08 -06:00
Nathan Sobo
f8225a6441 Make arguments atom.contextMenu.add consistent with atom.menu.add 2014-09-30 12:06:08 -06:00
Nathan Sobo
5e6e3c8d72 Merge pull request #3655 from atom/ns-menu-disposables 
Return disposables from MenuManager::add and add specs
 2014-09-30 12:05:11 -06:00
Ben Ogle
a8d93f9cf4 Spec for unsubscribing from commands 2014-09-30 09:45:55 -07:00
Ben Ogle
b54deccfae String type must be strict. 
It makes sense to coerce from more general -> more specific data types.
eg. string -> int, etc. But coercing the other way is problematic
in the case of chaining because the more general type will swallow the
specific type. eg. Setting `false` on type: [‘string’, ‘boolean’] will 
coerce the boolean to a string, and will never allow the value to be
a boolean.
 2014-09-29 16:09:49 -07:00
Ben Ogle
a7185a894f Fix specs 2014-09-29 16:09:49 -07:00
Ben Ogle
16c7fd3d70 Add spec for update event on load 2014-09-29 16:09:49 -07:00
Ben Ogle
08b138997d Change the onDidChange / observe arguments 
Support passing no keypath
 2014-09-29 16:09:48 -07:00
Ben Ogle
ef19e925e9 Strings accept numbers too 2014-09-29 16:09:48 -07:00
Ben Ogle
2c1fa19e27 Update spec strings 2014-09-29 16:09:48 -07:00
Ben Ogle
22fb5adda9 Remove deprecated calls for config.observe .. callNow: false in core 2014-09-29 16:09:47 -07:00
Ben Ogle
800dee09ba Make boolean schema validator a little tighter 2014-09-29 16:09:47 -07:00
Ben Ogle
6b4ce902ba Undefined in Config::set always unsets the value 2014-09-29 16:09:46 -07:00
Ben Ogle
03a9a67ba8 Move spec 2014-09-29 16:08:04 -07:00
Ben Ogle
ae76bd6c96 Do not allow infinity in number types 2014-09-29 16:08:04 -07:00
Ben Ogle
662fc443dc Fix specs 2014-09-29 16:08:04 -07:00
Ben Ogle
0fc773c1fc Warn when loading bogus values from the user's config 2014-09-29 16:08:03 -07:00
Ben Ogle
832b4ae4d8 Fix specs 2014-09-29 16:08:03 -07:00
Ben Ogle
af1bdaf901 Dont fail when there are thigns to set with array and object types 2014-09-29 16:08:03 -07:00
Ben Ogle
969ca048e8 Fix specs 2014-09-29 16:08:03 -07:00
Ben Ogle
0d2fdec326 Fix specs in config 2014-09-29 16:08:03 -07:00