Commit Graph

1971 Commits

Author SHA1 Message Date
Amin Yahyaabadi
4396b62402 IsNightlyBranch variable 2020-09-16 03:28:27 -05:00
Amin Yahyaabadi
b41ec1821d Install script/vsts on nightly or release branch 2020-09-16 03:27:18 -05:00
Sadick
b17a5ab6f6
Merge pull request #21212 update npm@6.14.8
update npm@6.14.8
2020-09-16 11:04:54 +03:00
Sadick
b6da674260
Merge pull request #20632
Bump https-proxy-agent from 2.2.1 to 2.2.4 in /script/vsts
2020-09-16 10:59:51 +03:00
Amin Yahyaabadi
36aab2b0e3 Finalize in the end (not between retry attempts)
don't finalize until the end which the test fails or passes.
2020-09-16 01:46:09 -05:00
Amin Yahyaabadi
2ac5d996a6 use preparation instead of installing scripts/vsts 2020-09-16 01:19:54 -05:00
Amin Yahyaabadi
a2512fc887 Merge branch 'master' into upstream_master 2020-09-16 01:16:29 -05:00
Amin Yahyaabadi
3dbe763e14 test on windows-2019
This increases the test-pass rate and reduced the timeouts

https://github.com/atom-ide-community/atom/pull/109
2020-09-16 00:41:26 -05:00
Amin Yahyaabadi
c419744ee3 Update lock files 2020-09-16 00:29:28 -05:00
Amin Yahyaabadi
7040bf9e44 use npm 6.14.8 in ci 2020-09-16 00:18:00 -05:00
Amin Yahyaabadi
fca933fe43 use npm 6.14.8 in script/ 2020-09-16 00:17:37 -05:00
Sadick
0628ba5803
Merge pull request #20043 from atom/dependabot/npm_and_yarn/script/mixin-deep-1.3.2
Bump mixin-deep from 1.3.1 to 1.3.2 in /script
2020-09-16 06:56:34 +03:00
Sadick
94b39402cc
Merge pull request #21249 from atom/dependabot/npm_and_yarn/script/vsts/decompress-4.2.1
Bump decompress from 4.2.0 to 4.2.1 in /script/vsts
2020-09-16 06:53:15 +03:00
Amin Yahyaabadi
a9e690d165 refactor the static parts out of the test function which runs by async 2020-09-15 20:40:03 -05:00
dependabot[bot]
1c5413af1b
Bump mixin-deep from 1.3.1 to 1.3.2 in /script
Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/jonschlinkert/mixin-deep/releases)
- [Commits](https://github.com/jonschlinkert/mixin-deep/compare/1.3.1...1.3.2)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-15 20:29:04 +00:00
dependabot[bot]
d2e257aabf Bump https-proxy-agent from 2.2.1 to 2.2.4 in /script/vsts
Bumps [https-proxy-agent](https://github.com/TooTallNate/node-https-proxy-agent) from 2.2.1 to 2.2.4.
- [Release notes](https://github.com/TooTallNate/node-https-proxy-agent/releases)
- [Commits](https://github.com/TooTallNate/node-https-proxy-agent/compare/2.2.1...2.2.4)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-15 23:26:03 +03:00
dependabot[bot]
1cb581717c
Bump node-fetch from 2.2.0 to 2.6.1 in /script/vsts
Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.2.0 to 2.6.1.
- [Release notes](https://github.com/bitinn/node-fetch/releases)
- [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md)
- [Commits](https://github.com/bitinn/node-fetch/compare/v2.2.0...v2.6.1)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-15 20:09:13 +00:00
Sadick
1da06ef5fa
Merge pull request #21294
Bump node-fetch from 2.6.0 to 2.6.1 in /script
2020-09-15 23:08:03 +03:00
Amin Yahyaabadi
ebe480dfe2 Update package-lock.json 2020-09-14 21:29:42 -05:00
Amin Yahyaabadi
73d78b6f8c use @aminya/electron-link@^0.6.3" 2020-09-14 21:24:00 -05:00
Amin Yahyaabadi
85e0f06e69
Merge pull request #159 from atom-ide-community/timed-out-tests-more 2020-09-14 18:38:49 -05:00
Amin Yahyaabadi
d72a8eeaf1 use 'max' for JOBs to use all available cores
https://github.com/nodejs/node-gyp/pull/1770
2020-09-14 17:45:00 -05:00
Amin Yahyaabadi
82abb4ded2 rename windows jobs
to be consistent with macOS
2020-09-14 17:37:37 -05:00
aminya
96480ea5b9 Use async.series
Revert b61475ffe4
2020-09-14 17:37:37 -05:00
Amin Yahyaabadi
3993c420b1 collect output only if stdout exits 2020-09-14 17:37:37 -05:00
aminya
bef8d82106 fix: rename windows job back to Windows 2020-09-14 17:37:36 -05:00
Amin Yahyaabadi
3b796f7995 refactor spawnTest 2020-09-14 17:37:36 -05:00
Amin Yahyaabadi
a69e0f8117 function to create packageTestSuites only when needed 2020-09-14 17:37:36 -05:00
Amin Yahyaabadi
f4bdb22e7d function to create coreRenderProcessTestSuites
only when needed
2020-09-14 17:37:36 -05:00
aminya
66c743465c print the used testCommand for failed tests 2020-09-14 17:37:36 -05:00
aminya
d742f25895 macos: run core main tests in the build phase 2020-09-14 17:37:11 -05:00
aminya
7d93415093 bootstrap in case cache misses 2020-09-14 17:37:11 -05:00
aminya
849216a750 always upload atom windows.zip for x64 2020-09-14 17:37:11 -05:00
aminya
fa6a8e32ce Run windows core main tests in the build step 2020-09-14 17:37:11 -05:00
aminya
62b440d870 Run windows renderer tests in parallel 2020-09-14 17:37:10 -05:00
aminya
a4fac1e772 test: use Azure format for printing 2020-09-14 17:37:10 -05:00
aminya
a69bf7be10 warn before error reporting
Helps visually
2020-09-14 17:26:50 -05:00
aminya
e386c2bf02 run tests using async.parallel 2020-09-14 17:26:50 -05:00
aminya
d04d91835c allow requesting parallel tests for all OS 2020-09-14 17:26:50 -05:00
aminya
b992fbf1b1 parallelize core tests 2020-09-14 17:26:50 -05:00
aminya
a598fdd26e run package tests in parallel for windows tests 2020-09-14 17:26:50 -05:00
Amin Yahyaabadi
0599fbd796 add Error Downloading Update to the retry commands 2020-09-14 16:07:50 -05:00
Amin Yahyaabadi
fd0718792b increase the retryNumber to 6 2020-09-14 16:04:18 -05:00
Sadick
9d65b79d7a
Merge pull request #21081 from atom-ide-community/CI_templates_4upstream
Cross-platform CI scripts
2020-09-14 17:34:42 +03:00
Benjamin Gray
2bc1a117b6 ⬆️ fs-extra@9.0.1 2020-09-14 13:54:33 +03:00
Amin Yahyaabadi
a20ccc3acf set JOBS to enabled parallel builds in node-gyp 2020-09-13 21:16:37 -05:00
Amin Yahyaabadi
0ad2f9b7bf execFileSync bootstrap in build script 2020-09-13 21:16:37 -05:00
Amin Yahyaabadi
e6fe32bd21 parallelize bootstrap 2020-09-13 21:16:37 -05:00
Amin Yahyaabadi
7cf6c4cabb run installApm in a thread 2020-09-13 21:16:37 -05:00
Amin Yahyaabadi
fe90f78ba7 run installScriptDependencies in a thread 2020-09-13 21:16:37 -05:00
Amin Yahyaabadi
4c7688e595 script runner package-lock.json 2020-09-13 21:16:37 -05:00
Amin Yahyaabadi
47143207ac add script-runner/package json files to cache tracker 2020-09-13 21:16:37 -05:00
Amin Yahyaabadi
776b06971c script runner (threads) 2020-09-13 21:16:37 -05:00
Amin Yahyaabadi
b14d69a972 Merge branch 'master' into upstream_master 2020-09-11 16:14:09 -05:00
Amin Yahyaabadi
ea1283f935 use npm install in get-release-version
https://github.com/atom/atom/pull/21081/files#r487132495
2020-09-11 12:22:41 -05:00
Amin Yahyaabadi
dc2f6f8513 CI: Drop old workaround, refactor script blocks
This old bug in the CI inexplicably went away at some point.

Co-Authored-By: DeeDeeG <DeeDeeG@users.noreply.github.com>
2020-09-11 12:22:41 -05:00
DeeDeeG
f47f479285 CI: Delete outdated comment in platforms/linux.yml
We no-longer run the Linux build in an old Ubuntu 14.04 "Trusty Tahr"
Docker container. We run builds directly in a virtualized Ubuntu 16.04
"Xenial Xerus" image now.
2020-09-11 12:22:41 -05:00
DeeDeeG
e3fc785194 CI: Add NightlyFlag parameter in GetReleaseVersion
We can use this to run `get-release-version.js`
with the `--nightly` flag on the "Atom Nightly" pipeline.
2020-09-11 12:22:41 -05:00
DeeDeeG
727352adbc CI: Move GetReleaseVersion to its own template 2020-09-11 12:22:41 -05:00
Amin Yahyaabadi
4ddf0df65f CI: Don't upgrade npm twice on Windows
We already install the npm version we want in previous steps

https://github.com/atom-ide-community/atom/pull/140

Co-Authored-By: DeeDeeG <DeeDeeG@users.noreply.github.com>
2020-09-11 10:38:44 -05:00
Amin Yahyaabadi
8b05ca5c7d rename "buildArch" to "BUILD_ARCH"
Co-authored-by: Amin Yahyaabadi <aminyahyaabadi74@gmail.com>
2020-09-11 10:21:55 -05:00
aminya
19b5177396 using templates in release-branch-build.yml 2020-09-11 10:21:55 -05:00
aminya
0c9103c7e3 using templates in nightly-release.yml 2020-09-11 10:21:55 -05:00
Benjamin Gray
e4701771b8
Improve CS require comment (#21062)
Turns out the comment was misleading; the build also fails to find modules like `donna` without the import.
I've instead changed the message to make it more vague, so removal requires more consideration.
2020-09-11 12:20:27 +03:00
aminya
c91f9158c4 use new-item to not conflict mkdir on macos 2020-09-10 23:24:07 -05:00
Amin Yahyaabadi
ac05d47c4e use BULD_ARCH directly test 2020-09-10 23:24:06 -05:00
aminya
f328045b15 test: using pwsh for managing env variables 2020-09-10 23:24:06 -05:00
Amin Yahyaabadi
9fd27dd02e using AGENT_OS directly test 2020-09-10 23:24:06 -05:00
aminya
e88c2e9f86 combine test for all OS
test: quote x86 runner
2020-09-10 23:24:06 -05:00
Amin Yahyaabadi
7212e1e070 download unzip test 2020-09-10 23:24:06 -05:00
Amin Yahyaabadi
eaf65e6e6c test in linux.yml 2020-09-10 23:24:06 -05:00
Amin Yahyaabadi
85b86d929d linux-test.yml 2020-09-10 23:24:06 -05:00
Amin Yahyaabadi
e45494a4f0 test in macos.yml 2020-09-10 23:24:06 -05:00
Amin Yahyaabadi
50ebc2162a macos-test.yml 2020-09-10 23:24:06 -05:00
Amin Yahyaabadi
3ca004b342 test in windows.yml 2020-09-10 23:24:06 -05:00
Amin Yahyaabadi
7dcdbb0c25 windows-test.yml 2020-09-10 23:24:06 -05:00
Amin Yahyaabadi
f2fcb62404 download-unzip.yml 2020-09-10 23:24:06 -05:00
Sadick
ddcdeb52f6
Merge pull request #21269
CI build template including patches
2020-09-11 06:32:58 +03:00
Sadick
c0a547d560
Merge pull request #21262 from atom-ide-community/CI-publish-template
Ci publish template
2020-09-10 23:01:39 +03:00
Amin Yahyaabadi
366c3b56f6 clarify publish template doc 2020-09-10 14:37:21 -05:00
dependabot[bot]
e4dc3afea2
Bump node-fetch from 2.6.0 to 2.6.1 in /script
Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/bitinn/node-fetch/releases)
- [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md)
- [Commits](https://github.com/bitinn/node-fetch/compare/v2.6.0...v2.6.1)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-10 18:51:57 +00:00
dependabot[bot]
91632649e3
Bump bl from 3.0.0 to 3.0.1 in /script
Bumps [bl](https://github.com/rvagg/bl) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/rvagg/bl/releases)
- [Commits](https://github.com/rvagg/bl/compare/v3.0.0...v3.0.1)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-09 15:45:36 +00:00
Sadick
23f9fca960
Update node to 12.16.3
We have been experiencing linux build failures on our CI.
This failure seem to be cause by
https://github.com/atom/atom/pull/21079.

Related conversation https://github.com/atom/apm/pull/900
2020-09-09 17:54:34 +03:00
DeeDeeG
1191b31bef CI: Use Python 3.8 on all OSes
Co-authored-by: Amin Yahyaabadi <aminyahyaabadi74@gmail.com>
2020-09-08 20:10:17 -04:00
DeeDeeG
2b5be8d084 CI: Don't upgrade npm twice on Windows 2020-09-08 20:08:10 -04:00
DeeDeeG
d27beacc2c CI (Windows): No "buildArch" var, use "BUILD_ARCH"
Having two variables "buildArch" and "BUILD_ARCH"
set to the same value ("x86" or "x64") was redundant.

Co-authored-by: Amin Yahyaabadi <aminyahyaabadi74@gmail.com>
2020-09-08 16:31:49 -04:00
Amin Yahyaabadi
a334fd5142 include AC user and password in the env map 2020-09-06 10:48:19 -05:00
Amin Yahyaabadi
470d5d9c0b Revert "Merge pull request #21267 from atom/revert-build-template"
This reverts commit 13e6412ea9, reversing
changes made to 7607751127.
2020-09-06 10:47:51 -05:00
sadick254
6b2a977d99 Revert "Merge pull request #21230 from atom-ide-community/CI_build_template"
This reverts commit 3179ab456d, reversing
changes made to fd469777e3.
2020-09-06 09:36:28 +03:00
sadick254
a7972fd129 Revert "Merge pull request #21264 from atom-ide-community/CI_build_template"
This reverts commit 7607751127, reversing
changes made to e9a2ec056b.
2020-09-06 09:35:31 +03:00
DeeDeeG
abf056df70 CI: Patch to really skip uploading artifacts to S3
On the "release-branch-build.yml" pipeline, in the "IsSignedZipBranch"
condition, we were not passing the re-mapped env variables.

This patch fixes the `env:` block to send the re-mapped env vars,
as was intended. This fixes an oversight in the previous PR.
2020-09-05 15:02:57 -04:00
Amin Yahyaabadi
5c4daaeafc use elseif instead of if
Only one condition will be true
2020-09-05 11:29:23 -05:00
Amin Yahyaabadi
a1895205b1 include code-sign variables in env map instead
Use Azure macros to interpolate the keys
2020-09-05 11:29:22 -05:00
Amin Yahyaabadi
8ce3c32227 rename publish template props 2020-09-05 11:20:46 -05:00
aminya
bfd73f6018 create empty FileID for x86 2020-09-05 11:03:40 -05:00
aminya
f8966b807b using pwsh for setting FileID 2020-09-05 11:03:38 -05:00
aminya
d88254e557 combine publish for all OS 2020-09-05 10:41:02 -05:00
Amin Yahyaabadi
09706cf36c publish in linux.yml 2020-09-05 10:41:02 -05:00
Amin Yahyaabadi
d9b8219158 linux-publish.yml 2020-09-05 10:41:02 -05:00
Amin Yahyaabadi
6b51a926f3 publish in macos.yml 2020-09-05 10:41:02 -05:00
Amin Yahyaabadi
77d115f42f macos-publish.yml 2020-09-05 10:41:02 -05:00
Amin Yahyaabadi
74e82a16e5 publish in windows.yml 2020-09-05 10:41:02 -05:00
Amin Yahyaabadi
9e09d7f2f8 windows-publish.yml 2020-09-05 10:41:02 -05:00
dependabot[bot]
35e433fc21
Bump decompress from 4.2.0 to 4.2.1 in /script/vsts
Bumps [decompress](https://github.com/kevva/decompress) from 4.2.0 to 4.2.1.
- [Release notes](https://github.com/kevva/decompress/releases)
- [Commits](https://github.com/kevva/decompress/compare/v4.2.0...v4.2.1)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-04 04:13:02 +00:00
Amin Yahyaabadi
dec9fb9355 Retry 4 times 2020-08-31 03:42:02 -05:00
Amin Yahyaabadi
0af78edf09 pass exitCode 2020-08-31 03:42:02 -05:00
Amin Yahyaabadi
2f3be2fcdb call the callback only on fail or success
Don't call the callback on retry
2020-08-31 03:41:38 -05:00
Amin Yahyaabadi
a785eb74f3 call the callback after retrying 2020-08-31 00:37:43 -05:00
Amin Yahyaabadi
5fabcbb4f7 Retry the timed out tests for a number of times 2020-08-31 00:37:43 -05:00
Amin Yahyaabadi
4ef17f67ff shouldTryAgain 2020-08-31 00:37:43 -05:00
Amin Yahyaabadi
6190eafa76 isTimedOut 2020-08-31 00:37:43 -05:00
Amin Yahyaabadi
2d8ab1cb19 createTestKey 2020-08-31 00:37:43 -05:00
Amin Yahyaabadi
7e8eebade2 retryOrFailTest 2020-08-31 00:37:43 -05:00
Amin Yahyaabadi
05b48aeecf Fix the new line printing in error report 2020-08-31 00:37:43 -05:00
Amin Yahyaabadi
1421e617c1 build with the visual studio included in the image 2020-08-30 20:51:42 -05:00
Amin Yahyaabadi
981a846646 build on vs2017-win2016 2020-08-30 20:51:39 -05:00
Amin Yahyaabadi
851942770c windows-build-tools 4 2020-08-30 20:47:00 -05:00
Amin Yahyaabadi
3d3b38357a use @aminya/windows-build-tools 2020-08-30 20:46:15 -05:00
Amin Yahyaabadi
13906ea3be collect output only if stdout exits 2020-08-30 00:26:49 -05:00
Amin Yahyaabadi
6d19d5cf62 refactor spawnTest 2020-08-29 22:11:07 -05:00
DeeDeeG
959a19b0cd Merge remote-tracking branch 'origin/master' into merge-upstream-master 2020-08-29 13:49:29 -04:00
aminya
15d0b7d5d3 build: use esc for passing arguments 2020-08-29 07:23:18 -05:00
Amin Yahyaabadi
7b7f00060e use BULD_ARCH directly build 2020-08-29 07:23:18 -05:00
aminya
8fffa4fe4d build: using pwsh for managing env variables
Azure syntax for conditional env variables has issues
https://stackoverflow.com/questions/62890370/azure-pipeline-conditional-env-variable-based-on-os
2020-08-29 07:23:18 -05:00
Amin Yahyaabadi
88f0466d6b using AGENT_OS directly build 2020-08-29 07:23:18 -05:00
aminya
38f077eecb combine build for all OS 2020-08-29 07:23:18 -05:00
Amin Yahyaabadi
c8cf83e901 Linux use Clang 9 in build 2020-08-29 07:23:18 -05:00
Amin Yahyaabadi
6202e3adfb linux-build.yml 2020-08-29 07:23:18 -05:00
Amin Yahyaabadi
f17abf5fb6 macos-build.yml 2020-08-29 07:23:18 -05:00
Amin Yahyaabadi
2e04b9bd66 windows-build.yml 2020-08-29 07:14:38 -05:00
DeeDeeG
c79d2adbe0 CI: Restore caches in sync
Track the same files for restoring all three caches.
Either they all get restored, or none of them do.

Stop tracking apm/package-lock.json, as it hasn't been stable lately.

Start tracking script/vsts/platforms/templates/preparation.yml,
because that's where Node and npm bumps and so on live.
2020-08-28 23:19:03 +03:00
sadick254
46ef8d5733 Use npm install 2020-08-28 22:47:45 +03:00
Amin Yahyaabadi
57f1ae657c
CI bootstrap template
* windows-bootstrap.yml

* macos-bootstrap.yml

* linux-bootstrap.yml

* combine bootstrap for all OS

* GitHub token in bootstrap.yml

* Use pwsh in bootstrap.yml

* Linux use Clang 9 in bootstrap

* bootstrap: using pwsh for managing env variables

* fix bootstrap condition indentation

* using AGENT_OS directly bootstrap
2020-08-28 17:25:10 +03:00
Amin Yahyaabadi
00263f8909
CI preparation template
Use azure templates.
2020-08-27 14:58:11 +03:00
DeeDeeG
2f550cf0d3
CI: Use Cache@2 task in place of the old SaveCache@1 (#21057)
* CI: Use Cache@2 task in place of SaveCache@1

This is the officially supported successor to the old,
unofficial, Microsoft-DevLabs-hosted cache task.

It is simpler/easier to configure, and thus more friendly to forks.
2020-08-26 17:38:19 +03:00
Amin Yahyaabadi
43e4929ba8 add should sign and make code-signing conditional 2020-08-24 21:54:52 +03:00
Amin Yahyaabadi
0af3325408 ci: use windows-2019 image + test on windows-2016 2020-08-24 06:46:14 -05:00
DeeDeeG
9b03967dbe CI preparation.yml: No windows-build-tools
We can use the Visual Studio install included with the CI image.
Saves about two minutes of preparation time.
2020-08-24 06:44:28 -05:00
Amin Yahyaabadi
95bf018861 windows-build-tools 5 2020-08-24 06:44:28 -05:00
Amin Yahyaabadi
e1b300450a ci: use windows-2019 image 2020-08-23 18:04:31 -05:00
Amin Yahyaabadi
44c112d17c bootstrap lock update 2020-08-22 04:53:22 -05:00
Amin Yahyaabadi
c77bcfe9c1 use npm 6.1.4.8 in script/ 2020-08-22 04:53:20 -05:00
Amin Yahyaabadi
a4ade09eb2 use npm 6.14.8 in the ci 2020-08-22 04:53:16 -05:00
Amin Yahyaabadi
e1645f527e bootstrap (#101)
Updates lock files

Co-Authored-By: DeeDeeG <DeeDeeG@users.noreply.github.com>
2020-08-22 04:35:26 -05:00
Amin Yahyaabadi
1958ff4996
CI: option to skip upload (#99)
Co-authored-by: Amin Yahyaabadi <aminyahyaabadi74@gmail.com>
Co-authored-by: DeeDeeG <DeeDeeG@users.noreply.github.com>
2020-08-21 20:57:35 -05:00
Amin Yahyaabadi
499f34b395 function to create packageTestSuites only when needed 2020-08-21 18:23:26 -05:00
Amin Yahyaabadi
95dbf77d79 function to create coreRenderProcessTestSuites
only when needed
2020-08-21 18:23:21 -05:00
DeeDeeG
c087fcfb49 CI: Use npm ci rather than npm install
`npm ci` doesn't try to reconcile package.json with package-lock.json,
nor with any existing packages in `node_modules`. `npm ci` simply
deletes `node_modules` and uses the packages from `package-lock.json`.

As a result, `npm ci` is much, much faster than `npm install`.
We should use it wherever possible.
2020-08-21 21:19:49 +03:00
DeeDeeG
8dc526bf24 CI: Use 'ubuntu-latest' to upload artifacts
This should be marginally faster. No need to run on Windows.
2020-08-21 21:19:49 +03:00
DeeDeeG
0ac3be7296 CI: Use 'ubuntu-latest' for GetReleaseVersion
Ubuntu is much faster than Windows at installing many small files,
such as during `git clone` and `npm install`.
2020-08-21 21:19:49 +03:00
DeeDeeG
f062a836e7 CI: Use forward-slashes in paths (cross-platform)
Backslashes ("\") can be interpreted as escape characters
on Unix (Linux, macOS). Replace with forward-slashes, "/",
which are interpreted the same (as directory separators) on all OSes,
at least in arguments to commands such as `cd` and `node`.
2020-08-21 21:19:49 +03:00
Musa Ibrahim
50a74a5e31
Merge pull request #21079 from atom/electron-6.1.12-bump-electron-packager-from-git
Electron 6 Take Two
2020-08-20 10:16:38 +01:00
Amin Yahyaabadi
b4909a9d8a
Merge branch 'master' into upstream_master 2020-08-17 01:20:28 -05:00
Amin Yahyaabadi
f0963c0e3f
improve comments 2020-08-16 22:38:37 -05:00
DeeDeeG
ef38967ee7 Merge remote-tracking branch 'atom-ide-community/master' into CI-GetReleaseVersion-template 2020-08-14 14:02:09 -04:00
DeeDeeG
cfd4a0b2ce CI: Drop old workaround, refactor script blocks
This old bug in the CI inexplicably went away at some point.
2020-08-12 21:55:15 -04:00
DeeDeeG
1ee74e5661 👕 Fix lints again 2020-08-12 21:55:15 -04:00
DeeDeeG
d5c8456e2a CI: Use more-compact "default var" syntax in JS
Co-authored-by: Amin Yahyaabadi <aminyahyaabadi74@gmail.com>
2020-08-12 21:55:15 -04:00
DeeDeeG
a24e93acf2 CI: Update displayNames for Windows jobs 2020-08-12 21:55:15 -04:00
DeeDeeG
d167180bba 👕 CI: Fix JS lints (prettier) 2020-08-12 21:55:15 -04:00
DeeDeeG
d77c2a20bf CI: Set appropriate default values for REPO vars
REPO_OWNER, MAIN_REPO, and NIGHTLY_RELEASE_REPO now default to
'atom', 'atom' and 'atom-nightly-releases', respectively.
2020-08-12 21:55:15 -04:00
DeeDeeG
72e9dc6a3c CI: Don't pass REPO variables via env: yml
Using the `env:` yaml key is not actually needed unless the variables
contain secret/sensitive information. (These varibales won't
have sensitive content, just a repo owner and some repo names).

These environment variables would expand to literally `${VAR_NAME}`,
rather than to an empty string, if not explicitly set in Azure DevOps.

This would make consuming the variables in JavaScript unnecessarily
awkward.

Instead, we can set reasonable defaults if the variables are falsy
(i.e. unset or null in our case), and otherwise override with what's
manually set in the environment variables.
2020-08-12 21:55:15 -04:00
DeeDeeG
9c138f8269 CI: Delete outdated comment in platforms/linux.yml
We no-longer run the Linux build in an old Ubuntu 14.04 "Trusty Tahr"
Docker container. We run builds directly in a virtualized Ubuntu 16.04
"Xenial Xerus" image now.
2020-08-12 21:55:15 -04:00
DeeDeeG
e0abca696d CI: Fix Windows job names
Also make sure "Release" job depends on successful Windows tests,
not just on the Windows build job, before/regardless of testing.
2020-08-12 21:54:39 -04:00
DeeDeeG
ecf9bdad87 CI: Add NightlyFlag parameter in GetReleaseVersion
We can use this to run `get-release-version.js`
with the `--nightly` flag on the "Atom Nightly" pipeline.
2020-08-12 15:43:16 -04:00
sadick254
0b541e9120 Show approriate error when running test without building 2020-08-12 21:02:47 +03:00
Mazen Elkashef
212081ea45
Merge pull request #20212 from sharedprophet/support-semanticolor
Support semanticolor
2020-08-11 00:12:49 -05:00
DeeDeeG
dc991c68fe CI: Move GetReleaseVersion to its own template 2020-08-04 13:13:31 -04:00
DeeDeeG
c731efb3b3 Merge branch 'electron-6-take-two-pr' into electron6 2020-07-31 00:16:20 -04:00
DeeDeeG
dd5d536bd5 CI: Use npm ci rather than npm install
`npm ci` doesn't try to reconcile package.json with package-lock.json,
nor with any existing packages in `node_modules`. `npm ci` simply
deletes `node_modules` and uses the packages from `package-lock.json`.

As a result, `npm ci` is much, much faster than `npm install`.
We should use it wherever possible.
2020-07-26 13:35:46 -04:00
DeeDeeG
3793939a20 CI: Use 'ubuntu-latest' to upload artifacts
This should be marginally faster. No need to run on Windows.
2020-07-25 18:35:34 -04:00
DeeDeeG
be55c397a7 CI: Use 'ubuntu-latest' for GetReleaseVersion
Ubuntu is much faster than Windows at installing many small files,
such as during `git clone` and `npm install`.
2020-07-25 18:32:18 -04:00
DeeDeeG
dea9e4ad0a CI: Use forward-slashes in paths (cross-platform)
Backslashes ("\") can be interpreted as escape characters
on Unix (Linux, macOS). Replace with forward-slashes, "/",
which are interpreted the same (as directory separators) on all OSes,
at least in arguments to commands such as `cd` and `node`.
2020-07-25 18:25:11 -04:00
aminya
3bdd637ff2 Use async.series
Revert b61475ffe4
2020-07-24 21:03:55 -05:00
aminya
c413a5626a collect console log in renderer tests
Print the output finally to ease diagnosing
2020-07-24 21:03:41 -05:00
aminya
6d50f3fc5a fix: rename windows job back to Windows 2020-07-19 12:54:17 -05:00
Amin Yahyaabadi
e45c2c53d4
Merge pull request #31 from atom-ide-community/windows_tests 2020-07-19 12:49:37 -05:00
aminya
44fa354c18 use new-item to not conflict mkdir on macos 2020-07-18 01:55:55 -05:00
aminya
b0853cb3bb fix bootstrap condition indentation 2020-07-18 01:05:48 -05:00
aminya
582b6d97e3 update message about finding a single application to run the tests 2020-07-17 22:28:19 -05:00
aminya
a1dab28e4e print the used testCommand for failed tests 2020-07-16 23:09:00 -05:00
aminya
d56fef6d9f macos: run core main tests in the build phase 2020-07-16 20:36:53 -05:00
aminya
c5af5781ab bootstrap in case cache misses 2020-07-16 19:55:58 -05:00
aminya
f55b7b8dce always upload atom windows.zip for x64 2020-07-16 19:55:58 -05:00
aminya
314a2b6a2b Run windows core main tests in the build step 2020-07-16 19:55:58 -05:00
aminya
92f4f7891e Run windows renderer tests in parallel 2020-07-16 19:55:58 -05:00
aminya
2fa0f6ebb9 test: use Azure format for printing 2020-07-16 19:55:58 -05:00
aminya
266910d059 warn before error reporting
Helps visually
2020-07-16 19:55:58 -05:00
aminya
b61475ffe4 run tests using async.parallel 2020-07-16 19:55:58 -05:00
aminya
bbfd0ec29a allow requesting parallel tests for all OS 2020-07-16 19:55:58 -05:00
aminya
038d6394a9 parallelize core tests 2020-07-16 19:55:58 -05:00
aminya
b99b8800fe run package tests in parallel for windows tests 2020-07-16 19:55:57 -05:00
Mazen El-Kashef
73c7a637a0 re-enable the bootstrap cache on macOS CI 2020-07-16 12:50:43 -05:00
Mazen El-Kashef
c6058e9600 local bootstrap 2020-07-16 11:33:36 -05:00
Mazen El-Kashef
4bdeb86c83 Merge branch 'master' into electron-6.1.12-bump-electron-packager-from-git 2020-07-16 11:18:24 -05:00
aminya
52de343cc5 create empty FileID for x86 2020-07-16 08:30:37 -05:00
aminya
0c956dd3e6 build: use esc for passing arguments 2020-07-16 06:01:44 -05:00
aminya
ef45a89f20 using templates in release-branch-build.yml 2020-07-16 00:43:15 -05:00
aminya
2d7a8df6f6 using templates in nightly-release.yml 2020-07-16 00:41:49 -05:00
aminya
5f5b93bbc8 set BUILD_ARCH in preparation
use Azure syntax for passing variables between the steps
2020-07-16 00:33:33 -05:00
aminya
7c63d85ccf using pwsh for setting FileID 2020-07-16 00:33:33 -05:00
aminya
3da79e3d5a test: using pwsh for managing env variables 2020-07-16 00:33:33 -05:00
aminya
e95af73aac bootstrap: using pwsh for managing env variables 2020-07-16 00:33:33 -05:00
aminya
225fb5bf52 build: using pwsh for managing env variables
Azure syntax for conditional env variables has issues
https://stackoverflow.com/questions/62890370/azure-pipeline-conditional-env-variable-based-on-os
2020-07-16 00:33:30 -05:00
aminya
b0aa6c678c using AGENT_OS directly 2020-07-16 00:33:16 -05:00
aminya
9a3112cb9d combine test for all OS
test: quote x86 runner
2020-07-16 00:32:20 -05:00
aminya
7101119162 combine build for all OS 2020-07-16 00:32:15 -05:00
aminya
e74543aa1e Remove linux container and use clang 9
pwsh is not detected inside the container, and Clang 5 is very old.
2020-07-13 23:48:34 -05:00
aminya
f113939865 Use pwsh 2020-07-13 23:48:30 -05:00
aminya
4e4a6e0b59 combine preparation for all OS 2020-07-13 19:51:04 -05:00
aminya
309e3c0801 Update bootstrap.yml
Co-Authored-By: deedeeg <deedeeg@users.noreply.github.com>
2020-07-13 19:48:45 -05:00
aminya
da793c9f7f download-unzip.yml 2020-07-13 19:36:55 -05:00
aminya
443c98ebc7 combine bootstrap for all OS 2020-07-13 19:36:50 -05:00
aminya
264fdd434f combine publish for all OS 2020-07-13 17:37:19 -05:00
aminya
91f302f545 linux-build.yml and linux-publish.yml 2020-07-13 15:45:48 -05:00
aminya
df3e80a88b linux-test.yml 2020-07-13 15:44:40 -05:00
aminya
cf0c4a7fe2 linux-bootstrap.yml 2020-07-13 15:42:18 -05:00
aminya
1fe38afb25 linux-preparation.yml 2020-07-13 15:42:18 -05:00
aminya
b5bf75997d macos-test.yml 2020-07-13 15:42:18 -05:00
aminya
bf06d17e45 macos-build.yml and macos-publish.yml 2020-07-13 15:42:10 -05:00
aminya
f0074f5465 macos-bootstrap.yml 2020-07-13 15:39:08 -05:00
aminya
ee3022b175 macos-preparation.yml 2020-07-13 15:39:07 -05:00
aminya
7a4c8c62fe windows-build.yml and windows-publish.yml 2020-07-13 15:39:07 -05:00
aminya
4d6855fe15 windows-bootstrap.yml 2020-07-13 15:39:07 -05:00
aminya
3127fa5d43 windows-test.yml 2020-07-13 14:53:13 -05:00
aminya
9f406e24a9 windows-preparation.yml 2020-07-13 14:46:15 -05:00
aminya
deabf83d44 move cache.yml to templates folder 2020-07-13 14:43:46 -05:00
Amin Yahyaabadi
2a0260d432
Merge pull request #36 from atom-ide-community/vsts-config-atom-ide-community-org 2020-07-11 00:27:14 -05:00
aminya
22858b9723 using cache template in the workflows 2020-07-10 23:39:22 -05:00
aminya
bcc9e1d11b cache template 2020-07-10 23:39:19 -05:00
DeeDeeG
9551fa5a2a vsts: Convert hard-coded REPO/OWNER strings to var
These can be set in Azure DevOps UI now.
2020-07-10 23:23:17 -04:00
DeeDeeG
0666ac7f66 vsts: Set REPO/OWNER consts from DevOps env vars
Still hard-coded in the YAML, but set up so the change required
to make them reconfigurable variables is minimal.
2020-07-10 23:23:05 -04:00
DeeDeeG
57dfd4add4 vsts: Don't hard-code repo owner or repo names
Replace strings with re-usable consts:
REPO_OWNER, MAIN_REPO and NIGHTLY_RELEASE_REPO,
so that these values can easily be updated/edited in fewer places.
2020-07-10 23:20:21 -04:00
DeeDeeG
fc4dc84e4f CI: Use Cache@2 task in place of Lighthouse 2020-07-10 20:28:00 -04:00
Amin Yahyaabadi
fa7dddabb3 make code-signing conditional 2020-07-10 20:28:00 -04:00
Amin Yahyaabadi
217cee16a8 Using windows-latest for vmImage 2020-07-10 20:28:00 -04:00
Mazen Elkashef
d840b89e62
Merge pull request #20856 from DeeDeeG/misc-python3-fixes
Miscellaneous python3-related updates and fixes
2020-07-10 14:01:20 -05:00
DeeDeeG
fef2de59a4 node-gyp 5.x still accepts Python 2.6 2020-07-10 11:58:17 -04:00
Amin Yahyaabadi
f79dd596ce no PR triggers on release builds 2020-07-09 23:14:12 -05:00
Mazen El-Kashef
bc952d5a3f Bump electron-packager@15.0.0 2020-07-03 12:09:24 -05:00
Mazen El-Kashef
b23b30d395 Bump electron-link@0.4.3 2020-07-03 12:05:21 -05:00
darangi
9140f6501b tests 2020-07-03 14:40:40 +01:00
darangi
f936328a73 update nightly job 2020-07-01 07:49:30 +01:00
darangi
b922fba627 missing files 2020-06-29 13:42:52 +01:00
darangi
bbf874fff9 added tests 2020-06-29 13:37:17 +01:00
darangi
f9a9e57d3a Revert "init"
This reverts commit 20d5d21775.
2020-06-26 15:59:54 +01:00
darangi
fb2654eaac Revert "removed unused code"
This reverts commit e79a71c6dc.
2020-06-26 15:48:26 +01:00
darangi
e79a71c6dc removed unused code 2020-06-24 16:28:08 +01:00
darangi
c3d16f02c5 changed remote 2020-06-24 01:31:12 +01:00
darangi
230df78ac3 added git config 2020-06-24 01:00:52 +01:00