Kevin Sawicki
864ab0c095
Use file path in save as dialog
...
Previously the dirname of the file path was used which caused the
save dialog to not be filled in with the current file name
Closes #1748
2014-03-12 18:41:50 -07:00
Brandon Tilley
8bba4d8add
Intelligently activate new items when the active item is closed
...
If the active item was the pane's first item, the second item (which is
the new first item) is activated. Otherwise, the item to the left of the
closed item is activated.
2014-01-20 14:34:02 -08:00
Kevin Sawicki
e0cf20cda9
Don't throw error when saving empty pane
...
Closes #1440
2014-01-17 15:24:55 -08:00
Nathan Sobo
926493f05c
Emit 'item-added' before setting the ::activeItem when adding first item
...
Fixes atom/tabs#11
2014-01-17 11:10:17 -07:00
Nathan Sobo
9af4b14716
Never allow PaneContainer::root to be null
2014-01-15 16:07:47 -07:00
Nathan Sobo
aed9f18457
Accivate the first added pane item
2014-01-15 16:07:47 -07:00
Nathan Sobo
012363a785
Null guard item in ::destroyActiveItem
2014-01-15 16:07:47 -07:00
Nathan Sobo
44331d0ba6
Fix issues splitting panes with DOM events
...
* ::copyActiveItem guards against not having an active item
* The Pane constructor removes undefined items from params.items
2014-01-15 16:07:47 -07:00
Nathan Sobo
fe7c5b4bc1
Only destroy an empty panes if 'core.destroyEmptyPanes' is true
2014-01-15 16:07:47 -07:00
Nathan Sobo
1c6564f7a5
Move non-focus serialization specs from pane-view-spec to pane-spec
2014-01-14 21:39:47 -07:00
Nathan Sobo
d9d28b5236
Move ::itemForUri specs from pane-view-spec to pane-spec
2014-01-14 20:39:13 -07:00
Nathan Sobo
8734eab8cb
💄 Give dummy pane items ::getUri and ::getPath methods
2014-01-14 20:38:07 -07:00
Nathan Sobo
9841a3588f
Move specs on PaneView::remove to Pane::destroy in pane-spec
2014-01-14 20:10:01 -07:00
Nathan Sobo
d8ddd52df8
Move ::activateItemAtIndex specs from pane-view-spec to pane-spec
2014-01-14 19:49:15 -07:00
Nathan Sobo
83696bb9c7
Move ::activateNext/PreviousItem specs from pane-view-spec to pane-spec
2014-01-14 19:46:12 -07:00
Nathan Sobo
243c4efe20
Move ::saveActiveItemAs specs from pane-view-spec to pane-spec
2014-01-14 19:43:09 -07:00
Nathan Sobo
22c65f2407
Move ::saveActiveItem specs from pane-view-spec to pane-spec
2014-01-14 19:41:00 -07:00
Nathan Sobo
e553fefc25
Add spec for Pane::destroyInactiveItems to pane-spec
2014-01-14 19:32:39 -07:00
Nathan Sobo
cf6fc22c87
Add spec for Pane::destroyItems to pane-spec
2014-01-14 19:31:13 -07:00
Nathan Sobo
a6d8f588c3
💄
2014-01-14 19:29:01 -07:00
Nathan Sobo
2ef74de0f8
Move ::moveItemToPane specs from pane-view-spec to pane-spec
2014-01-14 19:26:47 -07:00
Nathan Sobo
2ee6469b17
Move ::moveItem specs from pane-view-spec to pane-spec
2014-01-14 19:15:11 -07:00
Nathan Sobo
9977884a2c
Move ::destroyItem specs from pane-view-spec to pane-spec
2014-01-14 19:12:27 -07:00
Nathan Sobo
c331723c55
Move ::activateItem specs from pane-view-spec to pane-spec
2014-01-14 19:12:26 -07:00
Nathan Sobo
6ef6fb77f9
Rename pane-*-model specs
2014-01-13 17:22:02 -07:00
Nathan Sobo
4f604ced3c
Rename Pane to PaneView
2014-01-13 13:46:22 -07:00
Nathan Sobo
b438b311f3
Rename showItem methods to activateItem
...
These methods set the *active* item, so the verb activate provides a
clearer correspondence. We could change the noun to "shown" item, but
that's awkward and having both active panes and active items is a nice
correspondence in terminology.
2014-01-12 17:40:57 -07:00
Nathan Sobo
561e31c0c5
Remove ::removeItemAtIndex and make ::removeItem private
...
Call ::destroyItem or just destroy the item directly (it should emit the
'destroyed' event)
2014-01-12 17:25:51 -07:00
Nathan Sobo
28b085be1c
Rename ::makeActive to ::activate and focus panes when they're activated
2014-01-11 20:48:01 -07:00
Nathan Sobo
47870a1214
Remove views (rather than detaching) if Pane::destroyItem is called
2014-01-10 13:35:18 -07:00
Nathan Sobo
4b0d22917b
Trust CSS to perform layout now that we've switched to flexbox
...
The behavior of flexbox is actually slightly different in that it
divides space evenly among the immediate children of a row or column
rather than accounting for all splits. But it's actually not that big
a deal.
2014-01-10 12:12:44 -07:00
probablycorey
99a67ca1ab
Remove focused spec
2014-01-08 16:37:57 -08:00
probablycorey
196942d126
Rename .row and .column in pane specs
2014-01-08 16:31:56 -08:00
Corey Johnson & Nathan Sobo
25c099f3a2
Serialize the items and activeItem via PaneModel
...
This necessitates setting the ::activeView based on the model's
::activeItem instead of doing it in ::showItem.
2014-01-07 17:23:29 -07:00
Nathan Sobo
0bbd9630f5
Fix pane spec
2014-01-03 17:50:46 -07:00
Nathan Sobo
c6770aa83e
Merge remote-tracking branch 'origin/master' into ns-remove-telepath-from-core
...
Conflicts:
package.json
src/pane.coffee
2014-01-03 17:46:45 -07:00
Nathan Sobo
bc65137911
Remove telepath from Project, WorkspaceView, and Pane*
2014-01-03 16:23:23 -07:00
Nathan Sobo
42b203d502
🚱 Fix mini editor leak
...
Previously, we were overriding Editor::destroy, which is now provided
by telepath. Since the real destroy wasn't being called, we were failing
to remove editors associated with mini editor views.
2013-12-18 17:05:34 -07:00
Nathan Sobo
611559ecd6
Fix pane spec. Fully test serialization lifecycle via ::testPersistence.
2013-12-17 17:05:54 -07:00
Ben Ogle
e8c5027026
💄 Update specs to use ::function() format
2013-12-13 10:28:38 -08:00
Ben Ogle
a25812dca7
Move cmd-s and cmd-S to workspaceView
2013-12-12 17:50:15 -08:00
Ben Ogle
1f9a7599b7
cmd-w works anywhere in the editor
2013-12-12 17:50:15 -08:00
probablycorey
f414c0955b
Specs don't prompt to save editors by default.
2013-12-12 10:35:11 -08:00
probablycorey
115203cbd2
Update spec description
2013-12-11 14:48:12 -08:00
probablycorey
4bfcdf4d5b
Remove unmodified editors from pane when the buffer is deleted
2013-12-10 17:08:07 -08:00
Nathan Sobo
a4d2b4d21a
Make TokenizedBuffer a telepath.Model subclass
...
There's a bunch of improvised code to make this work right now because
of the circularity of this refactoring. It will stabilize over time.
2013-12-07 02:25:47 -08:00
Nathan Sobo
b61654b52f
Upgrade to telepath 0.61.0
...
This version adds a bunch of reactive primitives and ensures we destroy
documents when they are no longer referenced.
2013-12-06 21:55:57 -08:00
Kevin Sawicki
f1e768767e
Rename EditorView::activeEditSession to editor
2013-11-26 19:35:16 -08:00
Kevin Sawicki
3ce6176313
Rename rootView to workspaceView
2013-11-26 11:02:53 -08:00
Kevin Sawicki
7f039b3383
Update confirmSync references in specs
2013-11-22 15:09:47 -08:00
