Commit Graph

12522 Commits

Author SHA1 Message Date
Nathan Sobo
578ca8b197 Don't update highlighted gutter lines unless the editor is alive 2014-01-10 17:56:04 -07:00
probablycorey
5e674fe29e Add commonly used Editor methods to Editor View
Mini-editors use these methods very often, but really we shouldn't need to do
this.
2014-01-10 16:38:36 -08:00
Nathan Sobo
72fe586101 Remove the concept of focus from the model 2014-01-10 17:27:28 -07:00
Kevin Sawicki
82d5577bdc Upgrade to find-and-replace@0.73.0 2014-01-10 15:59:51 -08:00
Ben Ogle
c703cf2050 Upgrade to find-and-replace@0.72.0 2014-01-10 15:38:04 -08:00
probablycorey
c19c8c5341 Fix core specs 2014-01-10 15:32:59 -08:00
probablycorey
32b5592475 Fix EditorView spec 2014-01-10 15:32:36 -08:00
Ben Ogle
993f1ac2d6 Update status-bar@0.31.0 2014-01-10 15:31:35 -08:00
probablycorey
21b40acdf1 Remove delegate methods from EditorView 2014-01-10 15:31:33 -08:00
Nathan Sobo
ddf7c04e66 Use -> arrows on methods moved to the model 2014-01-10 15:51:27 -07:00
Nathan Sobo
c127237cc6 Upgrade tabs to 0.17.0 so they unsubscribe when the pane is removed 2014-01-10 15:49:46 -07:00
Nathan Sobo
9694d255f0 Simplify item removal
- Move emitting of item removal event into ::removeItemAtIndex. Pass a
destroying param instead of setting state.

- Destroy the pane if ::items is empty at the in the item removal
method, rather than with a condition. This gives the item removal event
a chance to fire first.
2014-01-10 15:48:08 -07:00
Kevin Sawicki
81b4803d56 Upgrade to tree-view@0.59.0 2014-01-10 14:44:22 -08:00
Kevin Sawicki
893e9873a1 Upgrade to exception-reporting@0.11.0 2014-01-10 14:34:51 -08:00
Nathan Sobo
23e805fe9e Remove assertion for impossible situation
We were testing the behavior of returning the active pane by removing
the active class from its view. But "active" is a model-level concept
now, so this assertion makes no sense.
2014-01-10 15:28:55 -07:00
Kevin Sawicki
43257de7cd Upgrade to metrics@0.21.0 2014-01-10 14:08:05 -08:00
Nathan Sobo
c7fded0d7f Only emit 'pane:removed' events if the pane is actually destroyed
The pane may only be detached temporarily during splitting/unsplitting
2014-01-10 15:04:51 -07:00
Nathan Sobo
284d823ad5 Tighten up search for parent pane
The introduction of the .flexbox-redraw-hack required the query to be
loosened, but I went too far. We don't want to return a pane for mini
editors that happen to be nested on another view that's inside a pane.
2014-01-10 14:36:07 -07:00
Kevin Sawicki
164a121de9 Upgrade to snippets@0.18.0 2014-01-10 13:02:19 -08:00
Kevin Sawicki
50ab49aedb Upgrade to first-mate@0.17.0 2014-01-10 12:57:35 -08:00
Kevin Sawicki
a127d3c4eb Upgrade to fuzzaldrin@0.6.0 2014-01-10 12:57:12 -08:00
Kevin Sawicki
cac5c6e3a5 Merge pull request #1403 from atom/ks-faster-keymaps
Speed up keymap loading
2014-01-10 12:44:27 -08:00
Nathan Sobo
1ee783fdb9 Base PaneContainer::getActivePane on the model's active pane 2014-01-10 13:44:02 -07:00
Nathan Sobo
47870a1214 Remove views (rather than detaching) if Pane::destroyItem is called 2014-01-10 13:35:18 -07:00
Nathan Sobo
7801d8562f Upgrade archive-view to 0.19.0 for .flexbox-repaint-hack fix 2014-01-10 13:08:47 -07:00
Nathan Sobo
104271861c Upgrade markdown-preview to 0.24.0 for .flexbox-repaint-hack fix 2014-01-10 13:07:39 -07:00
Kevin Sawicki
de25b8ea37 Cache specificities 2014-01-10 12:01:56 -08:00
Kevin Sawicki
ba9f353c4a Use precompile pattern when available 2014-01-10 11:43:45 -08:00
Nathan Sobo
7665cd1a6a When a pane view is removed in anyway, make sure its model is destroyed 2014-01-10 12:35:12 -07:00
Kevin Sawicki
c39d8d9aa7 Precompile pegjs parsers 2014-01-10 11:32:40 -08:00
Nathan Sobo
4b0d22917b Trust CSS to perform layout now that we've switched to flexbox
The behavior of flexbox is actually slightly different in that it
divides space evenly among the immediate children of a row or column
rather than accounting for all splits. But it's actually not that big
a deal.
2014-01-10 12:12:44 -07:00
Nathan Sobo
720b2ad47d Upgrade to serializable 0.3.0 to handle undefined states 2014-01-10 12:11:19 -07:00
Nathan Sobo
d34327a667 Remove the EditorView when Editor is destroyed 2014-01-10 11:56:27 -07:00
Nathan Sobo
d2146f9b2e Emit 'pane:removed' event in container when last pane is removed
Doing it in the pane view is awkward because the view may have already
been detached.
2014-01-10 11:45:08 -07:00
Nathan Sobo
732d36af28 Null guard container in Pane::makeActive
Panes can exist outside of containers, albeit only briefly. If
::makeActive is called when the pane is in this state, consider it a
no-op.
2014-01-10 11:37:42 -07:00
Nathan Sobo
edfc86f153 Make PaneContainer::getActivePaneItem retrieve it from the model 2014-01-10 11:34:26 -07:00
Nathan Sobo
339e30d973 Account for pane axis class name changes in pane-container-spec 2014-01-10 11:25:02 -07:00
Nathan Sobo
5e1e092650 When the last pane is destroyed, null out the root and active pane 2014-01-10 11:22:19 -07:00
Nathan Sobo
c69febd44d Preserve the active pane across serialization 2014-01-10 11:22:02 -07:00
Nathan Sobo
a9d7564f3e Account for the .flexbox-repaint-hack in WorkspaceView::getEditorViews 2014-01-10 11:21:10 -07:00
Nathan Sobo
a0b733b53d Skip the flexbox-repaint-hack when seeking editor pane with ::parents 2014-01-10 11:20:12 -07:00
Kevin Sawicki
8cb565ad2a Add parseKeystroke function 2014-01-10 10:10:08 -08:00
Kevin Sawicki
32158711ce Upgrade to pegjs@0.8.0 2014-01-10 10:09:47 -08:00
Kevin Sawicki
e099f00739 💄 Use unless instead of if not 2014-01-10 09:57:11 -08:00
Kevin Sawicki
e707ab5441 Remove unused require 2014-01-10 09:52:30 -08:00
Kevin Sawicki
3b7f1467e1 Upgrade to background-tips@0.4.0 2014-01-10 09:42:09 -08:00
Nathan Sobo
1c7eef89c3 Merge branch 'master' into ns-pane-splits-with-models 2014-01-10 10:40:52 -07:00
Kevin Sawicki
4fc1f5b248 Upgrade to find-and-replace@0.71.0 2014-01-10 09:34:23 -08:00
Nathan Sobo
6eacfa7077 Call Range::toString, not ::inspect in DisplayBufferMarker::inspect 2014-01-09 19:04:52 -07:00
Nathan Sobo
9aefafb831 Use PaneContainerModel::$activePaneItem for 'active-item-changed' events
Yay behaviors
2014-01-09 18:58:01 -07:00