Commit Graph

40 Commits

Author SHA1 Message Date
Kevin Sawicki
4acd5951f5 Use ATOM_HOME for nohup.out location 2015-02-04 10:35:57 -08:00
Dan Wyand
3b13e4f502 🍎 try ~/Applications before using mdfind 2015-01-21 23:01:37 -05:00
Paul Wagland
eb6ce74a12 Use xargs -0 instead of sed, as this is easier to understand.
Fixed atom/atom#4337
Fixes atom/atom#4336
2014-12-05 23:53:07 +01:00
Paul Wagland
5da4846fff Fix atom.sh when running from directory with space
Deal with ATOM_PATH having a space by proper quoting, and not passing
the directory name to dirname.

Fixes atom/atom#4336
2014-11-28 00:37:21 +01:00
Cheng Zhao
6a58f6054a Pass $PATH by command line 2014-11-05 12:11:42 +08:00
Miguel Lloreda
bcbf01c852 💄 Remove unnecessary conditional
`mkdir -p` is an idempotent operation.
2014-10-07 21:39:36 -04:00
Timo Sand
8932eba0bf Add matching of Atom.app more stable
I have this file on my Mac `/Users/timosand/Library/Application Support/com.github.atom.ShipIt/update.85PyXs3/Atom.app` and my `mdfind` returns it. It seems to be a common one, so I thought to remove it from the list to be sure that it selects the right Atom.app
2014-09-19 07:48:21 +03:00
Kevin Sawicki
cc27f2dbb6 Remove spaces around = 2014-07-24 09:35:44 -07:00
Kevin Sawicki
54ce852be4 Store nohup.out in ~/.atom
Storing it in the temp directory can lead to permissions issues when
Atom is run by multiple users.

Closes #3056
2014-07-24 09:27:47 -07:00
Pritam Baral
7627e0b0f0 Minor fix + Remove last references to /tmp 2014-05-19 23:57:48 +05:30
Corey Johnson
dbe15f7dda Merge pull request #2142 from aureliojargas/patch-1
Remove unused 's' option from getopts
2014-05-10 15:53:21 -07:00
Aurelio Jargas
2b73dff0f4 Use $(...) for command substitution, not backticks
Currently both \`...\` and `$(...)` are used for command substitution. It's better to chose just one and stick to it, to avoid confusion.

Some arguments favoring `$(...)`:

* **Easier to read.** The backtick is easily confused with apostrophes and quotes.
* **Easier to nest.** Nesting backticks commands is an escaping nightmare. Using parenthesis is natural: `$(foo $(bar))`
2014-05-10 09:15:53 -03:00
Aurelio Jargas
adf0ff0a67 Remove unused 's' option from getopts
This option is not handled by the next `case` command.
2014-05-10 08:41:30 -03:00
Thomas Buckley-Houston
1ea54f8c92 🐧 If atom.sh has non-zero exit show errors captured by nohup. Refers to #1814 2014-05-06 17:21:01 +01:00
Cheng Zhao
ae1d3b1e80 🐧 Search atom from installed position. 2014-03-25 15:40:43 +08:00
Cheng Zhao
5151faea3d Use unix style install. 2014-03-25 15:40:43 +08:00
Cheng Zhao
19ab197bc1 🐧 Make atom.sh work. 2014-03-18 16:27:43 +08:00
Corey Johnson
96e96c3c7f Merge pull request #1757 from atom/cj-shhhhh
Don't show error messages for version and help cli options
2014-03-13 17:42:19 -07:00
probablycorey
15c51b4417 Redirect help and version stderr to /dev/null
Closes #1580 based on @zcbenz's suggestion.
2014-03-13 15:00:24 -07:00
Kevin Sawicki
31ecd39f08 Don't echo app location 2014-03-13 12:41:08 -07:00
probablycorey
1cbaf8d1f5 Added comments because shell scripts can be confusing 2014-03-13 11:14:26 -07:00
probablycorey
2fd71f2fa8 Use mdfind to locate Atom.app if it isn't in /Applications 2014-03-13 10:57:55 -07:00
probablycorey
54907455fe Add ~/Desktop 2014-03-12 17:44:00 -07:00
probablycorey
ba8ab21a0d Search for the Atom app in the usual locations when using the atom cli
Sorta closes #1595
2014-03-12 17:10:36 -07:00
Kevin Sawicki
bd3dc453ef Wrap command line arguments in quotes
Closes #1639
2014-03-11 13:35:19 -07:00
Kevin Sawicki
e8c399428c Set ATOM_PATH env var when launching specs 2013-10-14 10:33:37 -07:00
Matt Colyer
64e8c978e4 Return proper return code from atom.sh
Also improve the test failure message returned by apm.
2013-10-07 14:28:13 -07:00
probablycorey
b92b6e689d Rearrange command line option string
I apologize, but I could not resist rearranging the command line 
options to spell "WTF VHS"
2013-10-03 10:27:26 -07:00
Matt Colyer
fad7c9586c Update older (and incorrect) flag in atom.sh 2013-10-02 13:10:10 -07:00
Matt Colyer
62b7599bea Add spec-directory command line option 2013-10-02 12:17:42 -07:00
Kevin Sawicki
c27103db8a Expect output when -t/--test flag is specified 2013-08-28 12:54:16 -07:00
probablycorey
204de3ac24 Support long version for foreground command 2013-08-21 16:19:37 -07:00
probablycorey
986a9ce0a0 Add cli option to keep the browser process running in the foreground 2013-08-21 16:19:37 -07:00
Matt Colyer
82882624ce Handle atom standard output from atom.sh 2013-08-09 10:23:05 -07:00
Kevin Sawicki
718175eb34 Make atom.sh executable 2013-05-15 10:29:27 -07:00
probablycorey
6ee24cc50e 💄 2013-04-29 12:10:40 -07:00
probablycorey
599328cb9c Better error message when Atom.app is not found 2013-04-17 16:26:13 -07:00
probablycorey
9b8abe3552 If Atom.app doesn't exist, wait 5 seconds and try again.
Closes #351

When Sparkle updates Atom, it deletes the app and replaces it. This
causes the `atom` cli to fail when called within this brief time
period. This gives `atom` a five second grace period if it is not
found.
2013-04-17 16:25:42 -07:00
Corey Johnson & Kevin Sawicki
b874f95eb1 Launch Atom with full path to .app 2013-02-25 16:11:13 -08:00
Kevin Sawicki
d35c871e17 Install atom executable during window.startup()
Previously this was done during `rake install`.

Also default to `~/github/atom` as the default resource path
when no `--resource-path` argument is specified.  This argument
will now be required when running in dev mode if the repository
is not at the default location.

Closes #300
2013-02-22 21:19:34 -08:00