Commit Graph

194 Commits

Author SHA1 Message Date
Corey Johnson
d2899fa58a Folds handle change events 2012-05-21 15:01:14 -07:00
Corey Johnson
8af289dde1 Merge branch 'fold-simplification' of github.com:github/atom into fold-simplification 2012-05-21 13:45:07 -07:00
Nathan Sobo
9beff8edbb Un-F 2012-05-21 13:36:19 -07:00
Nathan Sobo
4f60135d81 Remove random indent that was causing editor spec not to run 2012-05-21 13:35:54 -07:00
Corey Johnson
d7e1ffcdf2 Update render spec to new version of Renderer.createFold 2012-05-21 10:29:48 -07:00
Nathan Sobo
a57ccc1b7f Remove specs that don't matter anymore w/ linewise folding 2012-05-18 20:59:58 -06:00
Nathan Sobo
c491d92437 Nested folds can start at the same row as the fold that contains them
...still need to test destroying the outer fold though.
2012-05-18 20:14:05 -06:00
Nathan Sobo
9757786257 Add passing spec for nested folds (that start on different rows) 2012-05-18 19:39:23 -06:00
Nathan Sobo
03ae0bbbb6 Guts on the floor, but 2 line-wise fold specs are passing and the renderer is getting there 2012-05-18 19:22:56 -06:00
Corey Johnson & Nathan Sobo
39e02bbf9f wip: what nathan and corey did 2012-05-18 15:15:44 -07:00
Corey Johnson & Nathan Sobo
4c92be669e Remove non-passing unneeded spec 2012-05-18 14:12:41 -07:00
Corey Johnson & Nathan Sobo
8e9db80b58 wip: another failing fold test 2012-05-18 11:59:54 -07:00
Corey Johnson & Nathan Sobo
20c9b61b91 Fix issue where creating a second fold on a wrapped line fragment caused a duplicate line to be rendered 2012-05-18 12:22:40 -06:00
Corey Johnson & Nathan Sobo
06d1f8a718 Create a failing fold spec 2012-05-17 17:20:17 -07:00
Corey Johnson & Nathan Sobo
608ccc38e8 Update rendered lines when buffer changes occur outside/straddling rendered region 2012-05-17 16:06:39 -07:00
Corey Johnson
857486bcf1 After buffer changes, remove any lines that are beyond the current last rendered screen row. 2012-05-17 10:34:54 -07:00
Corey Johnson
52fe580cf6 Test that inserting lines re-renders the gutter 2012-05-17 10:17:05 -07:00
Corey Johnson
0e09659d79 Gutter adjusts its width to account for the width of the last line number 2012-05-17 10:16:20 -07:00
Corey Johnson
7a82bf2679 💄 2012-05-17 08:49:03 -07:00
Nathan Sobo
5045d68be2 2012-05-16 14:47:09 -06:00
Nathan Sobo
a7b5f0c249 Un-F 2012-05-16 14:12:11 -06:00
Nathan Sobo
92395a9cfb Merge branch 'master' of github.com:github/atom
Conflicts:
	src/app/editor.coffee
2012-05-16 14:07:44 -06:00
Nathan Sobo
2d8ba3b1ee Use translate3d to scroll lines / gutter in attempt to improve repaint.
Also: Add custom scrollTop method to editor that manages all the custom optimizations we are doing around scrolling.
2012-05-16 13:47:59 -06:00
Corey Johnson
2c508f5a31 Fix tests
Certain tests resize the editor and expect the number of lines to adjust, this forces the test to meet that expectation.
2012-05-16 11:30:25 -07:00
Corey Johnson
3614ad6e76 Update lines when the font size changes 2012-05-16 10:58:19 -07:00
Corey Johnson
399fc71b3c Make Atom SpacePen view's default to empty object (where needed) 2012-05-16 10:35:50 -07:00
Corey Johnson
484b55800a Call updateLines when lines are removed from buffer 2012-05-15 14:27:22 -07:00
Corey Johnson
54a3823606 Buffer change events update the @lastRenderedScreenRow 2012-05-15 12:29:59 -07:00
Corey Johnson
6b3664a040 Vertical scrollbar height is updated when switching buffers 2012-05-15 10:02:56 -07:00
Corey Johnson & Nathan Sobo
9079bcb103 Meta-a selects everything 2012-05-14 16:18:37 -06:00
Corey Johnson & Nathan Sobo
513e15e369 Make editor tall so that all line numbers are rendered for this test 2012-05-14 15:42:51 -06:00
Corey Johnson
b35a2502c6 Gutter line numbers are rendered similarly to the scroll view's lines 2012-05-14 12:32:53 -07:00
Corey Johnson
5e4aef95d0 Only visible lines numbers are rendered by the gutter 2012-05-14 09:53:58 -07:00
Nathan Sobo
0c89db37a5 Editor scroll position is correctly restored on refresh.
When we attach the editor we need to scroll it to the correct position before rendering lines. But to scroll it to the right position, the lines container and the scrollbar need to be assigned a height that allows them to scroll. So now we call `prepareForVerticalScrolling` on attach, then set the scroll position based on the edit session and render the visible lines.
2012-05-11 17:51:47 -06:00
Nathan Sobo
96d92be230 Rename Editor.scrollbar to verticalScrollbar for clarity 2012-05-11 13:45:57 -06:00
Nathan Sobo
b64e9ae10f Rename Editor.scroller to Editor.scrollView to distinguish it from the vertical scrollbar.
Also, base edit session scroll top on the scrollbar instead of the scrollView.
2012-05-11 13:42:57 -06:00
Corey Johnson & Nathan Sobo
9427c82084 WIP: Getting specs passing with new stand-in vertical scrollbar 2012-05-11 11:52:03 -06:00
Corey Johnson & Nathan Sobo
02da32d372 Update visible lines when scrolling up 2012-05-10 16:11:05 -06:00
Corey Johnson & Nathan Sobo
43ac7edf0f Scrolling to bottom renders correct lines
When we scroll more than a single screen's worth of lines, the new first visible screen row ends up exceeding the previous last rendered screen row, so we need to use the maximum of the two when deciding which new rows to render.
2012-05-10 15:15:34 -06:00
Corey Johnson & Nathan Sobo
c5d2616155 WIP: Removing lines that are no longer visible 2012-05-10 12:08:58 -07:00
Corey Johnson & Nathan Sobo
22548141d7 Editor updates lines when it is resized 2012-05-10 11:14:03 -07:00
Corey Johnson & Nathan Sobo
f6e9d99865 Editor only does not pre-build lines, it only builds them when they are visible on the screen 2012-05-10 10:40:16 -07:00
Corey Johnson & Nathan Sobo
6eda0d345b 💄 2012-05-10 08:58:38 -07:00
Nathan Sobo
1e2d333a15 WIP: working on only rendering on-screen lines. still half-baked. 2012-05-10 09:27:04 -06:00
Corey Johnson & Nathan Sobo
5ae40a3cb8 Editor only renders lines when it is attached to the DOM 2012-05-09 19:19:54 -06:00
Nathan Sobo
5b7ea95a11 Meta+ and meta- change the editor font size 2012-05-09 10:57:25 -06:00
Nathan Sobo
f2f44b9ab6 Can match key patterns with the '-' character
Add a parser to parse keystroke patterns instead of splitting on '-' with a regex
2012-05-09 10:56:31 -06:00
Nathan Sobo
8b1ac28b89 Editor font sizes can be adjusted with RootView.proto.setFontSize 2012-05-09 08:34:08 -06:00
Nathan Sobo
6dda27e771 Go ahead and build a RootView in the editor spec 2012-05-08 20:20:56 -06:00
Corey Johnson & Nathan Sobo
4665321b37 Project.getFilePaths does not traverse into ignored directories 2012-05-08 17:59:38 -07:00