Commit Graph

21 Commits

Author SHA1 Message Date
Segev Finer
6c9387d276 Add tests for recognizing Windows cmd or powershell environment in updateProcessEnv 2018-02-22 13:34:08 +02:00
Ash Wilson
dc9fe25255
Wrap temp.cleanupSync() calls in try-catch blocks 2017-08-04 14:18:43 -04:00
TiagoDanin
c5c3f5cb01 Replace "osx" to "macOS" 2016-12-04 15:28:43 -03:00
Damien Guard
3fd1dbdce3
Clean up temporary files when running specs 2016-12-01 10:48:45 -08:00
Damien Guard
48b16a4633
Environment patching tests do not work on Win32 2016-11-29 16:55:14 -08:00
Joe Fitzgerald
f73aa46cef
Fix lint errors 2016-11-14 17:09:01 -07:00
Joe Fitzgerald
3123a92687
🎨 Fix spec, cleanup 2016-11-14 16:29:13 -07:00
Joe Fitzgerald
d0a011e93a
Fix specs, rename cp > child_process 2016-11-14 16:23:10 -07:00
Antonio Scandurra
e34bc188d0 Make updateProcessEnv asynchronous
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-11-11 18:39:18 +01:00
Joe Fitzgerald
d4d05244b3 ATOM_SUPPRESS_ENV_PATCHING > ATOM_DISABLE_SHELLING_OUT_FOR_ENVIRONMENT 2016-09-08 12:24:33 -06:00
Joe Fitzgerald
3c7a89ec93 Add Spec To Validate Updating An Existing Env Var
- 🎨 Update spec description to more accurately reflect the intent
2016-09-08 11:17:42 -06:00
Joe Fitzgerald
b321ab6a38 Prevent Regression For Common Shells
- Fix lint warnings
2016-09-08 10:56:01 -06:00
Joe Fitzgerald
10270609d8 Use ATOM_SUPPRESS_ENV_PATCHING Environment Variable
- Stop using shell whitelist
2016-09-08 10:56:01 -06:00
Joe Fitzgerald
c570e14420 Get Environment From Shell On Linux 2016-09-08 10:56:01 -06:00
Max Brunsfeld
8018dc9d57 Allow ATOM_HOME to be reassigned if the new value is valid 2016-08-15 17:05:18 -07:00
Joe Fitzgerald
f529ebb237 🎨 Update Describe / It Descriptions 2016-08-11 17:08:28 -06:00
Joe Fitzgerald
485cb71be7 🎨 envShouldBePatched > shouldGetEnvFromShell 2016-08-11 17:07:21 -06:00
Joe Fitzgerald
9ec63a8ffc 🎨 Cleanup
* shellShouldBePatched > envShouldBePatched
2016-08-11 16:45:19 -06:00
Joe Fitzgerald
b7a48967fa Fix Regression In #12317 For zsh
In Atom 1.7 and 1.8, the environment would be patched for users of the zsh shell on OS X. A whitelist of shells was established in #12317, which is extended here.
2016-08-11 12:45:02 -06:00
Max Brunsfeld
29096bde31 Don't update ATOM_HOME env var after launch
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-08-09 14:38:19 -07:00
Max Brunsfeld
d21c6f1482 Rename environment-helpers-spec -> update-process-env-spec 2016-08-09 14:26:51 -07:00