Corey Johnson & Nathan Sobo
dd7fff4522
WIP: Adding specs for various fold corner cases… think we still have some issues and gutter updates are failing.
2012-05-23 11:03:33 -07:00
Corey Johnson & Nathan Sobo
04f4a9a765
WIP: Handle buffer change events correctly with respect to folded lines
...
We're handling changes that straddle the start row and are in the middle of the fold, but we're still screwing up when the old range straddles the end row.
2012-05-22 19:02:13 -07:00
Corey Johnson
7b4ebcdd42
Changes inside a fold correctly change the start/end row
2012-05-22 12:09:37 -07:00
Corey Johnson
a7d43c2cca
meta-alt-u unfolds lines at cursor
2012-05-22 09:38:14 -07:00
Corey Johnson
50146ce3ae
Merge branch 'fold-simplification' of github.com:github/atom into fold-simplification
2012-05-22 08:52:30 -07:00
Nathan Sobo
74008ab329
Fold placeholder lines are treated as if they're empty
2012-05-21 19:20:18 -07:00
Nathan Sobo
3f4c7deb30
Nuke stray call to Editor.logLines
2012-05-21 19:00:02 -07:00
Nathan Sobo
72f1874c5b
Nuke more old fold specs
2012-05-21 18:55:05 -07:00
Nathan Sobo
031c04b888
Clean up remaining position translation spec for folds. It still has one legit failure though.
2012-05-21 18:48:28 -07:00
Nathan Sobo
f3cada9e20
Nuke some fold tests that don't matter anymore
2012-05-21 18:46:16 -07:00
Nathan Sobo
581998f94b
Oh, un-F
2012-05-21 18:35:51 -07:00
Nathan Sobo
7744d6087b
Merge branch 'fold-simplification' of github.com:github/atom into fold-simplification
2012-05-21 17:56:16 -07:00
Nathan Sobo
f39891b912
Folds are destroyed when their placeholder line is clicked
2012-05-21 17:55:58 -07:00
Corey Johnson
b4e8157172
💄
2012-05-21 15:27:36 -07:00
Corey Johnson
a5656400aa
Merge branch 'fold-simplification' of github.com:github/atom into fold-simplification
2012-05-21 15:01:23 -07:00
Corey Johnson
d2899fa58a
Folds handle change events
2012-05-21 15:01:14 -07:00
Nathan Sobo
7ad5830521
Convert failing specs to linewise code folding
2012-05-21 14:18:00 -07:00
Corey Johnson
8af289dde1
Merge branch 'fold-simplification' of github.com:github/atom into fold-simplification
2012-05-21 13:45:07 -07:00
Nathan Sobo
9beff8edbb
Un-F
2012-05-21 13:36:19 -07:00
Nathan Sobo
4f60135d81
Remove random indent that was causing editor spec not to run
2012-05-21 13:35:54 -07:00
Corey Johnson
d7e1ffcdf2
Update render spec to new version of Renderer.createFold
2012-05-21 10:29:48 -07:00
Nathan Sobo
a57ccc1b7f
Remove specs that don't matter anymore w/ linewise folding
2012-05-18 20:59:58 -06:00
Nathan Sobo
c491d92437
Nested folds can start at the same row as the fold that contains them
...
...still need to test destroying the outer fold though.
2012-05-18 20:14:05 -06:00
Nathan Sobo
9757786257
Add passing spec for nested folds (that start on different rows)
2012-05-18 19:39:23 -06:00
Nathan Sobo
03ae0bbbb6
Guts on the floor, but 2 line-wise fold specs are passing and the renderer is getting there
2012-05-18 19:22:56 -06:00
Corey Johnson & Nathan Sobo
39e02bbf9f
wip: what nathan and corey did
2012-05-18 15:15:44 -07:00
Corey Johnson & Nathan Sobo
4c92be669e
Remove non-passing unneeded spec
2012-05-18 14:12:41 -07:00
Corey Johnson & Nathan Sobo
8e9db80b58
wip: another failing fold test
2012-05-18 11:59:54 -07:00
Corey Johnson & Nathan Sobo
20c9b61b91
Fix issue where creating a second fold on a wrapped line fragment caused a duplicate line to be rendered
2012-05-18 12:22:40 -06:00
Corey Johnson & Nathan Sobo
06d1f8a718
Create a failing fold spec
2012-05-17 17:20:17 -07:00
Corey Johnson & Nathan Sobo
608ccc38e8
Update rendered lines when buffer changes occur outside/straddling rendered region
2012-05-17 16:06:39 -07:00
Corey Johnson
857486bcf1
After buffer changes, remove any lines that are beyond the current last rendered screen row.
2012-05-17 10:34:54 -07:00
Corey Johnson
52fe580cf6
Test that inserting lines re-renders the gutter
2012-05-17 10:17:05 -07:00
Corey Johnson
0e09659d79
Gutter adjusts its width to account for the width of the last line number
2012-05-17 10:16:20 -07:00
Corey Johnson
7a82bf2679
💄
2012-05-17 08:49:03 -07:00
Nathan Sobo
5045d68be2
2012-05-16 14:47:09 -06:00
Nathan Sobo
a7b5f0c249
Un-F
2012-05-16 14:12:11 -06:00
Nathan Sobo
92395a9cfb
Merge branch 'master' of github.com:github/atom
...
Conflicts:
src/app/editor.coffee
2012-05-16 14:07:44 -06:00
Nathan Sobo
2d8ba3b1ee
Use translate3d to scroll lines / gutter in attempt to improve repaint.
...
Also: Add custom scrollTop method to editor that manages all the custom optimizations we are doing around scrolling.
2012-05-16 13:47:59 -06:00
Corey Johnson
2c508f5a31
Fix tests
...
Certain tests resize the editor and expect the number of lines to adjust, this forces the test to meet that expectation.
2012-05-16 11:30:25 -07:00
Corey Johnson
3614ad6e76
Update lines when the font size changes
2012-05-16 10:58:19 -07:00
Corey Johnson
399fc71b3c
Make Atom SpacePen view's default to empty object (where needed)
2012-05-16 10:35:50 -07:00
Corey Johnson
484b55800a
Call updateLines when lines are removed from buffer
2012-05-15 14:27:22 -07:00
Corey Johnson
54a3823606
Buffer change events update the @lastRenderedScreenRow
2012-05-15 12:29:59 -07:00
Corey Johnson
6b3664a040
Vertical scrollbar height is updated when switching buffers
2012-05-15 10:02:56 -07:00
Corey Johnson & Nathan Sobo
9079bcb103
Meta-a selects everything
2012-05-14 16:18:37 -06:00
Corey Johnson & Nathan Sobo
513e15e369
Make editor tall so that all line numbers are rendered for this test
2012-05-14 15:42:51 -06:00
Corey Johnson
b35a2502c6
Gutter line numbers are rendered similarly to the scroll view's lines
2012-05-14 12:32:53 -07:00
Corey Johnson
5e4aef95d0
Only visible lines numbers are rendered by the gutter
2012-05-14 09:53:58 -07:00
Nathan Sobo
0c89db37a5
Editor scroll position is correctly restored on refresh.
...
When we attach the editor we need to scroll it to the correct position before rendering lines. But to scroll it to the right position, the lines container and the scrollbar need to be assigned a height that allows them to scroll. So now we call `prepareForVerticalScrolling` on attach, then set the scroll position based on the edit session and render the visible lines.
2012-05-11 17:51:47 -06:00
