Commit Graph

43 Commits

Author SHA1 Message Date
Antonio Scandurra
e9623b30b8 Include apm version in the fingerprint 2016-07-16 20:26:58 +02:00
Thomas Johansen
22acdb76f6 🐛 Fix potential null reference callback invokation
Fixes #11328
2016-03-31 13:24:14 +02:00
Kevin Sawicki
c3bf0893b4 Use electron version only in fingerprint 2016-02-01 15:34:01 -08:00
Daniel Hengeveld
962b814bb6 add node version to fingerprint 2015-11-18 16:13:58 +01:00
Daniel Hengeveld
8005d53c3a Add a couple missing commas 2015-11-17 17:42:51 +01:00
Daniel Hengeveld
5dfed6d222 Move fingerprinting to utils 2015-11-17 17:41:45 +01:00
Kevin Sawicki
07b842b913 Merge pull request #6246 from jussi-kalliokoski/fix-test-script
🎨 💚 Fixed the test script.
2015-04-21 17:43:45 -07:00
Machiste Quintana
5d2392ea67 👕 Fix new coffeelint errors 2015-04-06 23:59:54 -04:00
Jussi Kalliokoski
9944e660ed 🎨 💚 Fixed the test script.
Also removed duplicated logic to run grunt.
2015-04-04 01:11:06 +03:00
Kevin Sawicki
67843c8ebd Remove Janky bypass of npm version check 2015-03-26 10:33:21 -07:00
Kevin Sawicki
a08c939699 Disable npm version check on CI 2015-03-26 10:25:05 -07:00
Kevin Sawicki
ad87ed5c40 Log detected version 2015-03-26 10:23:56 -07:00
Kevin Sawicki
2894d87ff8 Listen for spawn error events and log them 2014-11-17 17:34:54 -08:00
Kevin Sawicki
c72ce45820 Log installed node version 2014-09-12 13:22:14 -07:00
James R Sconfitto
f5a70da6f0 🏁 Use "npm.cmd" to verify npm 2014-06-10 17:26:57 -04:00
Kevin Sawicki
fe088ba16a Use local npm version when available 2014-06-10 11:45:47 -07:00
Kevin Sawicki
634c995a71 Verify npm version
This will end up in log output when people report build issues and now
the bootstrap will error when the npm version is <1.4.
2014-06-10 11:05:29 -07:00
Kevin Sawicki
0c0f143f91 Only print python version when checked 2014-06-05 08:53:02 -07:00
probablycorey
fbcb152107 Reorder if/else check 2014-06-04 14:07:59 -07:00
probablycorey
2e5c844d46 Use childProcess directly 2014-06-04 12:44:51 -07:00
probablycorey
0b088e8b72 💄 2014-06-04 12:34:18 -07:00
probablycorey
1479197ffb Add better python error message 2014-06-04 12:32:14 -07:00
probablycorey
c79c7b7a98 Make all verify requirements methods take callbacks
This moves the error handling to bootstrap and also allows us to 
display a success message.
2014-06-04 12:16:16 -07:00
probablycorey
3ead596a5d Assume the PYTHON env points to python.exe 2014-06-04 11:44:52 -07:00
probablycorey
99af9e2c33 Update error messages 2014-06-04 11:10:14 -07:00
probablycorey
b7bd11a883 Reuse pythonExecutable variable 2014-06-04 11:09:50 -07:00
probablycorey
1ac40b2673 Mimic Atom’s if/else style convention 2014-06-04 10:55:10 -07:00
James R Sconfitto
3f8d7d54cf 🏁 Verify python version for build
References:
56dcb88909/lib/configure.js
2014-06-03 22:20:33 -04:00
probablycorey
57531d75fe Add better python path description 2014-05-30 11:01:22 -07:00
probablycorey
0fdceb8474 Update bootstrap requires 2014-05-30 09:36:29 -07:00
probablycorey
07e64152be Add verify-requirements util 2014-05-30 09:31:42 -07:00
Kevin Sawicki
e4a65ca810 Convert update octicons from script to grunt task 2014-02-03 14:15:08 -08:00
Kevin Sawicki
1550511e54 Write octicon codes to variables folder 2014-01-28 10:06:40 -08:00
Kevin Sawicki
caffcafe2e 🙉 Ignore stdout from installation of apm 2013-11-15 09:54:36 -08:00
Kevin Sawicki
875e9c886c Increase max buffer to 1MB 2013-11-01 16:34:20 -07:00
Kevin Sawicki
05867bc889 Default error code to 1
Apparently not all errors passed to the callback have a code so default
it to zero when missing. The 'stdout maxBuffer exceeded.' is once such
error that has no code.
2013-11-01 16:27:46 -07:00
Cheng Zhao
4308e428d3 Rewrite script/cibuild in js. 2013-10-14 16:47:29 +08:00
Cheng Zhao
1d343dd483 Make the safeSpawn function a util module. 2013-10-14 15:14:03 +08:00
probablycorey
e833649111 Remove aa script and replace it with compile-main-to-app 2013-08-21 16:19:37 -07:00
Kevin Sawicki
c6a914a6e1 Default looking for octicons in ~/github/octicons 2013-08-07 10:59:45 -07:00
Kevin Sawicki
32af574206 Add trailing newline to octicon-utf-codes.less 2013-08-07 10:56:08 -07:00
probablycorey
de204b0321 Add script to automate octicon updates 2013-08-07 10:37:12 -07:00
probablycorey
82cb2aa124 Remove unused scripts 2013-06-20 17:15:53 -07:00