Max Brunsfeld
a60f330628
Default maintainHistory marker option to false
2015-07-21 13:27:05 -07:00
Antonio Scandurra
4e4b49eef8
🐛 updateContentDimensions when model changes
2015-07-07 11:28:30 +02:00
Antonio Scandurra
ce3304b788
🔥 Delete redundant specs
2015-06-12 18:41:19 +02:00
Antonio Scandurra
605f584d2e
Extract tiles specs into tiledContentContract
2015-06-12 12:53:29 +02:00
Antonio Scandurra
d45fc8a41f
Port TextEditorPresenter specs
2015-06-12 12:10:55 +02:00
Antonio Scandurra
f73435e053
🐛 Delete partially off-screen markers which are empty
...
* 🔥 Delete old code which was used to support some non-batched
methods in a previous version;
* ✅ Cover “partially off-screen markers which are
empty” scenario, since that code path was not hit by previous specs
Fixes #7183
2015-06-09 21:35:01 +02:00
Antonio Scandurra
b68da1e19b
💚 Finish porting TextEditorPresenter specs
2015-06-06 10:51:35 +02:00
Antonio Scandurra
de766afee7
Start porting specs
2015-06-06 10:18:26 +02:00
Max Brunsfeld
f5895d8b0b
presenter: use 'markers-updated' event for state updates
...
Signed-off-by: Nathan Sobo <nathan@github.com>
2015-06-03 17:58:44 -07:00
Antonio Scandurra
9b4d62b687
🐛 Update cursors after model changes
...
/cc: @nathansobo
2015-05-29 15:21:00 +02:00
Antonio Scandurra
b4dfb2a31b
Merge branch 'master' into as-tiled-rendering
2015-05-29 14:19:25 +02:00
Machiste Quintana
82958d5aa0
WIP: 👕 Fix even more linter errors
2015-05-22 17:03:06 -04:00
Antonio Scandurra
80a3294f8e
💚 Fix wrong spec
...
@nathansobo: I just forgot to include an actually visible tile in this
test which, therefore, complained. “Production code”-wise the behavior
was consistent and correct.
2015-05-22 14:05:21 +02:00
Nathan Sobo
1783415714
Fix spec failure
...
@as-cii this was just a typo, but there’s a failure later in the spec
that you’re probably in a better position to fix quickly.
2015-05-22 09:51:48 +02:00
Nathan Sobo
2379b3803f
Revert "Revert "Merge pull request #6757 from atom/ns-less-memory-for-tokens""
...
This reverts commit 7cb0bc3bc2
2015-05-21 19:56:52 +02:00
Nathan Sobo
7cb0bc3bc2
Revert "Merge pull request #6757 from atom/ns-less-memory-for-tokens"
...
This reverts commit 0cd1f110b5d75d202d33
2015-05-21 16:25:23 +02:00
Antonio Scandurra
490ab2c468
💚
...
Conflicts:
spec/text-editor-presenter-spec.coffee
src/lines-component.coffee
src/text-editor-presenter.coffee
2015-05-21 11:07:03 +02:00
Antonio Scandurra
299ee5dbf3
Merge branch 'master' into as-tiled-rendering
...
# Conflicts:
# spec/text-editor-presenter-spec.coffee
# src/lines-component.coffee
# src/text-editor-presenter.coffee
2015-05-21 10:46:52 +02:00
Antonio Scandurra
752dbf2c6e
Manually config tileSize
...
Dealing with a manually entered `tileSize` is actually easier to reason about,
therefore we no longer calculate it based on `tileCount.`
2015-05-21 09:59:58 +02:00
Antonio Scandurra
d116a33202
🔥
2015-05-18 11:56:41 +02:00
Antonio Scandurra
b66fdca057
Merge branch 'master' into as-tiled-rendering
...
Conflicts:
spec/text-editor-presenter-spec.coffee
2015-05-18 11:49:12 +02:00
Nathan Sobo
3dcf9a4c66
Merge remote-tracking branch 'origin/master' into ns-less-memory-for-tokens
2015-05-16 03:05:11 +02:00
Kevin Sawicki
3a51c44b55
👕 Use skinny arrow for afterEach
2015-05-14 17:03:48 -07:00
Antonio Scandurra
e7ddb3d8ad
💚 Fix all TextEditorPresenter specs
2015-05-14 15:54:53 +02:00
Antonio Scandurra
5b23a002cf
💚 Fix position specs
2015-05-14 15:54:45 +02:00
Jess Lin
57d0887346
[Gutter] Move line number gutter tests to be under .gutters in TextEditorPresenter specs
2015-05-13 16:47:42 -07:00
Jess Lin
e34dfc636c
[Gutter] Fix custom decorations tests in TextEditorPresenter specs
2015-05-13 16:47:42 -07:00
Jess Lin
cd806ee764
[Gutter] Fix former .sortedDescription tests in TextEditorPresenter specs
2015-05-13 16:47:42 -07:00
Jess Lin
b6055f3a67
[Gutter] Fix shared gutter styles tests in TextEditorPresenter specs
2015-05-13 16:47:42 -07:00
Jess Lin
fdb696f4dc
[Gutter] Fix line-number gutter tests in TextEditorPresenter specs
2015-05-13 16:47:42 -07:00
Nathan Sobo
173bc82e42
Don’t include tokens in presenter state for lines
2015-05-14 01:46:32 +02:00
Antonio Scandurra
25acaf26c1
🎨 tileId -> tileRow
2015-05-13 12:44:06 +02:00
Antonio Scandurra
49c48234f2
💚 Finish fixing tiles/lines specs
2015-05-13 12:27:51 +02:00
Antonio Scandurra
29c6e9d89c
💚 Start fixing presenter specs
2015-05-13 12:27:18 +02:00
Antonio Scandurra
11a0fa7a12
updateTileSize on start
2015-05-13 12:27:18 +02:00
Antonio Scandurra
daa4b33e64
wip
2015-05-06 09:03:23 +02:00
Antonio Scandurra
3d3d5d00b4
wip
2015-05-05 14:24:58 +02:00
Max Brunsfeld
570c424eae
Merge pull request #6563 from atom/ns-fix-scroll-width-with-folds
...
Fix scroll width calculation when longest line is folded
2015-04-30 14:26:34 -07:00
Ben Ogle
d3ef6c91af
Measure gutterWidth, and pass to presenter
2015-04-29 15:47:44 -07:00
Nathan Sobo
1d238dd927
Fix scroll width calculation when longest line is folded
...
With the presenter we started clipping screen positions prior to
translating them to pixel positions. This interacts with the current
clipping behavior on folded lines (which should change) where the cursor
is always clipped to 0. So when the longest line was also folded we
were miscalculating the width. 🙈 !
The removal of clipping also causes us to calculate the width based on
the trailing whitespace of soft-wrapped lines, which I actually think
is an improvement but it is slightly different.
2015-04-28 23:30:13 -06:00
Jess Lin
3949153390
[Gutter] Presenter should return gutter decorations for screen row range, not buffer row range
2015-04-22 07:29:00 -07:00
Jess Lin
55c6a11c36
[Gutter] Add comment to explain avoided decoration update in presenter & remove test
2015-04-22 07:29:00 -07:00
Jess Lin
85188ced03
[Gutter] Move 'lineNumberGutter' state to nest under 'gutters' in the presenter state
2015-04-22 07:28:59 -07:00
Jess Lin
8c4d092767
[Gutter] TextEditorPresenter tests for custom gutter decorations
2015-04-22 07:28:59 -07:00
Jess Lin
14e5d38354
[Gutter] TextEditorPresenter: Consolidate common gutter state under @state.gutters
2015-04-22 07:28:58 -07:00
Jess Lin
34856d94f5
[Gutter][DOM Persistence] Keep a gutter in the DOM if it is merely hidden (not destroyed)
2015-04-22 07:28:58 -07:00
Jess Lin
f3d2597bda
[Gutter][View Registry] Make the Presenter pass sorted Gutter models instead of sorted derived state
2015-04-22 07:28:58 -07:00
Jess Lin
d734ffe545
[Gutter] Make TextEditorPresenter recognize Decorations for custom gutters
2015-04-22 07:28:58 -07:00
Jess Lin
7582e98f4c
[Gutter] TextEditorPresenter: rename @state.gutter -> @state.lineNumberGutter
2015-04-22 07:28:57 -07:00
Jess Lin
fccc9ebee4
[Gutter] Rename current references to 'Gutter' -> 'LineNumberGutter'
2015-04-22 07:28:56 -07:00
