Commit Graph

7460 Commits

Author SHA1 Message Date
Nathan Sobo
c6cae5b8fd Store represented directory paths directly on AtomWindow in main process
Fixes #13729

Previously, when adding a window, we were unable to read its current
project paths out of the hash of the URL during window initialization
because the window still considered itself to be loading. Rather than
fixing this issue, we decided to completely eliminate the sharing of
state between processes in the window.location and instead switch to
cached synchronous RPC for the loadSettings and a dedicated RPC-based
mechanism for the project paths.
2017-02-07 13:15:27 -07:00
undefined
14348855ef Show first project path as window title if no pane items are open
Fixes #13647.

This restores the behavior we had prior to #13475 when there are no pane
items while preserving its improved behavior for paths outside of the
current project.
2017-02-06 16:02:20 -07:00
Damien Guard
83266c7486 Revert "Normalize disk drive letter in path on Windows" 2017-02-06 07:10:18 -08:00
Damien Guard
f3468d2955 Merge pull request #13725 from hron/normalize-disk-drive-letter
Normalize disk drive letter in path on Windows
2017-02-04 17:51:40 -08:00
Aleksei Gusev
ae76925926 Normalize disk drive letter in path on Windows
Currently atom creates two buffers for the same file if passed
paths use difference case for disk drive letter,
e.g. d:\file.txt and D:\file.txt
2017-02-01 18:32:08 +03:00
Antonio Scandurra
e49ac783f8 Fix infinite recursion when calling getLastSelection from onDidAddCursor 2017-01-24 12:18:09 +01:00
Antonio Scandurra
c5fbb79ac9 Merge pull request #13668 from atom/as-dont-throw-exception-for-malformed-css
Don't transform deprecated selectors containing malformed CSS
2017-01-23 13:36:23 +01:00
Nathan Sobo
82741c7cac Merge pull request #13664 from atom/fb-as-show-cursor-on-selection
Add showCursorOnSelection config
2017-01-20 14:07:21 -07:00
Damien Guard
1d2331b7e9 Merge pull request #13671 from atom/dg-yardstick-win32-specs
Ensure win32 has parity with macOS for yardstick specs
2017-01-20 12:47:50 -08:00
Damien Guard
d6553ab62c
Ensure win32 has parity with macOS for yardstick specs 2017-01-20 11:36:27 -08:00
Antonio Scandurra
93f2e34ded Don't transform deprecated selectors containing malformed CSS 2017-01-20 15:09:57 +01:00
Andres Suarez
1ee9d7b0f9 Add showCursorOnSelection config 2017-01-20 08:53:28 -05:00
Antonio Scandurra
1af1400911 Fix increasing/decreasing font size via ctrl-mousewheel
This regression was introduced with the removal of the shadow DOM from
`<atom-text-editor>` elements. Previously we were relying on Chrome
always reporting `<atom-text-editor>` as the mousewheel `event.target`.
As a result, removing the shadow boundary caused the mousewheel event to
be potentially dispatched from anywhere inside the editor element,
making our previous logic for handling ctrl-mousewheel invalid. This
commit fixes it by recognizing mousewheel events that are dispatched
from within an editor.
2017-01-20 13:53:49 +01:00
Damien Guard
afe7f9a1fa
Revert unintentional commit to lines-yardstick-spec.coffee 2017-01-19 23:32:02 -08:00
Damien Guard
d50b56b6a1
Add title for proxy settings config 2017-01-19 18:55:04 -08:00
Damien Guard
6dd6f171c2
Allow a bufferdprocess to be manually started 2017-01-19 13:30:39 -08:00
Nathan Sobo
0410ac9e8f Fix uncaught exceptions in ThemeManager specs 2017-01-18 10:19:25 -07:00
Nathan Sobo
4ef2924f55 Fix exceptions activating invalid packages in tests 2017-01-18 10:19:25 -07:00
Nathan Sobo
a433a84ab5 Fix describe block indentation 2017-01-18 10:19:25 -07:00
Max Brunsfeld
a57b627a58 Re-throw package activation exceptions in test mode 2017-01-18 10:19:25 -07:00
Damien Guard
623caaf85d Merge pull request #13605 from atom/dg-correct-portable-path-windows
Correct the portable path location on Windows
2017-01-14 09:35:27 -08:00
Damien Guard
090bbf9e77
Fix spec for path 2017-01-14 09:04:49 -08:00
Nathan Sobo
76d84a7890 Handle multiple selections intersecting a line in duplicateLines 2017-01-12 13:38:19 -07:00
Christopher Chedeau
ef7ce7cd3a Always reserve two digits on the line number gutter
We are working on a feature that changes the content of the editor when you mouse over some things and it makes the UI jump when going from 1 line to > 10. This makes the UI feel really bad.

I've looked at Sublime and the 1-9 state is the same as 1-99, only when you reach 100 lines then it jumps. I think that it is a better behavior as you want to minimize jumps as much as possible and it is extremely likely that you are going to hit the 9-10 lines threshold.

![](http://g.recordit.co/ABIlZf5eTx.gif)

While this is being reviewed and until the new version shipped, we are going to monkeypatch Atom in order to get this feature.

```js
var presenter = atom.textEditors.editors.entries().next().value[0].presenter.__proto__;
var old_updateLineNumberGutterState = presenter.updateLineNumberGutterState;
presenter.updateLineNumberGutterState = function() {
  var res = old_updateLineNumberGutterState.apply(this, arguments);
  this.lineNumberGutter.maxLineNumberDigits = Math.max(2, this.lineNumberGutter.maxLineNumberDigits);
  return res;
};
```

Released under CC0
2017-01-10 18:14:50 -08:00
Max Brunsfeld
d6bddb4ce6 Avoid assertions about application.json in main process test
We can test the user-facing behavior by launching a second instance
of AtomApplication.

Refs #13564
2017-01-09 11:31:25 -08:00
Vladimir Timofeev
a7dda0e6f6 Refactor test code 2017-01-08 00:03:36 +03:00
Vladimir Timofeev
be57e4cd48 Additional check that storage/application.json exists 2017-01-07 23:58:28 +03:00
Vladimir Timofeev
4d5312fec5 Restore test behaviour to check content of storage/application.json 2017-01-07 23:52:29 +03:00
=
1fb066ad68 Really fix tests on windows
Path names with backslashes was not quoted.
2017-01-07 23:11:31 +03:00
Vladimir Timofeev
94f28a3877 Another try to fix tests on Windows.
Wait for ipc.
2017-01-07 14:10:24 +03:00
Vladimir Timofeev
4ba6919d4d Try fix tests on Windows.
Only count AtomApplication#saveState calls, not saved content.
2017-01-07 13:04:05 +03:00
Vladimir Timofeev
bc77a79e86 Add test to ensure the state saved when project folders changed. 2017-01-07 10:59:22 +03:00
Ian Olsen
d35a63aa6a Basic test for user keymap loaded event 2017-01-05 17:12:02 -08:00
Max Brunsfeld
126f5380ba Emit editor destroyed event after releasing the editor's buffer 2017-01-03 15:18:01 -08:00
Max Brunsfeld
6f13159549 Don't throw exceptions when using editor APIs after destroying the editor
Signed-off-by: Nathan Sobo <nathan@github.com>
2017-01-03 14:00:50 -08:00
Max Brunsfeld
79e68b462d Avoid using torn-down properties in specs 2017-01-02 11:55:41 -08:00
Max Brunsfeld
f4371efb74 Fix usages of destroyed buffers in specs 2017-01-02 11:32:02 -08:00
Lee Dohm
640497081e
👕 2016-12-22 16:39:40 -08:00
Christopher Chedeau
a33ab44966 Add atom.tooltips.findTooltips(target)
Right now, it is not possible to hide a tooltip programatically. This is useful when we know better than the tooltip implementation that we did an action that should hide it.

After discussing with @lee-dohm, he suggested the findTooltips API that mimicks the KeyMapManager API.

Released under CC0
2016-12-23 00:01:42 +00:00
Michelle Tilley
96b7f7f8e6
Fix title bar tests on non-macOS systems 2016-12-19 19:43:15 -08:00
Michelle Tilley
c8865c2c05
Add failing test for incorrect title bar behavior 2016-12-19 19:32:33 -08:00
Max Brunsfeld
2095015e82 Merge pull request #13453 from atom/mb-ns-integrate-new-display-layer
Use new text-buffer version with a more efficient DisplayLayer
2016-12-16 10:25:10 -08:00
Nathan Sobo
f9dfabfdff Merge pull request #13194 from farnabaz/master
fix text selection and cursor position in lines with rtl text
2016-12-15 15:37:54 -07:00
Nathan Sobo
b087ab2734 Disable measurement tests for RTL text on Windows
@damieng This is unlike the other tests in this file in that none of the
assertions pass. Maybe you could take a look at some point to enable at
least some coverage on Windows for this?
2016-12-15 03:16:21 -07:00
Max Brunsfeld
a06d77710c Adjust LinesYardstick assertion to reflect removal of redundant leading whitespace span 2016-12-14 14:54:56 -08:00
Nathan Sobo
feb60ca0d3 Merge branch 'master' into farnabaz-master 2016-12-14 13:34:21 -07:00
Nathan Sobo
4e7d13b227 Clean up tests 2016-12-14 13:30:34 -07:00
Max Brunsfeld
d7b86d9187 Merge remote-tracking branch 'origin/master' into mb-ns-integrate-new-display-layer 2016-12-14 12:16:50 -08:00
Max Brunsfeld
8afeae46b4 Adjust assertion now that paired characters aren't wrapped in spans
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-12-13 17:29:36 -08:00
Max Brunsfeld
4f7b9e03c8 Expect a single leading whitespace token w/ atomic soft tabs & indent guides disabled
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-12-13 17:28:54 -08:00