pulsar-edit/pulsar
1
1
Fork 0
mirror of https://github.com/pulsar-edit/pulsar.git synced 2024-11-10 18:24:09 +03:00
Code Issues Packages Projects Releases Wiki Activity
24,316 Commits 96 Branches 797 Tags 495 MiB
f954aa2732
Commit Graph

5715 Commits

Author SHA1 Message Date
Jessica Lord
b8c0c661ea Correct package name, remove log 2015-05-12 16:57:50 -07:00
Jessica Lord
8a89054545 Fixture name to match fixture dir 2015-05-12 15:16:15 -07:00
Jessica Lord
d03153fab5 No spaces in package.json name 2015-05-12 12:58:50 -07:00
Jessica Lord
9dbdeac93c Merge branch 'master' into jl-all-your-normalizes 2015-05-11 17:21:29 -07:00
Jessica Lord
3e73eadb6c Correct semver by adding 3rd digit 2015-05-11 16:08:44 -07:00
Antonio Scandurra
9581202a77 Merge branch 'master' into as-tiled-rendering 2015-05-11 09:18:13 +02:00
Kevin Sawicki
2c23d6f3ab 🎨 2015-05-08 13:33:30 -07:00
Kevin Sawicki
02d1e0be56 Uncomment env conditionals 2015-05-08 13:25:54 -07:00
Kevin Sawicki
75ac785e77 Add spec for opening to line and column 2015-05-08 13:24:48 -07:00
Kevin Sawicki
1e567b62e2 Add spec for opening file to line number 2015-05-08 13:23:28 -07:00
Kevin Sawicki
9a85164090 Add spec for file path with trailing colon/whitespace 2015-05-08 13:04:42 -07:00
Jessica Lord
c9046a6cfa Add error message to Jasmine output 2015-05-08 11:16:19 -07:00
Kevin Sawicki
523171061b Stop resize if detached or if siblings are missing 
Closes #6630
 2015-05-07 16:26:18 -07:00
Kevin Sawicki
b7dddeebfe Guard against no hosted git info 
Closes #6693
 2015-05-07 13:24:03 -07:00
Max Brunsfeld
75289ee3dd Fix some integration test flakiness 2015-05-06 10:32:56 -07:00
Antonio Scandurra
daa4b33e64 wip 2015-05-06 09:03:23 +02:00
Antonio Scandurra
3d3d5d00b4 wip 2015-05-05 14:24:58 +02:00
Jessica Lord
1d69d83410 Merge pull request #6582 from atom/jl-short-url-redo 
Normalize short urls for repositories in package.json
 2015-04-30 15:00:05 -07:00
Max Brunsfeld
570c424eae Merge pull request #6563 from atom/ns-fix-scroll-width-with-folds 
Fix scroll width calculation when longest line is folded
 2015-04-30 14:26:34 -07:00
Jessica Lord
c228c3fcf7 Add spec and feature to test normalizing repository short urls 2015-04-30 11:23:11 -07:00
Kevin Sawicki
c347b41c55 Merge pull request #6539 from atom/mq-reset-font 
Reset font size to window's starting font size
 2015-04-30 10:50:43 -07:00
Machiste Quintana
4fb58317ec 🔥 Redundant lines 2015-04-30 13:41:47 -04:00
Lee Dohm
be2e340412 Remove focus 2015-04-29 18:16:49 -07:00
Lee Dohm
eda1b743d7 Fix spec to expect whitespace to be removed 2015-04-29 18:14:16 -07:00
Lee Dohm
22c915a8fd Fix most of the specs 2015-04-29 17:52:38 -07:00
CaptSaltyJack
adb017851b Fixed glaring mistake in test spec 2015-04-29 17:09:32 -07:00
CaptSaltyJack
a8283c3c9b Added delete-to-next/previous-word-boundary 
This is better behavior for alt-del/backspace operations, is less
"greedy" and doesn't eat up excess characters.
Also set default key mappings to these, feel free to trash my changes
to keymaps/darwin.cson. Though I do feel this should be default
behavior, personally.
 2015-04-29 16:31:07 -07:00
Ben Ogle
68a6af4873 Merge pull request #6572 from atom/bo-measure-gutter 
Measure gutter width rather than calculating the width
 2015-04-29 16:13:03 -07:00
Ben Ogle
d3ef6c91af Measure gutterWidth, and pass to presenter 2015-04-29 15:47:44 -07:00
Kevin Sawicki
a13c49d679 Merge pull request #6570 from jssln/gutter 
[Gutter] Clear custom gutter decorations from previous usages of a custo...
 2015-04-29 14:26:28 -07:00
Kevin Sawicki
da0c087675 Add BufferedProcess spec for invoking callbacks 2015-04-29 09:43:41 -07:00
Kevin Sawicki
920def7eb0 Add spec for thrown spawn error 2015-04-29 09:20:21 -07:00
Jess Lin
5e766b6eee [Gutter] Clear custom gutter decorations from previous usages of a custom gutter element 2015-04-29 08:53:04 -07:00
Nathan Sobo
1d238dd927 Fix scroll width calculation when longest line is folded 
With the presenter we started clipping screen positions prior to
translating them to pixel positions. This interacts with the current
clipping behavior on folded lines (which should change) where the cursor
is always clipped to 0. So when the longest line was also folded we
were miscalculating the width. 🙈!

The removal of clipping also causes us to calculate the width based on
the trailing whitespace of soft-wrapped lines, which I actually think
is an improvement but it is slightly different.
 2015-04-28 23:30:13 -06:00
Machiste Quintana
2bd7cc9a99 Reset font size if editor.fontSize is changed from anywhere 2015-04-28 22:58:35 -04:00
Nathan Sobo
192997c8cf Clear line numbers from previous usages of the gutter element 
In adding custom gutter APIs, I suggested to @jssln that we associate
the gutter model objects with DOM nodes in the view registry to make
it easy for package authors to get at the view layer for a particular
gutter. She also applied this treatment to the line numbers gutter,
which makes sense.

However, using the view registry opened up an unexpected wrinkle…

When you detach an editor, we need to tear down all the associated view
logic because at that point, we don’t know whether the element is about
to be reattached or whether it’s going to get garbage collected. In the
case where we reattach, we end up constructing a new TextEditorComponent
for the element. When this happens, the gutter component requests a DOM
node for the gutter from the view registry. Except in this case the
DOM element isn’t empty because it was already used by a different
component for the same element before it was detached. The fix is simply
to always clear out the line numbers to ensure we start in a clean
state.

@jssln: You should apply this same fix to custom gutters or we’ll see
the same issues.
 2015-04-28 20:05:25 -06:00
Machiste Quintana
12b59cf610 Only reset font size if font size has been changed 2015-04-28 06:27:03 -04:00
Machiste Quintana
f4b228c908 Reset font size to window's starting font size 2015-04-28 06:27:03 -04:00
Kevin Sawicki
3bd0093eb3 Update scrollbar style spec for new library API 2015-04-23 16:10:06 -07:00
Nathan Sobo
ec3f37dee3 Avoid deprecation warnings in spec 2015-04-22 13:12:09 -06:00
Jess Lin
3949153390 [Gutter] Presenter should return gutter decorations for screen row range, not buffer row range 2015-04-22 07:29:00 -07:00
Jess Lin
cdca9c3ef1 [Gutter] Fix coffeescript style issues 2015-04-22 07:29:00 -07:00
Jess Lin
55c6a11c36 [Gutter] Add comment to explain avoided decoration update in presenter & remove test 2015-04-22 07:29:00 -07:00
Jess Lin
166f040077 [Gutter] Address rename nit in CustomGutterComponent-spec 2015-04-22 07:28:59 -07:00
Jess Lin
85188ced03 [Gutter] Move 'lineNumberGutter' state to nest under 'gutters' in the presenter state 2015-04-22 07:28:59 -07:00
Jess Lin
79b460a0ca [Gutter] Add ::getDomNode method to all 'components' 2015-04-22 07:28:59 -07:00
Jess Lin
28ff5dd3c3 [Gutter] Tests for CustomGutterComponent 2015-04-22 07:28:59 -07:00
Jess Lin
f418376013 [Gutter] Tests for GutterContainerComponent 2015-04-22 07:28:59 -07:00
Jess Lin
8c4d092767 [Gutter] TextEditorPresenter tests for custom gutter decorations 2015-04-22 07:28:59 -07:00
Jess Lin
14e5d38354 [Gutter] TextEditorPresenter: Consolidate common gutter state under @state.gutters 2015-04-22 07:28:58 -07:00
Jess Lin
34856d94f5 [Gutter][DOM Persistence] Keep a gutter in the DOM if it is merely hidden (not destroyed) 2015-04-22 07:28:58 -07:00
Jess Lin
f3d2597bda [Gutter][View Registry] Make the Presenter pass sorted Gutter models instead of sorted derived state 2015-04-22 07:28:58 -07:00
Jess Lin
d734ffe545 [Gutter] Make TextEditorPresenter recognize Decorations for custom gutters 2015-04-22 07:28:58 -07:00
Jess Lin
8d6745d8a9 [Gutter] Replace GutterComponent with GutterContainerComponent in TextEditorComponent 2015-04-22 07:28:57 -07:00
Jess Lin
7582e98f4c [Gutter] TextEditorPresenter: rename @state.gutter -> @state.lineNumberGutter 2015-04-22 07:28:57 -07:00
Jess Lin
ee7625249f [Gutter] Create event subscription methods for gutter changes 2015-04-22 07:28:57 -07:00
Jess Lin
b361e1719c [Gutter] Add decorateMarker method to Gutter model 2015-04-22 07:28:57 -07:00
Jess Lin
58d6712b0e [Gutter] Augment Decoration to discern the line-number gutter from custom gutters 2015-04-22 07:28:57 -07:00
Jess Lin
eb321a64c1 [Gutter] Create a line-numbers Gutter on each TextEditor 2015-04-22 07:28:56 -07:00
Jess Lin
20d3c07bf5 [Gutter] Add add/get Gutter methods to TextEditor 2015-04-22 07:28:56 -07:00
Jess Lin
fccc9ebee4 [Gutter] Rename current references to 'Gutter' -> 'LineNumberGutter' 2015-04-22 07:28:56 -07:00
Jess Lin
a6efa104db [Gutter] Don't allow the 'line-number' gutter to be destroyed 2015-04-22 07:28:56 -07:00
Jess Lin
94a0bf3f90 [Gutter] Create Gutter and GutterContainer w/ API to hide/show 2015-04-22 07:28:56 -07:00
Nathan Sobo
9823f4ce09 Fix legacy event spec for scheduler change 2015-04-21 08:09:07 -06:00
Nathan Sobo
76a919f8b4 Perform document updates in same frame when requested from reads 
A common pattern is to put something on the DOM, measure it, then update
the DOM again based on that measurement. This change ensures that any
updates requested as a result of reading from the DOM get scheduled for
the end of the current frame. If you want to read *again* after these
follow-on updates, you will need to wait for the next frame. But at
least this way we ensure instant feedback with minimal thrashing
(1 reflow) when we have no choice but to read the DOM before updating.

/cc @benogle
 2015-04-20 22:01:36 -06:00
Nathan Sobo
d1c44dcb54 Never load config settings from disk when a save is pending 
Fixes #5771

We load the user’s settings from disk when we detect a change to their
config.cson file. However, if there’s a save pending, doing this will
end up blowing away the values we intend to save.
 2015-04-20 12:12:05 -06:00
Nathan Sobo
96b0938c7c 🎨 2015-04-20 12:12:05 -06:00
Antonio Scandurra
50010a55b9 Use a guard clause to disable integration specs 2015-04-16 09:52:41 +02:00
Antonio Scandurra
17894fd36b 🎨 2015-04-16 09:15:46 +02:00
Antonio Scandurra
f3a1aebb8a Merge branch 'master' into as-public-ci 2015-04-16 08:31:21 +02:00
Max Brunsfeld
c665747879 Merge pull request #6380 from atom/mb-reopen-windows 
Reopen windows when starting app w/ no arguments
 2015-04-15 15:50:22 -07:00
Max Brunsfeld
b8c7f655f9 🎨 Extract logic for storage folder into separate class 2015-04-15 15:09:49 -07:00
Max Brunsfeld
4545671dcf Move file drag and drop specs to pane-view-spec 2015-04-15 14:20:16 -07:00
Max Brunsfeld
e4984d68cc 🎨 Tidy up pane container resize element spec 2015-04-15 14:09:27 -07:00
Kevin Sawicki
1c67912ab6 👕 remove a ; 2015-04-15 14:04:10 -07:00
Max Brunsfeld
632c57d7b4 Merge pull request #5902 from liuxiong332/pane-resize 
add  implementation for resizable panes, just solve the issue #274
 2015-04-15 13:31:33 -07:00
Kevin Sawicki
9a0c3f94a9 Remove path data attributes when no active item 2015-04-15 10:32:22 -07:00
Kevin Sawicki
476cf4152c 🎨 2015-04-15 10:24:51 -07:00
Kevin Sawicki
d4439b1d55 Merge pull request #6383 from atom/mq-has-file-path 
Indicate whether buffer has a file path
 2015-04-15 10:21:57 -07:00
Machiste Quintana
8d0168a520 🎨 2015-04-15 13:12:38 -04:00
Kevin Sawicki
fda6bb3624 Add notification when reloading stylesheets fails 2015-04-15 09:18:02 -07:00
Kevin Sawicki
f8e940fdc0 Add spec for invalid theme stylesheet notification 2015-04-15 09:18:02 -07:00
liuxiong332
1331cfad4b change the spec description to make it clear 2015-04-15 22:20:17 +08:00
Antonio Scandurra
cf17a1ddc8 Merge branch 'master' into as-public-ci 2015-04-15 09:40:33 +02:00
liuxiong332
47c1062561 rename the spec file name to 'pane-container-element-spec' 2015-04-15 12:55:45 +08:00
Machiste Quintana
0cb00a8de8 ✅ Add converse specs 2015-04-14 23:23:26 -04:00
liuxiong332
e46d3b0d27 Merge remote-tracking branch 'origin' into pane-resize 
Conflicts:
	src/pane-element.coffee
	src/pane.coffee
 2015-04-15 10:09:41 +08:00
liuxiong332
4ab06aa627 fix some error in specs 2015-04-15 09:32:51 +08:00
Machiste Quintana
2b43f7d163 Add active path and file name to atom-pane 2015-04-14 20:52:26 -04:00
Machiste Quintana
94c5de0aeb 🎨 Change wording in spec 2015-04-14 20:00:06 -04:00
Machiste Quintana
0c69ecdd7f Unfocus spec 2015-04-14 19:57:29 -04:00
Machiste Quintana
5c9cb6d902 Revert "✅ Add tests for images and archives" 
This reverts commit 1a783963e3.
 2015-04-14 19:53:21 -04:00
Machiste Quintana
bf852160da Revert "Add image and archive fixtures" 
This reverts commit e6d1e16739.
 2015-04-14 19:52:07 -04:00
Machiste Quintana
1a783963e3 ✅ Add tests for images and archives 2015-04-14 19:26:17 -04:00
Machiste Quintana
e6d1e16739 Add image and archive fixtures 2015-04-14 18:51:19 -04:00
Machiste Quintana
078c6a80cf Add .has-file-path if active buffer has a file path 2015-04-14 18:35:32 -04:00
Max Brunsfeld
3d05ae02ba Reopen windows when launching w/ no arguments 2015-04-14 14:18:44 -07:00
Max Brunsfeld
ce7d0c161d Always quit Atom realistically in integration specs 2015-04-14 14:16:39 -07:00
Max Brunsfeld
d5ff7f26bf Create a new ATOM_HOME dir for each integration spec 2015-04-14 14:14:39 -07:00
Kevin Sawicki
5272584d29 Merge pull request #6359 from atom/as-fix-linux-failing-specs 
Fix some of the specs which fail on Linux
 2015-04-14 11:07:58 -07:00
Antonio Scandurra
6190fe00d7 🎨 Avoid string interpolation in require 2015-04-14 19:34:43 +02:00
Antonio Scandurra
304b959ca8 🎨 Use tags to exclude spec on Linux 2015-04-14 19:34:04 +02:00
Ben Ogle
cfb28d1c2e Merge pull request #6367 from atom/bo-follow-symlinks 
Default `core.followSymlinks` to true
 2015-04-14 10:22:02 -07:00
liuxiong332
acb236417a simplify the PaneResizeHandleElement specs 2015-04-15 00:23:48 +08:00
liuxiong332
412fbdef54 add specs for pane's serialization 2015-04-14 21:31:59 +08:00
liuxiong332
1c6583994a replace 'downPane' to 'lowerPane' 2015-04-14 21:17:40 +08:00
liuxiong332
769beadcf3 integration test in pane-axis-element-spec into pane-resize-handle-element-spec 2015-04-14 21:10:05 +08:00
Antonio Scandurra
1c8cf4390c Rename to safe-clipboard 
...and use remote only on Linux renderer processes.
 2015-04-14 10:50:09 +02:00
Ben Ogle
c13dce2d8f Fix spec 2015-04-13 18:32:01 -07:00
Ben Ogle
2872000d13 Fix paragraph computation in blocks of single line comments. 
Closes #6050

Closes #5963
 2015-04-13 16:26:24 -07:00
Sean Lee
74caf89dd1 🐛 fix rowRangeForParagraphAtBufferRow using \S 2015-04-13 15:46:27 -07:00
Antonio Scandurra
4cb7bde4a6 💚 Fix race condition on window-spec 
...caused by an afterEach block which was called before the SUT.
 2015-04-13 16:59:29 +02:00
Antonio Scandurra
87972caf1e 🐧 Disable failing spec 2015-04-13 16:24:22 +02:00
Antonio Scandurra
c4205e36a6 💚 Use a serif font to make sure char widths change 2015-04-13 14:32:40 +02:00
Antonio Scandurra
106f9fdf2e Use src/native-clipboard in atom-application 2015-04-13 14:08:43 +02:00
Antonio Scandurra
8daca6a63b 🐧 💚 Humanize keystrokes in specs 2015-04-13 12:24:25 +02:00
Antonio Scandurra
16dbb7d0bb 🐧 💚 Mock native clipboard appropriately 2015-04-13 12:12:03 +02:00
Antonio Scandurra
6dfcc582b3 Increase defaultTimeoutInterval for Travis 2015-04-10 21:07:14 +02:00
Antonio Scandurra
9a269178cd Merge branch 'master' into as-public-ci 2015-04-10 17:56:22 +02:00
Kevin Sawicki
4160a8c239 Merge pull request #6230 from mnquintana/coffeelint-plus 
Lint for more styleguide errors
 2015-04-08 12:07:23 -07:00
Machiste Quintana
adbd539302 Revert 👕 2015-04-08 14:36:00 -04:00
Antonio Scandurra
b08bd79e02 Disable focus methods on CI 2015-04-08 10:27:03 +02:00
Antonio Scandurra
f9f5213cdf Handle http.on('error') for webdriver polling 2015-04-08 08:57:26 +02:00
Antonio Scandurra
dee626ab69 Investigate timeouts issues (again) 2015-04-08 08:36:46 +02:00
Antonio Scandurra
8720af76a4 Merge branch 'master' into as-public-ci 2015-04-08 08:30:58 +02:00
Machiste Quintana
ec11c89a74 Revert 👕 for spec fixtures 2015-04-07 19:24:29 -04:00
Max Brunsfeld
c7a5ebf725 Merge pull request #6291 from atom/mb-rename-add-root-folder 
Rename 'add-root-folder' -> 'add-project-folder'
 2015-04-07 12:30:37 -07:00
Max Brunsfeld
f39c67411a Rename 'add-root-folder' -> 'add-project-folder' 2015-04-07 12:10:12 -07:00
Kevin Sawicki
06b8195fb8 Remove template config.cson file 
This old template file had several problems:

  * The entries in this file are already the schema defaults so they
    would get unset anyway when initially loaded
  * The file was in the old format that didn't have scope selectors
  * A race condition could occur when the file was copied, inited, and written
    to all during the very first run of Atom.

Closes #6226
 2015-04-07 11:47:36 -07:00
Antonio Scandurra
73fb36590d Use a 15s timeout for webdriver startup 2015-04-07 19:28:10 +02:00
Antonio Scandurra
4c12b6767e Stop focusing on integration specs 2015-04-07 17:55:01 +02:00
Antonio Scandurra
d494966759 Relax polling to check only every 100ms 2015-04-07 17:53:05 +02:00
Antonio Scandurra
1c7b473243 Wait for chromedriver to initialize 
Via a polling mechanism inspired by
https://github.com/SeleniumHQ/selenium/blob/master/dotnet/src/webdriver/DriverService.cs#L173-205
 2015-04-07 17:46:46 +02:00
Antonio Scandurra
efa2a34fd6 Use a large value in waits 
...to confirm that it is the culprit of Travis build errors.
 2015-04-07 15:36:58 +02:00
Antonio Scandurra
127253bea3 Revert "Reduce chromedriver waiting time to 500ms" 
This reverts commit 722705bb4c.
 2015-04-07 15:01:46 +02:00
Antonio Scandurra
722705bb4c Reduce chromedriver waiting time to 500ms 2015-04-07 14:40:36 +02:00
Antonio Scandurra
32ae7945ff Fine tune waiting time 2015-04-07 13:48:50 +02:00
Antonio Scandurra
a244c0fa07 🔥 Delete useless line in spec 2015-04-07 12:30:51 +02:00
Antonio Scandurra
59a5dc42a8 Merge branch 'master' into as-fix-delete-line 2015-04-07 12:12:36 +02:00
Antonio Scandurra
a090a81767 Bump chromedriver wait timeout 2015-04-07 11:46:42 +02:00
Antonio Scandurra
f3a7cc1b9d wip: focus on integration specs only 2015-04-07 11:24:12 +02:00
Machiste Quintana
5d2392ea67 👕 Fix new coffeelint errors 2015-04-06 23:59:54 -04:00
Kevin Sawicki
e02e8c91a6 Use TextEditor::onDidChangeCursorPosition in spec 2015-04-06 16:29:12 -07:00
Kevin Sawicki
9b7870d503 Snapshot deprecations around calls to Project::eachBuffer 2015-04-06 16:22:31 -07:00
Kevin Sawicki
50d9fee0d3 Use Project::onDidAddBuffer 2015-04-06 16:21:09 -07:00
Kevin Sawicki
188b2e5a74 Report core deprecations in specs 2015-04-06 15:55:51 -07:00
Max Brunsfeld
5df56fc50a Add workspace element command for 'add root folder' 2015-04-06 15:19:40 -07:00
Max Brunsfeld
decab183b7 Fix screen/buffer range error in paragraph cursor motions 2015-04-03 10:34:21 -07:00
Antonio Scandurra
42521900e8 📝 Improve naming 2015-04-03 18:10:43 +02:00
Antonio Scandurra
1cf5822d20 Merge intersecting selections by row before deleting lines 2015-04-03 18:06:28 +02:00
Antonio Scandurra
544f3e1af2 Merge pull request #6167 from FoldingText/upstream 
Clip positions above the first row
 2015-04-02 19:52:55 +02:00
Antonio Scandurra
21df0d0401 ✅ Use component.measureDimensions() 2015-04-02 19:06:41 +02:00
Jesse Grosjean
82da0865bc Merge branch 'master' of https://github.com/atom/atom into upstream 2015-04-02 12:23:03 -04:00
Antonio Scandurra
b3bdad084f Always mutate selections in order 2015-04-02 16:35:26 +02:00
Antonio Scandurra
44d88e082c 🐛 Always copy selections in order 2015-04-02 16:28:22 +02:00
Ben Ogle
dff2453b65 Attempt to fix spec 2015-04-01 18:05:17 -07:00
Ben Ogle
44d1302402 Fix text-editor-component spec 2015-04-01 17:41:00 -07:00
Ben Ogle
48c05210fa Remove specs from text-editor-component 2015-04-01 17:41:00 -07:00
Ben Ogle
48a06868c8 Add specs from the text-editor-component 2015-04-01 17:41:00 -07:00
Ben Ogle
bed09cf0ef Presenter positions overlays when the overlay doesn’t have a size 
Fix presenter specs
 2015-04-01 17:41:00 -07:00
Ben Ogle
32572c0106 Add ViewRegistry::pollAfterNextUpdate 
Closes #6196
 2015-04-01 17:41:00 -07:00
Ben Ogle
b0794bbb68 Move the overlay calculation into the presenter. 2015-04-01 17:40:59 -07:00
Ben Ogle
01905ae55b Add specs for margin handling 2015-04-01 17:40:59 -07:00
Ben Ogle
6b5a74e3b6 Update specs for overlay rendering 2015-04-01 17:40:59 -07:00
Jesse Grosjean
409775b53e Improved specs for clipping pixel positions above/below display buffer 2015-04-01 12:39:22 -04:00
Jesse Grosjean
b067a6175f add screenPositionForPixelPosition spec 2015-03-30 13:52:28 -04:00
Nikolaus Wittenstein
b28ee92896 Add tests for DisplayBuffer::screenPositionForBufferPosition around soft tabs 
This makes sure that a buffer position in the middle of a soft tab will
correctly clip to the closest edge by default.
 2015-03-29 19:43:25 -04:00
Nikolaus Wittenstein
5a3f2035a1 Replace skipAtomicTokens with clip 
When clipping a screen position, callers used to have to pick between
clipping to the left edge or the right edge when the position was in the
middle of an atomic token. This change allows them to choose the closest
edge, and makes this the default.

This makes selecting hard tabs (or any other atomic tokens) work in a
similar manner as in other text editors; that is, when clicking near
the middle of a tab, the insertion point will move to the closest edge
rather than the left edge.
 2015-03-29 19:43:25 -04:00
Nikolaus Wittenstein
372fb49c88 TokenizedLine::screenColumnForBufferColumn calculates more accurately 
screenColumnForBufferColumn used to break only if the current column
was strictly greater than the target column. This commit changes it so
it breaks when greater or equal, which is how bufferColumnForScreenColumn
works.

This also adds some unit tests for screenColumnForBufferColumn's
interactions with hard tab characters.
 2015-03-29 19:43:25 -04:00
Max Brunsfeld
230eb12a8a Fix double autoscroll when moving cursor 2015-03-27 10:27:24 -07:00
Kevin Sawicki
ffdf7ac558 Remove unneeded failed count check 2015-03-26 16:36:01 -07:00
Kevin Sawicki
c2fecacdbe Fail CI build when deprecations exist 2015-03-26 16:36:01 -07:00
Nathan Sobo
127e0fbf6b Merge pull request #6114 from atom/mb-ns-fix-autoscroll 
Fix autoscroll on undo
 2015-03-26 17:34:39 -06:00
Nathan Sobo
ae4f7f6170 Explicitly autoscroll when needed 
Rather than when the selection’s marker changes. This is simpler than
suppressing autoscroll via state when we don’t want it. It also captures
the intent to autoscroll when attempting to move the cursor at the
beginning or end of the document.

Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2015-03-26 16:48:24 -06:00
Nathan Sobo
99c437ccec Allow autoscroll override option in cursor/selection methods 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2015-03-26 16:48:21 -06:00
Kevin Sawicki
14d1fc2269 Merge pull request #5898 from basarat/master 
Transpile all .ts files
 2015-03-26 14:33:04 -07:00
Nathan Sobo
10458a5b45 Always autoscroll when the range of the last selection changes 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2015-03-26 15:30:53 -06:00
Max Brunsfeld
2f5d975338 Remove autoscroll-related legacy editor view support 
Signed-off-by: Nathan Sobo <nathan@github.com>
 2015-03-26 11:12:37 -07:00
Basarat Syed
6f1b061dac Added TypeScript to the compile-cache 2015-03-24 18:05:30 +11:00
Cheng Zhao
2620c95d86 String.contains is not a standard method in Chrome 41 2015-03-24 12:06:03 +08:00
Michael Bolin
14316b1cd7 Add Repository::getType(). 
For `GitRepository`, this will return `"git"`.
 2015-03-23 15:38:38 -07:00
liuxiong332
78f760aa08 make pane resize behavior be valid when split or close panes dynamically. 2015-03-23 20:47:20 +08:00
liuxiong332
e54c5b0cb8 delete some not used statement 2015-03-23 20:04:35 +08:00
liuxiong332
47742768a2 add specs which simulate mouse action in PaneResizeHandleElement to test the resize behavior. 2015-03-23 19:47:05 +08:00
Nathan Sobo
5f76979fc8 Fix random editor spec now for indented soft-wrap 
We previously implemented soft-wrap logic again just for this test.
Since the purpose of this test is just to make sure that mutation occurs
correctly, we now instead construct a fresh editor for comparison so
that changes to soft-wrap logic are reflected.

/cc @as-cii Took care of this, so you don’t need to worry about my
previous comment on your PR. Sorry for the noise.
 2015-03-19 15:08:48 -06:00
Jessica Lord
390e95e220 Merge branch 'master' into jlks-missing-services-fix 2015-03-19 10:19:56 -07:00
Antonio Scandurra
61cc9b97ea 💚 Fix failing spec 2015-03-19 11:45:54 +01:00
Antonio Scandurra
56020b11b0 🐛 Avoid soft-wrapping on indentation 2015-03-19 11:36:55 +01:00
Basarat Syed
c2f258c679 Addressed code review 2015-03-19 11:45:13 +11:00
Jessica Lord
2c46748307 add spec to check missing service methods are skipped 
Signed-off-by: Kevin Sawicki <kevin@github.com>
 2015-03-18 15:38:13 -07:00
Jessica Lord
cac361e6df add packages for new spec 
Signed-off-by: Kevin Sawicki <kevin@github.com>
 2015-03-18 15:34:28 -07:00
Nathan Sobo
609a661174 Merge pull request #6010 from atom/as-soft-wrap-hanging-indent 
Soft wrap hanging indentation spaces
 2015-03-18 11:39:27 -06:00
Antonio Scandurra
fbfe19825b Even more descriptive specs ✨ 2015-03-18 18:00:31 +01:00
Antonio Scandurra
8559526215 ✅ Write a more comprehensive spec 2015-03-18 17:42:25 +01:00
Antonio Scandurra
7c33b9bf41 🎨 Rename to softWrapHangingIndent 2015-03-18 14:18:27 +01:00
Antonio Scandurra
f0b9bb7ce3 Show indent guides on hanging indentation too 2015-03-18 11:17:34 +01:00
Basarat Syed
8793bebfab ✅ tests for typescript transpiling 2015-03-18 17:53:15 +11:00
liuxiong332
8b137719a0 replace 'fdescribe' with 'describe' in pane-axis-element-spec.coffee 2015-03-18 13:36:23 +08:00
liuxiong332
60434b1a7d simplify the pane-axis-element-spec spec files 2015-03-18 13:33:47 +08:00
Kevin Sawicki
cd5adb6ab7 Clear invalid rows when short-circuiting for null grammar 2015-03-17 17:41:22 -07:00
Kevin Sawicki
eb63556b27 Use - in socket file name 2015-03-17 16:51:52 -07:00
Kevin Sawicki
a64e1c9ca8 Merge pull request #5960 from Bjoernsen/patch-1 
Enable multiple users
 2015-03-17 16:50:00 -07:00
Antonio Scandurra
6ac8af2a6e ✅ Check leading spaces as well 2015-03-17 22:58:14 +01:00
Antonio Scandurra
6d39bd3657 ✅ Verify that hanging indentation is tokenized 2015-03-17 22:21:07 +01:00
Kevin Sawicki
46e881739c Set themes names at beginning of spec 2015-03-16 15:11:12 -07:00
Nathan Sobo
010154f802 Merge pull request #5959 from atom/as-fix-select-above-below 
Use screen ranges to select above and below
 2015-03-16 11:26:54 -06:00
Bjoernsen
d6338b0a2c Update start-atom.coffee 2015-03-16 08:38:01 +01:00
Antonio Scandurra
6633c90af8 Use buffer ranges when merging selections 2015-03-14 10:05:04 +01:00
Antonio Scandurra
0a23a21953 🎨 Get rid of goalBufferRange 2015-03-14 09:48:19 +01:00
Antonio Scandurra
bfe8f7c740 Fix soft-wrapping specs 2015-03-14 09:26:35 +01:00
Max Brunsfeld
587ebd7538 Fix Project::relativePath w/ URLs 2015-03-13 15:07:56 -07:00
Max Brunsfeld
eb355118ad Merge pull request #5961 from atom/mb-batch-services-providers-by-package 
Batch service providers by package
 2015-03-13 13:28:41 -07:00
Max Brunsfeld
7ec46933bd Batch service providers by package 2015-03-13 11:42:30 -07:00
Nathan Sobo
a4257ed513 Merge pull request #5936 from atom/as-destroy-containing-folds-on-selection 
Destroy only containing folds on selection
 2015-03-13 11:28:46 -07:00
Antonio Scandurra
8ac4848805 Skip soft-wrap indentation tokens while selecting 
* 🎨 Restructure specs a bit
* ✅ Write specs for this new behavior
 2015-03-13 12:05:18 +01:00
Antonio Scandurra
c319b80464 ✅ Write specs for atomic tokens 2015-03-13 11:56:00 +01:00
Antonio Scandurra
02ad2e8ff7 ✅ Write specs for soft-wrapped lines selection 2015-03-13 11:32:42 +01:00
Antonio Scandurra
3b5a0b292d 📝 Better and consistent naming across specs and docs 2015-03-12 12:32:59 +01:00
Antonio Scandurra
faa2944232 ✅ Cover edge case scenario 
...where buffer rows are less than rows fitting on screen
 2015-03-12 10:33:19 +01:00
Antonio Scandurra
912dd732a9 🎨 Uniform new tests structure 2015-03-12 10:17:26 +01:00
Antonio Scandurra
9f1bb82451 Adjust DisplayBuffer#getVisibleRowRange logic 
This fixes #4596, where the calculation returned a wrong range.

* 📝 State clearly that we'll return a closed interval in docs
* ✅ Write tests to ensure a correct behavior
 2015-03-12 10:08:02 +01:00
Antonio Scandurra
2b98192276 Destroy only containing folds on selection 2015-03-11 16:16:45 +01:00
Max Brunsfeld
f1375ca849 Merge pull request #5875 from atom/mb-multi-folder-all-the-time 
Always open all CLI paths in the same window
 2015-03-10 14:31:42 -07:00
liuxiong332
9b77d303a5 add specs for pane axis element 2015-03-10 21:29:16 +08:00
Antonio Scandurra
8c297ba1fc ✅ Verify corrupted state graceful handling 2015-03-09 13:43:33 +01:00
Max Brunsfeld
a6e8f8a08a Always open all CLI paths in the same window 
No more 'atom --multi-folder'
 2015-03-05 15:23:28 -08:00
Kevin Sawicki
7a3065e0fb Add spec for invalid settings notification 2015-03-04 11:18:15 -08:00
Kevin Sawicki
f02fa4a245 Add spec for invalid grammar notification 2015-03-04 11:12:09 -08:00
Kevin Sawicki
59c3dea77b Show notification for invalid context menu selector 2015-03-04 10:02:04 -08:00
Kevin Sawicki
a2d9ba2d2e Only try to require main module once 2015-03-04 10:02:04 -08:00
Kevin Sawicki
628380ff3d Unfocus spec 2015-03-04 10:02:04 -08:00
Kevin Sawicki
6c87dc05f3 Migrate specs from console.warn to notifications 2015-03-04 10:02:03 -08:00
Kevin Sawicki
fa2eab5b7e Show notification when parsing package.json fails 2015-03-04 10:02:03 -08:00
Kevin Sawicki
a7bd20f08f Remove unused fixture 2015-03-04 10:02:03 -08:00
Kevin Sawicki
5902bc42e9 Throw error when adding context menu with invalid selector 2015-03-04 10:02:03 -08:00
Kevin Sawicki
333a495d55 Catch errors adding activation commands 2015-03-04 10:02:03 -08:00
Kevin Sawicki
8ba098b640 Throw an error when adding an invalid selector 2015-03-04 10:02:03 -08:00
Michael Bolin
a0a4dac571 Fix a bug when a URI is passed to atom.project.removePath(). 2015-03-03 21:44:54 -08:00
Ben Ogle
5f7015f303 Remove isInitialEmptyEditor 2015-03-03 13:18:02 -08:00
Ben Ogle
80b1d89c62 Check getLoadSettings to decide to open initial buffer 2015-03-03 12:34:54 -08:00
Ben Ogle
80cd20193a Move the logic for opening empty initial buffer to renderer 2015-03-03 11:39:38 -08:00
Ivan Zuzak
e452070847 Merge branch 'master' into iz-gutter-click-select-whole-soft-wrapped-line 2015-03-03 15:40:56 +01:00
Ivan Zuzak
03a064b6e9 Add specs for mouse interactions on gutter with soft wrap 2015-03-03 13:59:46 +01:00
Max Brunsfeld
8fac0e8778 Merge pull request #5795 from mostafaeweda/master 
Default directory provider should handle only local filesystem directories
 2015-03-02 16:04:54 -08:00
Mostafa Eweda
b74a688baa Bare minimum fix to the default directory provider 2015-03-02 14:28:01 -08:00
Darrell Sandstrom
a8c4943d91 Add subword navigation 
- Add commands for moving, selecting, and deleting camelCase words
 2015-03-01 17:17:17 -08:00
Antonio Scandurra
a12bf66e41 Merge branch 'master' into batch-updates 2015-02-28 10:21:48 +01:00
Antonio Scandurra
78a1a724db 🎨 More expressive specs 2015-02-28 09:55:49 +01:00
Antonio Scandurra
436322fc41 Call it onDidUpdateState 2015-02-28 09:36:56 +01:00
Antonio Scandurra
0dca5a5fcd Encapsulate state update inside TextEditorPresenter#getState 2015-02-28 09:25:53 +01:00