pulsar-edit/pulsar
1
1
Fork 0
mirror of https://github.com/pulsar-edit/pulsar.git synced 2024-09-21 07:58:04 +03:00
Code Issues Packages Projects Releases Wiki Activity
65af9e953b
pulsar/spec
History
Antonio Scandurra 65af9e953b Stop dragging only when user interacts with keyboard 
Previously, we used to prevent the user from dragging the selection
further when the buffer was about to change. This was problematic
because any change in the buffer, even one that was performed
"automatically" by a package, would cancel the dragging action and
result in a confusing experience for the user.

On the other hand, we want to prevent users from accidentally selecting
text when they perform an edit (see #15217, #15405).

This commit addresses both concerns by canceling the dragging as soon as
the user interacts with the keyboard, instead of canceling the dragging
when the buffer is about to change.

One downside of this approach is that it changes the behavior of
pressing a keystroke that does not result in a buffer change, e.g.
Shift, Arrow Keys, etc.

Signed-off-by: Jason Rudolph <jasonrudolph@github.com>
2017-10-17 18:50:20 +02:00
..
fixtures Fix folding for lines that contain a comment 2017-08-17 14:28:30 +02:00
helpers Introduce randomized test for TextEditorComponent 2017-10-05 13:05:52 +02:00
integration Disable github package in smoke test – it takes too long to compile 2017-05-11 16:46:02 -06:00
main-process Fix tests 2017-08-14 12:28:19 +02:00
application-delegate-spec.js Stringify/parse temporary window state to avoid nulling out references 2016-08-09 14:43:38 -06:00
async-spec-helpers.js 👕 keep standard happy 2017-08-01 15:08:04 -04:00
atom-environment-spec.coffee 👕 Unnecessary fat arrows 2017-09-20 10:52:33 -04:00
atom-paths-spec.js Wrap temp.cleanupSync() calls in try-catch blocks 2017-08-04 14:18:43 -04:00
atom-protocol-handler-spec.coffee Fix linter errors 2015-09-18 20:48:50 -06:00
atom-reporter.coffee Update spec reporter relativization 2017-05-03 14:21:24 +02:00
auto-update-manager-spec.js Start fixing tests 2017-03-11 19:05:28 +01:00
babel-spec.coffee Wrap temp.cleanupSync() calls in try-catch blocks 2017-08-04 14:18:43 -04:00
buffered-node-process-spec.coffee Remove Duplicate Require Statements and Unify Syntax on ' 2016-01-15 14:35:28 -06:00
buffered-process-spec.coffee Allow a bufferdprocess to be manually started 2017-01-19 13:30:39 -08:00
clipboard-spec.coffee Add Clipboard::readWithMetadata 2014-02-03 13:20:28 -08:00
command-installer-spec.js Replace runas with fs-admin in CommandInstaller 2017-08-25 15:46:43 -07:00
command-registry-spec.js Clean up docs and comment wording 2017-08-28 14:49:54 -07:00
compile-cache-spec.coffee Wrap temp.cleanupSync() calls in try-catch blocks 2017-08-04 14:18:43 -04:00
config-spec.coffee Clean the pending operations too 2017-09-12 14:39:17 -04:00
context-menu-manager-spec.coffee Base context menu accelerators on activeElement 2017-08-16 11:58:05 -07:00
decoration-manager-spec.coffee Schedule component updates directly from the model 2017-05-05 09:29:29 +02:00
default-directory-provider-spec.coffee Wrap temp.cleanupSync() calls in try-catch blocks 2017-08-04 14:18:43 -04:00
default-directory-searcher-spec.coffee Remove Duplicate Require Statements and Unify Syntax on ' 2016-01-15 14:35:28 -06:00
deserializer-manager-spec.coffee Return a Disposable instance from DeserializerManager::add 2014-09-30 12:58:10 -06:00
dock-spec.js Add methods for observing dock visibility 2017-06-07 16:24:28 -07:00
file-system-blob-store-spec.coffee Speed up FileSystemBlobStore.load by not storing invalidation keys 2017-03-13 19:11:53 +01:00
git-repository-provider-spec.js Convert git-repository-provider-spec to JS 2017-09-27 12:18:17 -07:00
git-repository-spec.coffee Wait for repo to refresh in test 2017-09-27 14:19:05 -07:00
grammars-spec.coffee Get more tests working after async 2017-09-08 19:00:26 -07:00
gutter-container-spec.js ☠☕ Decaffeinate spec/gutter-container-spec.coffee 2017-10-06 09:33:43 -04:00
gutter-spec.js ☠☕ Decaffeinate spec/gutter-spec.coffee 2017-10-05 11:06:42 -04:00
history-manager-spec.js Eliminate reliance on local storage in HistoryManager 2017-05-11 16:58:54 -06:00
jasmine-test-runner.coffee 🔥 console.logs 2017-08-02 19:34:44 -04:00
keymap-extensions-spec.coffee Basic test for user keymap loaded event 2017-01-05 17:12:02 -08:00
menu-manager-spec.coffee Merge branch 'master' into wl-build-on-node-7 2017-03-21 23:25:31 -04:00
module-cache-spec.coffee Wrap temp.cleanupSync() calls in try-catch blocks 2017-08-04 14:18:43 -04:00
native-compile-cache-spec.coffee Speed up FileSystemBlobStore.load by not storing invalidation keys 2017-03-13 19:11:53 +01:00
native-watcher-registry-spec.js Consistently split paths in test cases 2017-08-03 08:51:44 -04:00
notification-manager-spec.js 💀☕ Decaffeinate spec/notification-manager-spec.coffee 2017-09-16 21:03:04 -04:00
notification-spec.js 💀☕ Decaffeinate spec/notification-spec.coffee 2017-09-16 21:03:01 -04:00
package-manager-spec.js 🎨 2017-09-28 17:09:55 -07:00
package-spec.coffee Fix a few more tests 2017-09-08 19:00:27 -07:00
package-transpilation-registry-spec.js Allow root package paths to contain 'node_modules' 2017-04-04 07:54:35 -07:00
pane-axis-element-spec.coffee Remove unnecessary calls to ViewRegistry.getView 2017-04-05 16:50:04 -07:00
pane-container-element-spec.coffee spelling: recover 2017-09-10 15:46:40 +00:00
pane-container-spec.js Convert pane-container-spec to JS 2017-09-18 17:02:48 -07:00
pane-element-spec.coffee fix tests 2017-09-19 15:30:25 -05:00
pane-spec.js Wait for async onWillDestroyPaneItem listeners 2017-09-13 13:31:33 -07:00
panel-container-element-spec.js Add documentation to addModalPanel api 2017-08-22 23:14:54 -07:00
panel-container-spec.js Add Panel.getElement and remove Panel view provider 2017-04-05 16:10:21 -07:00
panel-spec.js spelling: visible 2017-09-10 15:46:41 +00:00
path-watcher-spec.js Jasmine, not Mocha 2017-08-17 22:01:25 -04:00
project-spec.coffee Spelling 2017-09-20 10:51:30 -04:00
reopen-project-menu-manager-spec.js spelling: separated 2017-09-10 15:46:41 +00:00
sample-with-comments.js Pass AppDelegate to Workspace, Pane instead of bound functions 2015-10-13 18:54:48 -06:00
selection-spec.coffee Avoid using torn-down properties in specs 2017-01-02 11:55:41 -08:00
spec-helper-platform.coffee 💄 Remove unneeded requires, variables, commas, and parens 2013-12-31 15:05:34 -08:00
spec-helper.coffee Allow Promises to be returned by a package deactivate method 2017-09-08 19:00:25 -07:00
squirrel-update-spec.coffee Wrap temp.cleanupSync() calls in try-catch blocks 2017-08-04 14:18:43 -04:00
state-store-spec.js Add delete() method to StateStore 2017-04-04 13:45:14 -07:00
style-manager-spec.js Wrap temp.cleanupSync() calls in try-catch blocks 2017-08-04 14:18:43 -04:00
styles-element-spec.coffee Transform deprecated shadow DOM selectors in StyleManager 2016-10-07 10:40:41 +02:00
task-spec.coffee Remove unused variables 2016-09-26 20:52:13 +03:00
text-editor-component-spec.js Stop dragging only when user interacts with keyboard 2017-10-17 18:50:20 +02:00
text-editor-element-spec.js Merge pull request #15392 from atom/fb-wb-standard-env 2017-08-21 09:38:34 -06:00
text-editor-registry-spec.js maxScreenLineLength rebased to github 2017-09-12 14:38:29 +12:00
text-editor-spec.coffee Prompt to save when unloading if editor is in conflict 2017-10-03 11:09:33 -07:00
text-editor-spec.js Prompt to save when unloading if editor is in conflict 2017-10-03 11:09:33 -07:00
text-utils-spec.coffee Implement isWrapBoundary for DisplayLayer 2016-03-18 18:30:35 +01:00
theme-manager-spec.coffee Get more tests working after async 2017-09-08 19:00:26 -07:00
time-reporter.coffee Remove unused variables 2016-09-26 20:52:13 +03:00
title-bar-spec.js Consistently use require('temp').track() 2017-08-04 14:08:29 -04:00
token-iterator-spec.coffee Use TokenizedBuffer.prototype.tokenizedLineForRow conservatively 2016-10-12 09:04:41 +02:00
tokenized-buffer-iterator-spec.js Ignore mismatched tags between lines in TokenizedBufferIterator 2017-05-10 17:54:14 +02:00
tokenized-buffer-spec.js Preserve indentation when toggling comments on whitespace-only lines 2017-10-03 10:14:45 -07:00
tooltip-manager-spec.coffee spelling: programmatically 2017-09-10 15:46:40 +00:00
typescript-spec.coffee Use source-map-support to handle stack trace conversion 2015-08-19 17:55:29 -07:00
update-process-env-spec.js Wrap temp.cleanupSync() calls in try-catch blocks 2017-08-04 14:18:43 -04:00
view-registry-spec.coffee Stop calling initialize in ViewRegistry tests 2017-05-05 09:29:29 +02:00
window-event-handler-spec.coffee Fix handling of .save and .saveAs rejections 2017-05-31 17:46:04 -07:00
workspace-center-spec.js 🐛 Add missing onDidAddTextEditor method to WorkspaceCenter 2017-05-25 17:24:07 -04:00
workspace-element-spec.js Remove one-off eslint global pragmas in favor of envs 2017-08-20 19:55:00 -07:00
workspace-spec.js spelling: falsy 2017-09-10 15:46:39 +00:00