mirror of
https://github.com/pulsar-edit/pulsar.git
synced 2024-09-20 23:48:05 +03:00
447dfd8bec
Fixes atom/atom-keymap#79 This is more general than I would like. If the keystroke is unset in any context, we err on the side of caution and don’t add it to the application menu for any command. Since our application menu isn’t context aware, this should be good enough for now and solve the 80% case. Someday we should make the application menu update / gray out options when the focused element changes.
79 lines
3.2 KiB
CoffeeScript
79 lines
3.2 KiB
CoffeeScript
path = require 'path'
|
|
MenuManager = require '../src/menu-manager'
|
|
|
|
describe "MenuManager", ->
|
|
menu = null
|
|
|
|
beforeEach ->
|
|
menu = new MenuManager(resourcePath: atom.getLoadSettings().resourcePath)
|
|
|
|
describe "::add(items)", ->
|
|
it "can add new menus that can be removed with the returned disposable", ->
|
|
disposable = menu.add [{label: "A", submenu: [{label: "B", command: "b"}]}]
|
|
expect(menu.template).toEqual [{label: "A", submenu: [{label: "B", command: "b"}]}]
|
|
disposable.dispose()
|
|
expect(menu.template).toEqual []
|
|
|
|
it "can add submenu items to existing menus that can be removed with the returned disposable", ->
|
|
disposable1 = menu.add [{label: "A", submenu: [{label: "B", command: "b"}]}]
|
|
disposable2 = menu.add [{label: "A", submenu: [{label: "C", submenu: [{label: "D", command: 'd'}]}]}]
|
|
disposable3 = menu.add [{label: "A", submenu: [{label: "C", submenu: [{label: "E", command: 'e'}]}]}]
|
|
|
|
expect(menu.template).toEqual [{
|
|
label: "A",
|
|
submenu: [
|
|
{label: "B", command: "b"},
|
|
{label: "C", submenu: [{label: 'D', command: 'd'}, {label: 'E', command: 'e'}]}
|
|
]
|
|
}]
|
|
|
|
disposable3.dispose()
|
|
expect(menu.template).toEqual [{
|
|
label: "A",
|
|
submenu: [
|
|
{label: "B", command: "b"},
|
|
{label: "C", submenu: [{label: 'D', command: 'd'}]}
|
|
]
|
|
}]
|
|
|
|
disposable2.dispose()
|
|
expect(menu.template).toEqual [{label: "A", submenu: [{label: "B", command: "b"}]}]
|
|
|
|
disposable1.dispose()
|
|
expect(menu.template).toEqual []
|
|
|
|
it "does not add duplicate labels to the same menu", ->
|
|
originalItemCount = menu.template.length
|
|
menu.add [{label: "A", submenu: [{label: "B", command: "b"}]}]
|
|
menu.add [{label: "A", submenu: [{label: "B", command: "b"}]}]
|
|
expect(menu.template[originalItemCount]).toEqual {label: "A", submenu: [{label: "B", command: "b"}]}
|
|
|
|
describe "::update()", ->
|
|
it "sends the current menu template and associated key bindings to the browser process", ->
|
|
spyOn(menu, 'sendToBrowserProcess')
|
|
menu.add [{label: "A", submenu: [{label: "B", command: "b"}]}]
|
|
atom.keymap.add 'test', 'atom-workspace': 'ctrl-b': 'b'
|
|
menu.update()
|
|
|
|
waits 1
|
|
|
|
runs -> expect(menu.sendToBrowserProcess.argsForCall[0][1]['b']).toEqual ['ctrl-b']
|
|
|
|
it "omits key bindings that are mapped to unset! in any context", ->
|
|
# it would be nice to be smarter about omitting, but that would require a much
|
|
# more dynamic interaction between the currently focused element and the menu
|
|
spyOn(menu, 'sendToBrowserProcess')
|
|
menu.add [{label: "A", submenu: [{label: "B", command: "b"}]}]
|
|
atom.keymap.add 'test', 'atom-workspace': 'ctrl-b': 'b'
|
|
atom.keymap.add 'test', 'atom-text-editor': 'ctrl-b': 'unset!'
|
|
|
|
waits 1
|
|
|
|
runs -> expect(menu.sendToBrowserProcess.argsForCall[0][1]['b']).toBeUndefined()
|
|
|
|
it "updates the application menu when a keymap is reloaded", ->
|
|
spyOn(menu, 'update')
|
|
keymapPath = path.join(__dirname, 'fixtures', 'packages', 'package-with-keymaps', 'keymaps', 'keymap-1.cson')
|
|
atom.keymaps.reloadKeymap(keymapPath)
|
|
expect(menu.update).toHaveBeenCalled()
|