pulse-browser/browser
1
1
Fork 0
mirror of https://github.com/pulse-browser/browser.git synced 2024-09-11 20:47:49 +03:00
Code Issues Projects Releases Wiki Activity

Merge remove-extension-bug

Browse Source 
Remove extension bug
This commit is contained in:
PressJump 2022-10-12 16:28:06 +11:00 committed by GitHub
commit f61234ae8e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.github/PULL_REQUEST_TEMPLATE/ff_update.md vendored
View File

@ -9,7 +9,13 @@ This bumps Firefox up to `{NEW_VERSION}` for security and performance reasons. R
- [ ] The sidebar exists
- [ ] The settings and addons button are visible down the bottom
- [ ] The bookmarks, history and synced tabs icons are in the sidebar
- [ ] The sidebar can be resized properly
- [ ] An [installed extension](https://addons.mozilla.org/en-US/firefox/addon/sidebar-note/?utm_source=addons.mozilla.org&utm_medium=referral&utm_content=search) will appear in the sidebar
- [ ] Sidebar-Tabs is Loaded and has a button visible down the bottom
- [ ] Sidebar-Tabs can add a sidebar item to the sidebar
- [ ] Sidebar-Tabs can remove a sidebar item to the sidebar
- [ ] Extensions

13
src/browser/components/extensions/parent/ext-sidebarAction-js.patch
View File

@ -1,5 +1,5 @@
diff --git a/browser/components/extensions/parent/ext-sidebarAction.js b/browser/components/extensions/parent/ext-sidebarAction.js
index 99aa63874bc6f1821baae6788fbba18f6861f9c6..baa85eae1b458a3187838336eada4b4a32504cd5 100644
index 99aa63874bc6f1821baae6788fbba18f6861f9c6..76354d828578fabd297c817e15b7492c167958b9 100644
--- a/browser/components/extensions/parent/ext-sidebarAction.js
+++ b/browser/components/extensions/parent/ext-sidebarAction.js
@@ -14,6 +14,7 @@ var { ExtensionError } = ExtensionUtils;
@ -20,7 +20,16 @@ index 99aa63874bc6f1821baae6788fbba18f6861f9c6..baa85eae1b458a3187838336eada4b4a
// Don't remove everything on app shutdown so session restore can handle
// restoring open sidebars.
if (isAppShutdown) {
@@ -157,21 +161,30 @@ this.sidebarAction = class extends ExtensionAPI {
@@ -129,6 +133,8 @@ this.sidebarAction = class extends ExtensionAPI {
if (SidebarUI.lastOpenedId === sidebarId) {
SidebarUI.lastOpenedId = null;
}
+ // Remove the sidebar item from the sidebar menu.
+ SidebarUI.deleteSidebarItem(sidebarId);
}
}
@@ -157,21 +163,30 @@ this.sidebarAction = class extends ExtensionAPI {
}
let { document, SidebarUI } = window;
let keyId = `ext-key-id-${this.id}`;