1
1
mirror of https://github.com/qfpl/applied-fp-course.git synced 2024-11-26 14:43:53 +03:00
Commit Graph

36 Commits

Author SHA1 Message Date
Sean Chalmers
9bab205678 Merge branch 'master' of gitlab.com:qfpl/applied-fp-course 2017-09-12 13:41:26 +10:00
Sean Chalmers
4401cd65c9 Added -fwarn-missing-import-lists to GHC options. Fixed resulting errors 2017-09-12 13:28:27 +10:00
Tony Morris
5666f74aa1 update copyright notice 2017-09-12 11:51:26 +10:00
Tony Morris
ad0208776e LICENSE -> LICENCE 2017-09-12 11:47:41 +10:00
Sean Chalmers
00e02a3f9d Rebuilt Conf File Read Handling
Made the error management for loading the JSON config file work as one might
expect it should. Expanded the error reporting expectations to include specific
file reading and JSON decoding errors.

The difficulties that will be had in handling the multiple either values will
motivate latter sections RE ExceptT (EitherT) transformers. However there is
nothing here that should be beyond people that do not know how transformers
work.

Added more doctests to the different moving parts to make things a bit clearer.
Added doctests to the cabal files and included a 'doctests.hs' to the tests
section.

default.nix files have been updated with the bonus dependency.
2017-09-12 11:21:27 +10:00
Sean Chalmers
ec1bb07dae Add guidance about handling requests without persistent storage.
There is no persistent storage in the application by the time we're expecting
students to write ``Response`` handling functions. So add some more guidance
that we only expect placeholder values to be used, this wasn't sufficiently
clear. Fixes #3

Updated the latter placeholder values to match the guidance offered, for
consistency.

Updated the configuration ``helloMsg`` value and some of the tests to be a bit
more sensible, even if only a little.
2017-09-11 10:29:56 +10:00
Sean Chalmers
71a5c2f275 Issue fixes.
Reworded ``Error`` blurb to direct people to try to write other functions and
see what errors are needed. Fixes #1

Changed the ``Port`` type to ``Word16`` to be more precise about what values we
allow for a port number. Add a helper function to take a ``Conf`` to the ``Int``
value that Wai requires. Fixes #4
2017-09-11 09:46:17 +10:00
Sean Chalmers
f458bb074f Wording updates, description adjustments 2017-09-06 10:54:50 +10:00
Sean Chalmers
71e9982e08 Documentation updates. Removed some comments 2017-09-06 10:15:24 +10:00
Sean Chalmers
0dbad01d36 Removed some unnecessary comments/code 2017-09-06 09:35:33 +10:00
Sean Chalmers
b0f95deae9 Fixed a bug, reworded a bit, refactored a bit 2017-09-06 09:19:49 +10:00
Sean Chalmers
934f63497d Restructure part of the Conf.hs to provide more to do and with added guidance 2017-09-05 16:36:42 +10:00
Sean Chalmers
dc42b2091f Wording/formatting updates 2017-09-05 16:13:38 +10:00
Sean Chalmers
b69770bdbc Name changes to Applied name.
Wording and phrasing updates. Some functions changed around a bit to
be slightly less 'weird'.
2017-09-05 13:53:05 +10:00
Sean Chalmers
b3e15c2acd Wording updates
Changed the wording of some sections. Added more info to some of the
exercise README files.

Added some more structure to the tests exercise to make it a little
less open. Still undefined sections but there is a bit more guidance
about what things might look like.

Preparation for the name change to 'Applied' instead of 'Advanced'
2017-09-05 11:34:56 +10:00
Sean Chalmers
d59af985cb Updated layout of cabal files. Turned off some warnings for unused matches 2017-09-04 11:35:33 +10:00
Sean Chalmers
0aa03de8f1 Typo fixes, word changes to reduce the silly. 2017-09-04 11:04:52 +10:00
Sean Chalmers
58b7b7b575 Use correct content-type header.
The ContentType header text for JSON was incorrect as 'text/json',
and it has been updated to 'application/json'.
2017-09-04 10:41:45 +10:00
Sean Chalmers
942d093011 Formatting Adjustments
Just making things consistent across the various levels.
2017-09-04 10:20:31 +10:00
Sean Chalmers
2f20e0736c Level Readme Adjustments
I just found out about reference links in Markdown, this has the ability
to make the README markdown much easier to digest without losing the
nice ability to have hyperlinks directly in the documentation. But leaves
the text easier to digest for people that are not reading it through a
_Markdown prism.
2017-09-04 10:02:55 +10:00
Sean Chalmers
05d9ce923d Updated Response Builder Functions
Changed up the Response builder functions to be consistent with
the need to pass in the ContentType when constructing the response.
2017-09-04 09:29:38 +10:00
Sean Chalmers
a16b8d5849 All projects now compile without error. Certain warnings have been suppressed at a module level. Some types have been added back in to grease the wheels of getting underway 2017-09-01 14:27:41 +10:00
Sean Chalmers
7ee4a56bbe Updated ghc-options to remove -Werror, update to match options used by original fp-course 2017-09-01 11:26:26 +10:00
Sean Chalmers
f41ee50c75 change changelog files to lowercase 2017-09-01 11:17:26 +10:00
Sean Chalmers
30df1c9252 Banishing some words.
'Simply' and 'Just' are banned from instructional documentation, imo. Often, for
the people using these exercises, things are rarely either.
2017-08-31 15:39:58 +10:00
Sean Chalmers
b6d7786f92 More readme updates
Added a note about ghcid
2017-08-31 14:25:32 +10:00
Sean Chalmers
86fc64c3dd Add some more guidance.
Added readme files to the individual exercises to help point people in the right
direction when they get started. Probably more useful to the people that are
wanting to try this by themselves.
2017-08-31 11:31:08 +10:00
Sean Chalmers
4aa22d0e0b More wording updates
Removed more commented out code, removed some of the hand holding I had
and added some more indication of when you should probably just reach
for the docs
2017-08-24 14:34:01 +10:00
Sean Chalmers
5ba01551ad Wording updates.
Removing some commented out code.
2017-08-24 14:10:59 +10:00
Sean Chalmers
d901dedf24 Questions, questions... 2017-08-23 17:14:29 +10:00
Sean Chalmers
f7889ad714 Databasezz!
Added level05: installing a DB layer.

Updated the cabal files with a nice ghc-option of '-Wall -Werror'.

Added some more comments to the level04 testing page.
2017-08-15 15:17:04 +10:00
Sean Chalmers
14e7e81f46 Fix project restructure
Didn't properly move out the Main files to a separate location so
the dependencies and app building was a bit wacky. This fixes that.
2017-08-14 16:48:34 +10:00
Sean Chalmers
803e6c58e9 Clean Up
Don't need the extra status declarations for some of the Hspec tests
at level04 as hspec-wai assumes 200 until told otherwise.

Removed Hedgehog from level04 tests, don't have a good use case.
2017-08-11 15:54:21 +10:00
Sean Chalmers
8f8bb6c123 Minor adjustments 2017-08-11 15:30:00 +10:00
Sean Chalmers
d9ee08993b Fixing structure of Level03 2017-08-11 10:55:12 +10:00
Sean Chalmers
e701b91a7b Add Level 04
Level 04 contains some testing fun.

Removed spurious yaml file from level03.

Update README.

Have noticed irritating snafu RE the app structure. Not built as a
library in other levels, will fix.
2017-08-11 10:40:05 +10:00