From 2df699fb75d80dcafab5825b547de5fa8e5e4620 Mon Sep 17 00:00:00 2001 From: Tae Won Ha Date: Mon, 1 May 2017 00:39:34 +0200 Subject: [PATCH 1/4] Reduce app launch time by approx. 0.8s - 1s --- VimR/AppearancePref.swift | 2 ++ VimR/UiRoot.swift | 9 +++++++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/VimR/AppearancePref.swift b/VimR/AppearancePref.swift index 28ae92ce..fddf7a83 100644 --- a/VimR/AppearancePref.swift +++ b/VimR/AppearancePref.swift @@ -97,6 +97,8 @@ class AppearancePref: PrefPane, NSComboBoxDelegate, NSControlTextEditingDelegate fontPopup.translatesAutoresizingMaskIntoConstraints = false fontPopup.target = self fontPopup.action = #selector(AppearancePref.fontPopupAction) + + // This takes approx. 0.8s - 1s on my machine... -_- fontPopup.addItems(withTitles: self.fontManager.availableFontNames(with: .fixedPitchFontMask)!) let sizeCombo = self.sizeCombo diff --git a/VimR/UiRoot.swift b/VimR/UiRoot.swift index e693617a..17bafbb3 100644 --- a/VimR/UiRoot.swift +++ b/VimR/UiRoot.swift @@ -19,9 +19,14 @@ class UiRoot: UiComponent { self.emitter = emitter self.fileMonitor = FileMonitor(source: source, emitter: emitter, state: state) - self.prefWindow = PrefWindow(source: source, emitter: emitter, state: state) self.openQuicklyWindow = OpenQuicklyWindow(source: source, emitter: emitter, state: state) + // We dispatch the initialization of the pref window in the background since the population of the font list + // in the appearance pref pane takes approx. 0.8s - 1s on my machine... -_- + DispatchQueue.global(qos: .background).async { + self.prefWindow = PrefWindow(source: source, emitter: emitter, state: state) + } + source .observeOn(MainScheduler.instance) .subscribe(onNext: { [unowned self] state in @@ -48,8 +53,8 @@ class UiRoot: UiComponent { fileprivate let disposeBag = DisposeBag() fileprivate let fileMonitor: FileMonitor - fileprivate let prefWindow: PrefWindow fileprivate let openQuicklyWindow: OpenQuicklyWindow + fileprivate var prefWindow: PrefWindow? fileprivate var mainWindows = [String: MainWindow]() fileprivate var subjectForMainWindows = [String: PublishSubject]() From 39f3c0a67326a8f9dbd5668b92d2d1970dd1bbb3 Mon Sep 17 00:00:00 2001 From: Tae Won Ha Date: Mon, 1 May 2017 10:50:12 +0200 Subject: [PATCH 2/4] Update release notes: --- resources/release-notes.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/release-notes.md b/resources/release-notes.md index a41ac844..d481d2ff 100644 --- a/resources/release-notes.md +++ b/resources/release-notes.md @@ -1,6 +1,6 @@ -# next +# 0.14.1-182 -* ... +* Make app launch time much faster. # 0.14.0-181 From 3adadfbd5392d4d9a12eafb08467700d7ce0b07d Mon Sep 17 00:00:00 2001 From: Tae Won Ha Date: Mon, 1 May 2017 11:00:40 +0200 Subject: [PATCH 3/4] Bump version: v0.14.1-182 --- OutlineViewTest/Info.plist | 4 ++-- SwiftNeoVim/Info.plist | 4 ++-- SwiftNeoVimTests/Info.plist | 4 ++-- VimR-Workspace-Demo/Info.plist | 4 ++-- VimR.xcodeproj/project.pbxproj | 8 ++++---- VimR/Info.plist | 4 ++-- VimRTests/Info.plist | 4 ++-- 7 files changed, 16 insertions(+), 16 deletions(-) diff --git a/OutlineViewTest/Info.plist b/OutlineViewTest/Info.plist index cdd34dc4..4b4f6e67 100644 --- a/OutlineViewTest/Info.plist +++ b/OutlineViewTest/Info.plist @@ -17,9 +17,9 @@ CFBundlePackageType APPL CFBundleShortVersionString - 0.14.0 + 0.14.1 CFBundleVersion - 181 + 182 LSMinimumSystemVersion $(MACOSX_DEPLOYMENT_TARGET) NSHumanReadableCopyright diff --git a/SwiftNeoVim/Info.plist b/SwiftNeoVim/Info.plist index 3c44b163..fd519cd5 100644 --- a/SwiftNeoVim/Info.plist +++ b/SwiftNeoVim/Info.plist @@ -15,11 +15,11 @@ CFBundlePackageType FMWK CFBundleShortVersionString - 0.14.0 + 0.14.1 CFBundleSignature ???? CFBundleVersion - 181 + 182 NSHumanReadableCopyright Copyright © 2016 Tae Won Ha. All rights reserved. NSPrincipalClass diff --git a/SwiftNeoVimTests/Info.plist b/SwiftNeoVimTests/Info.plist index 95a86852..e112dc34 100644 --- a/SwiftNeoVimTests/Info.plist +++ b/SwiftNeoVimTests/Info.plist @@ -15,10 +15,10 @@ CFBundlePackageType BNDL CFBundleShortVersionString - 0.14.0 + 0.14.1 CFBundleSignature ???? CFBundleVersion - 181 + 182 diff --git a/VimR-Workspace-Demo/Info.plist b/VimR-Workspace-Demo/Info.plist index 229d8224..cc1e2773 100644 --- a/VimR-Workspace-Demo/Info.plist +++ b/VimR-Workspace-Demo/Info.plist @@ -17,11 +17,11 @@ CFBundlePackageType APPL CFBundleShortVersionString - 0.14.0 + 0.14.1 CFBundleSignature ???? CFBundleVersion - 181 + 182 LSMinimumSystemVersion $(MACOSX_DEPLOYMENT_TARGET) NSHumanReadableCopyright diff --git a/VimR.xcodeproj/project.pbxproj b/VimR.xcodeproj/project.pbxproj index 49917302..4e2eab7b 100644 --- a/VimR.xcodeproj/project.pbxproj +++ b/VimR.xcodeproj/project.pbxproj @@ -1493,7 +1493,7 @@ COMBINE_HIDPI_IMAGES = YES; DEFINES_MODULE = YES; DYLIB_COMPATIBILITY_VERSION = 1; - DYLIB_CURRENT_VERSION = 181; + DYLIB_CURRENT_VERSION = 182; DYLIB_INSTALL_NAME_BASE = "@rpath"; FRAMEWORK_SEARCH_PATHS = ( "$(inherited)", @@ -1517,7 +1517,7 @@ COMBINE_HIDPI_IMAGES = YES; DEFINES_MODULE = YES; DYLIB_COMPATIBILITY_VERSION = 1; - DYLIB_CURRENT_VERSION = 181; + DYLIB_CURRENT_VERSION = 182; DYLIB_INSTALL_NAME_BASE = "@rpath"; FRAMEWORK_SEARCH_PATHS = ( "$(inherited)", @@ -1709,7 +1709,7 @@ CLANG_WARN_UNREACHABLE_CODE = YES; CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; COPY_PHASE_STRIP = NO; - CURRENT_PROJECT_VERSION = 181; + CURRENT_PROJECT_VERSION = 182; DEBUG_INFORMATION_FORMAT = dwarf; ENABLE_STRICT_OBJC_MSGSEND = YES; ENABLE_TESTABILITY = YES; @@ -1759,7 +1759,7 @@ CLANG_WARN_UNREACHABLE_CODE = YES; CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; COPY_PHASE_STRIP = NO; - CURRENT_PROJECT_VERSION = 181; + CURRENT_PROJECT_VERSION = 182; DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym"; ENABLE_NS_ASSERTIONS = NO; ENABLE_STRICT_OBJC_MSGSEND = YES; diff --git a/VimR/Info.plist b/VimR/Info.plist index 16653812..96ab82c1 100644 --- a/VimR/Info.plist +++ b/VimR/Info.plist @@ -36,7 +36,7 @@ CFBundlePackageType APPL CFBundleShortVersionString - 0.14.0 + 0.14.1 CFBundleSignature ???? CFBundleURLTypes @@ -53,7 +53,7 @@ CFBundleVersion - 181 + 182 LSMinimumSystemVersion $(MACOSX_DEPLOYMENT_TARGET) NSHumanReadableCopyright diff --git a/VimRTests/Info.plist b/VimRTests/Info.plist index 95a86852..e112dc34 100644 --- a/VimRTests/Info.plist +++ b/VimRTests/Info.plist @@ -15,10 +15,10 @@ CFBundlePackageType BNDL CFBundleShortVersionString - 0.14.0 + 0.14.1 CFBundleSignature ???? CFBundleVersion - 181 + 182 From 62164fb81b3ef21983e72d320f188fdff7788feb Mon Sep 17 00:00:00 2001 From: Tae Won Ha Date: Mon, 1 May 2017 11:02:53 +0200 Subject: [PATCH 4/4] Bump appcast to v0.14.1-182 --- appcast.xml | 34 +++++++++------------------------- 1 file changed, 9 insertions(+), 25 deletions(-) diff --git a/appcast.xml b/appcast.xml index 6b42a364..fde76673 100644 --- a/appcast.xml +++ b/appcast.xml @@ -7,38 +7,22 @@ Most recent changes with links to updates for VimR. en - v0.14.0-181 + v0.14.1-182 -
  • GH-405: Redesign
      -
    • Redux-like architecture using RxSwift
      • -
    -
    • -
  • GH-383: Add a general web view preview which preserves the scroll position when (automatically) reloading the selected file.
    • -
  • GH-398: Set the represented icon in the window title bar.
    • -
  • GH-389: Bugfix: The Files tool does not update when one folder is created.
    • -
  • GH-374: Bugfix: The tool buttons have a narrow area which does not react to mouse down when the tool is closed.
    • -
  • Dependencies updates:
      -
    • RxSwift: 3.4.0
      • -
    • Sparkle: 1.17
      • -
    • github-markdown-css: 2.6.0
      • -
    • swifter: 1.3.3
      • -
    • Nimble: 6.1.0
      • -
    • neovim: neovim/neovim@337299c8082347feecb5e733bed993c6a5933456
      • -
    -
    • +
  • Make app launch time much faster: now just one bounce in the Dock on my machine 😆
    • ]]>     - https://github.com/qvacua/vimr/releases/tag/v0.14.0-181 + https://github.com/qvacua/vimr/releases/tag/v0.14.1-182 - 2017-04-30T19:14:21.693350 + 2017-05-01T11:02:53.057696 10.10.0 -