From 765f2c43d7c2396f64f85dd08565c045ed9dbeaf Mon Sep 17 00:00:00 2001 From: Tae Won Ha Date: Fri, 24 Jan 2020 17:48:15 +0100 Subject: [PATCH] GH-768 Do not force re-sign NvimServer When coc.nvim is installed, EXC_BAD_ACCESS (Code Signature Invalid) occurs and NvimServer crashes. We force re-signed NvimServer on Mojave because the notarization did not work (for whatever reason), but on Catalina, the notarization works without re-signing. And without re-signing, the crash does not occur. --- bin/build.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bin/build.sh b/bin/build.sh index c98d72be..82c4711c 100755 --- a/bin/build.sh +++ b/bin/build.sh @@ -91,9 +91,9 @@ echo "### VimR archive file name: ${vimr_file_name}" echo "### Notarizing" pushd ./build/Build/Products/Release > /dev/null - codesign \ - --force -s "Developer ID Application: Tae Won Ha (H96Q2NKTQH)" --timestamp --options=runtime \ - VimR.app/Contents/Frameworks/NvimView.framework/Versions/A/PlugIns/NvimServer +# codesign \ +# --force -s "Developer ID Application: Tae Won Ha (H96Q2NKTQH)" --timestamp --options=runtime \ +# VimR.app/Contents/Frameworks/NvimView.framework/Versions/A/PlugIns/NvimServer ditto -c -k --keepParent VimR.app VimR.app.zip echo "### Uploading" export readonly request_uuid=$(xcrun \