From 76a574efd1b834012fd77efcd9164a9052773b5c Mon Sep 17 00:00:00 2001
From: Tae Won Ha <h@taewon.de>
Date: Sun, 12 Dec 2021 21:41:27 +0100
Subject: [PATCH] Add build release script

---
 bin/build.sh            | 143 ----------------------------------------
 bin/build_release.sh    | 108 ++++++++++++++++++++++++++++++
 bin/clean_old_builds.sh |  16 -----
 3 files changed, 108 insertions(+), 159 deletions(-)
 delete mode 100755 bin/build.sh
 create mode 100755 bin/build_release.sh
 delete mode 100755 bin/clean_old_builds.sh

diff --git a/bin/build.sh b/bin/build.sh
deleted file mode 100755
index 8e73c448..00000000
--- a/bin/build.sh
+++ /dev/null
@@ -1,143 +0,0 @@
-#!/bin/bash
-set -Eeuo pipefail
-
-echo "### Building in Jenkins"
-pushd "$( dirname "${BASH_SOURCE[0]}" )/.." > /dev/null
-
-# for utf-8 for python script
-export LC_CTYPE=en_US.UTF-8
-export PATH=/usr/local/bin:$PATH
-
-readonly publish=${publish:?"true or false"}
-readonly branch=${branch:?"Eg develop"}
-readonly is_snapshot=${is_snapshot:?"true or false"}
-readonly update_appcast=${update_appcast:?"true or false"}
-readonly update_snapshot_appcast_for_release=${update_snapshot_appcast_for_release:?"true or false"}
-
-export marketing_version=${marketing_version:-"SNAPSHOT"}
-readonly release_notes=${release_notes:-""}
-
-readonly use_cache_carthage=${use_cache_carthage:?"true of false"}
-
-if [[ "${is_snapshot}" = false ]] && [[ "${marketing_version}" == "" ]] ; then
-    echo "### ERROR If not snapshot, then the marketing version must be set!"
-    exit 1
-fi
-
-if [[ "${publish}" == true ]] && [[ "${release_notes}" == "" ]] ; then
-    echo "### ERROR No release notes, but publishing to Github!"
-    exit 1
-fi
-
-if [[ "${is_snapshot}" == false ]] && [[ "${update_appcast}" == false ]] ; then
-    echo "### ERROR Not updating appcast for release!"
-    exit 1
-fi
-
-if [[ "${publish}" == true ]] && [[ "${use_cache_carthage}" == true ]] ; then
-    echo "### ERROR Publishing, but using cache for Carthage!"
-    exit 1
-fi
-
-if [[ "${is_snapshot}" == false ]] && [[ "${branch}" != "master" ]] ; then
-    echo "### ERROR Not building master for release!"
-    exit 1
-fi
-
-git lfs install
-
-echo "### Installing some python packages"
-
-pip3 install requests
-pip3 install Markdown
-pip3 install waiting
-
-echo "### Building VimR"
-
-git lfs pull
-
-./bin/prepare_repositories.sh
-./bin/clean_old_builds.sh
-
-if [[ "${is_snapshot}" == false ]] || [[ "${publish}" == true ]] ; then
-    ./bin/set_new_versions.sh
-else
-    echo "Not publishing and no release => not incrementing the version..."
-fi
-
-code_sign=true use_carthage_cache=${use_cache_carthage} ./bin/build_vimr.sh
-
-pushd VimR > /dev/null
-    export readonly bundle_version=$(agvtool what-version | sed '2q;d' | sed -E 's/ +(.+)/\1/')
-    export marketing_version=$(agvtool what-marketing-version | tail -n 1 | sed -E 's/.*of "(.*)" in.*/\1/')
-popd > /dev/null
-
-
-if [[ "${is_snapshot}" == true ]]; then
-    export readonly compound_version="SNAPSHOT-${bundle_version}"
-    export readonly tag="snapshot/${bundle_version}"
-else
-    export readonly compound_version="v${marketing_version}-${bundle_version}"
-    export readonly tag=${compound_version}
-fi
-
-echo "### Compressing the app"
-export readonly vimr_file_name="VimR-${compound_version}.tar.bz2"
-
-pushd build/Build/Products/Release > /dev/null
-  tar cjf ${vimr_file_name} VimR.app
-popd > /dev/null
-
-echo "### Bundle version: ${bundle_version}"
-echo "### Marketing version: ${marketing_version}"
-echo "### Compund version: ${compound_version}"
-echo "### Tag: ${tag}"
-echo "### VimR archive file name: ${vimr_file_name}"
-
-echo "### Notarizing"
-pushd ./build/Build/Products/Release > /dev/null
-    ditto -c -k --keepParent VimR.app VimR.app.zip
-    echo "### Uploading"
-    export readonly request_uuid=$(xcrun \
-        altool --notarize-app --primary-bundle-id "com.qvacua.VimR" \
-        --username "hataewon@gmail.com" --password "@keychain:dev-notar" \
-        --file VimR.app.zip | grep RequestUUID | sed -E 's/.* = (.*)/\1/')
-popd > /dev/null
-
-echo "### Waiting for notarization ${request_uuid} to finish"
-./bin/wait_for_notarization.py
-echo "### Notarization finished"
-
-pushd ./build/Build/Products/Release > /dev/null
-    rm -rf ${vimr_file_name}
-    xcrun stapler staple VimR.app
-    tar cjf ${vimr_file_name} VimR.app
-popd > /dev/null
-
-if [[ "${publish}" == false ]] ; then
-    echo "Do not publish => exiting now..."
-    exit 0
-fi
-
-./bin/commit_and_push_tags.sh
-./bin/create_github_release.sh
-
-if [[ "${update_appcast}" == true ]]; then
-    ./bin/set_appcast.py "build/Build/Products/Release/${vimr_file_name}" "${bundle_version}" "${marketing_version}" "${tag}" ${is_snapshot}
-    ./bin/commit_and_push_appcast.sh "${branch}" "${compound_version}" ${is_snapshot} ${update_snapshot_appcast_for_release}
-else
-    echo "Not updating appcast on develop => exiting now..."
-    exit 0
-fi
-
-if [[ "${is_snapshot}" == false ]] ; then
-    echo "### Merging ${branch} back to develop"
-    git reset --hard @
-    git fetch origin
-    git checkout -b for_master_to_develop origin/develop
-    git merge --ff-only for_build
-    git push origin HEAD:develop
-fi
-
-popd > /dev/null
-echo "### Built VimR"
diff --git a/bin/build_release.sh b/bin/build_release.sh
new file mode 100755
index 00000000..201bec36
--- /dev/null
+++ b/bin/build_release.sh
@@ -0,0 +1,108 @@
+#!/bin/bash
+set -Eeuo pipefail
+
+readonly is_snapshot=${is_snapshot:?"true or false"}
+readonly bundle_version=${bundle_version:?"date '+%Y%m%d.%H%M%S'"}
+readonly tag=${tag:?"snapshot/xyz or v0.35.0"}
+readonly marketing_version=${marketing_version:?"SNAPSHOT-xyz or v0.35.0 (mind the v-prefix when not snapshot"}
+readonly upload=${upload:?"true or false"}
+readonly update_appcast=${update_appcast:?"true or false"}
+readonly build_folder_path="./build/Build/Products/Release"
+readonly vimr_artifact_path="${build_folder_path}/VimR-${marketing_version}.tar.bz2"
+readonly GH_REPO="qvacua/vimr"
+
+prepare_bin() {
+  pushd ./bin >/dev/null
+    if ! pyenv which python | grep -q "com.qvacua.VimR.bin"; then
+      echo "com.qvacua.VimR.bin virtualenv not set up!"
+      exit 1;
+    fi
+
+    pip install -r requirements.txt
+  popd >/dev/null
+}
+
+check_version() {
+  if [[ "${is_snapshot}" == true && ! "${marketing_version}" =~ ^SNAPSHOT.* ]]; then
+    echo "When snapshot, marketing_version should be SNAPSHOT-xyz"
+    exit 1
+  fi
+
+  if [[ "${is_snapshot}" == false && ! "${marketing_version}" =~ ^v.* ]]; then
+    echo "When no snapshot, marketing_version should be like v0.35.0"
+    exit 1
+  fi
+}
+
+check_upload() {
+  if [[ "${upload}" == true ]]; then
+    if ! gh release list | grep -q "${tag}"; then
+      echo "Release with tag ${tag} does not exit!"
+      exit 1
+    fi
+  fi
+}
+
+build_release() {
+  echo "### Building release"
+  code_sign=true use_carthage_cache=false download_deps=true ./bin/build_vimr.sh
+
+  vimr_app_path="${build_folder_path}/VimR.app" ./bin/notarize_vimr.sh
+
+  pushd "${build_folder_path}" >/dev/null
+    tar cjf "VimR-${marketing_version}.tar.bz2" VimR.app
+  popd >/dev/null
+  echo "### Built (signed and notarized) release: ${vimr_artifact_path}"
+}
+
+upload_artifact() {
+  local -x GH_TOKEN
+  GH_TOKEN=$(cat ~/.local/secrets/github.qvacua.release.token)
+  readonly GH_TOKEN
+
+  echo "### Uploading artifact"
+  gh release upload "${tag}" "${vimr_artifact_path}"
+  echo "### Uploaded artifact"
+}
+
+update_appcast_file() {
+  ./bin/set_appcast.py \
+      "${vimr_artifact_path}" \
+      "${bundle_version}" \
+      "${marketing_version}" \
+      "${tag}" \
+      "${is_snapshot}"
+
+  local app_cast_file_name="appcast.xml"
+  if [[ "${is_snapshot}" == true ]]; then
+    app_cast_file_name="appcast_snapshot.xml"
+  fi
+  readonly app_cast_file_name
+
+  cp "${build_folder_path}/${app_cast_file_name}" .
+  echo "### ${app_cast_file_name} updated. Commit and push"
+}
+
+main() {
+  echo "is_snapshot=${is_snapshot} bundle_version=${bundle_version}" \
+      "tag=${tag} marketing_version=${marketing_version}" \
+      "upload=${upload} update_appcast=${update_appcast}" \
+      "vimr_artifact_path=${vimr_artifact_path}"
+
+  pushd "$(dirname "${BASH_SOURCE[0]}")/.." >/dev/null
+    check_version
+    check_upload
+    prepare_bin
+    build_release
+
+    if [[ "${upload}" == true ]]; then
+      upload_artifact
+    fi
+
+    if [[ "${update_appcast}" == true ]]; then
+      update_appcast_file
+    fi
+  popd >/dev/null
+}
+
+main
\ No newline at end of file
diff --git a/bin/clean_old_builds.sh b/bin/clean_old_builds.sh
deleted file mode 100755
index 7825daff..00000000
--- a/bin/clean_old_builds.sh
+++ /dev/null
@@ -1,16 +0,0 @@
-#!/bin/bash
-set -Eeuo pipefail
-
-echo "### Cleaning old builds"
-pushd "$( dirname "${BASH_SOURCE[0]}" )/.." > /dev/null
-
-rm -rf build
-xcodebuild -workspace VimR.xcworkspace -derivedDataPath build -scheme VimR clean
-
-pushd NvimView/neovim > /dev/null
-    rm -rf build
-    make distclean
-popd > /dev/null
-
-popd > /dev/null
-echo "### Cleaned old builds"