GH-328 Add sanity check in build script and set develop as the default

branch

bin/build.sh

@@ -3,6 +3,7 @@
 # For jenkins
 
 set -e
+set -x
 
 # for utf-8 for python script
 export LC_CTYPE=en_US.UTF-8
@@ -15,6 +16,31 @@ export PATH=/usr/local/bin:$PATH
 # - RELEASE_NOTES
 # - UPDATE_APPCAST
 
+if [ "${IS_SNAPSHOT}" = false ] && [ "${MARKETING_VERSION}" == "" ] ; then
+    echo "### ERROR If not snapshot, then the marketing version must be set!"
+    exit 1
+fi
+
+if [ "${RELEASE_NOTES}" == "" ] ; then
+    echo "### ERROR No release notes!"
+    exit 1
+fi
+
+if [ "${IS_SNAPSHOT}" = false ] && [ $"{UPDATE_APPCAST}" = false ] ; then
+    echo "### ERROR Not updating appcast for release!"
+    exit 1
+fi
+
+if [ "${IS_SNAPSHOT}" = false ] && [ $"{BRANCH}" != "master" ] ; then
+    echo "### ERROR Not building master for release!"
+    exit 1
+fi
+
+if [ "${IS_SNAPSHOT}" = true ] && [ $"{BRANCH}" == "master" ] ; then
+    echo "### ERROR Building master for snapshot!"
+    exit 1
+fi
+
 echo "### Installing some python packages"
 
 pip install requests

bin/build_vimr.sh

@@ -1,6 +1,7 @@
 #!/bin/bash
 
 set -e
+set -x
 
 CODE_SIGN=$1
 

bin/clean_old_builds.sh

@@ -1,6 +1,7 @@
 #!/bin/bash
 
 set -e
+set -x
 
 echo "### Cleaning old builds"
 

bin/commit_and_push_appcast.sh

@@ -1,6 +1,7 @@
 #!/bin/bash
 
 set -e
+set -x
 
 BRANCH=$1
 COMPOUND_VERSION=$2

bin/commit_and_push_tags.sh

@@ -1,6 +1,7 @@
 #!/bin/bash
 
 set -e
+set -x
 
 BRANCH=$1
 TAG=$2

bin/create_github_release.sh

@@ -1,6 +1,7 @@
 #!/bin/bash
 
 set -e
+set -x
 
 COMPOUND_VERSION=$1
 TAG=$2

bin/prepare_repositories.sh

@@ -1,6 +1,7 @@
 #!/bin/bash
 
 set -e
+set -x
 
 echo "### Preparing repositories"
 

bin/set_new_versions.sh

@@ -1,6 +1,7 @@
 #!/bin/bash
 
 set -e
+set -x
 
 IS_SNAPSHOT=$1
 MARKETING_VERSION=$2

ci/create_build_snapshot_job.groovy

@@ -21,7 +21,7 @@ Builds a new snapshot of VimR and pushes the tag:<br>
   }
 
   parameters {
-    stringParam('BRANCH', 'master', 'Branch to build; defaults to master')
+    stringParam('BRANCH', 'develop', 'Branch to build; defaults to develop')
     textParam('RELEASE_NOTES', null, 'Release notes')
     booleanParam('IS_SNAPSHOT', true)
     booleanParam('UPDATE_APPCAST', true)
@@ -38,7 +38,6 @@ Builds a new snapshot of VimR and pushes the tag:<br>
   }
 
   wrappers {
-    timestamps()
     colorizeOutput()
   }