on develop help sign in
Don't convert to String when sending Text data through websockets.

This avoids going from Text -> String -> JSString to simply Text -> JSString Also even cheaper if using text-jsstring patches

commit413d43372b17b3031bee017f7780502232fab8cb authorLuigy Leon <luigy@outlook.com> dateThu 1 Jun 2017, 20:51 (9 years ago) parentcb342ab
1 file changed+1−2
reflex-dom-core/src/Reflex/Dom/WebSocket/Foreign.hs+1−2
reflex-dom-core/src/Reflex/Dom/WebSocket/Foreign.hs+1−2
@@ -16,7 +16,6 @@ import Control.Monad.Reader
1616import Data.Bifoldable
1717import Data.ByteString (ByteString)
1818import Data.Text (Text)
19−import qualified Data.Text as T (unpack)
2019import Data.Text.Encoding
2120import Foreign.JavaScript.Utils (bsFromMutableArrayBuffer, bsToArrayBuffer)
2221import GHCJS.DOM.CloseEvent
@@ -46,7 +45,7 @@ instance IsWebSocketMessage ByteString where
4645
4746-- Use plaintext websocket communication for Text, and String
4847instance IsWebSocketMessage Text where
49− webSocketSend (JSWebSocket ws) = DOM.sendString ws . T.unpack
48+ webSocketSend (JSWebSocket ws) = DOM.sendString ws
5049
5150closeWebSocket :: JSWebSocket -> Word -> Text -> JSM ()
5251closeWebSocket (JSWebSocket ws) code reason = DOM.close ws (Just code) (Just reason)